)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1e5e88ba1857cc6b99e55c6389f93f19453b3bd8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Activate the LV before creating a target."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Don\u0027t use permanent\u003dTrue for activation, since this is not"},{"line_number":16,"context_line":"compatible with thin cloned volumes."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This fixes a failure to clone a volume from another thin"},{"line_number":19,"context_line":"LVM volume in the same pool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_54e0f8fa","line":16,"updated":"2017-07-20 14:52:52.000000000","message":"?:  Really?  Because according to the man page it\u0027s precisely for snapshots.  Are the docs wrong?","commit_id":"4a76b34cc88b24645b2cb24d0a4d3797c1bf2e22"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e1eb3673b39de85a05fe86973bcc029e1bccd970","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Activate the LV before creating a target."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Don\u0027t use permanent\u003dTrue for activation, since this is not"},{"line_number":16,"context_line":"compatible with thin cloned volumes."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This fixes a failure to clone a volume from another thin"},{"line_number":19,"context_line":"LVM volume in the same pool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_068231c9","line":16,"in_reply_to":"1f1a1f67_06e6b1e9","updated":"2017-07-21 13:33:08.000000000","message":"Interestingly, this works though:\n    # lvchange -k n cinder-volumes/erictest\n    # lvchange -a y -K cinder-volumes/erictest\n\nHmm.","commit_id":"4a76b34cc88b24645b2cb24d0a4d3797c1bf2e22"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"316bb3f12ad89715d3c0a790ca0ed54c2729091f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Activate the LV before creating a target."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Don\u0027t use permanent\u003dTrue for activation, since this is not"},{"line_number":16,"context_line":"compatible with thin cloned volumes."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This fixes a failure to clone a volume from another thin"},{"line_number":19,"context_line":"LVM volume in the same pool."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_06e6b1e9","line":16,"in_reply_to":"1f1a1f67_54e0f8fa","updated":"2017-07-21 13:30:54.000000000","message":"Well this is what happens:\n\n    # lvcreate --name erictest --snapshot cinder-volumes/volume-ee187d62-e1e3-487d-8774-b13ee5e19e8d\n  Using default stripesize 64.00 KiB.\n  Logical volume \"erictest\" created.\n    # lvchange -a y -K -k n cinder-volumes/erictest\n  Command does not accept option: --ignoreactivationskip.\n\nlvm2-2.02.171-8.el7.x86_64","commit_id":"4a76b34cc88b24645b2cb24d0a4d3797c1bf2e22"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f39359ec210d82d5c6855d5776f0e5e49ce4267e","unresolved":false,"context_lines":[{"line_number":790,"context_line":"        volume_path \u003d \"/dev/%s/%s\" % (self.configuration.volume_group,"},{"line_number":791,"context_line":"                                      volume[\u0027name\u0027])"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        self.vg.activate_lv(volume[\u0027name\u0027])"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        model_update \u003d \\"},{"line_number":796,"context_line":"            self.target_driver.ensure_export(context, volume, volume_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_9bfd49b3","line":793,"updated":"2017-07-25 11:15:34.000000000","message":"-1: volume.name","commit_id":"99d79431e3e00f15b33a6d1db7c0b9ba4d2a8e05"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f39359ec210d82d5c6855d5776f0e5e49ce4267e","unresolved":false,"context_lines":[{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        volume_path \u003d \"/dev/%s/%s\" % (vg, volume[\u0027name\u0027])"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        self.vg.activate_lv(volume[\u0027name\u0027])"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"        export_info \u003d self.target_driver.create_export("},{"line_number":808,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_7b2e2544","line":805,"updated":"2017-07-25 11:15:34.000000000","message":"ditto","commit_id":"99d79431e3e00f15b33a6d1db7c0b9ba4d2a8e05"}]}