)]}'
{"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"10e7317e96ddddf5c38b12875f880bd72d2cac4e","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                        source_rbd_image.remove_snap(from_snap)"},{"line_number":656,"context_line":"                        if src_vol_snapshots:"},{"line_number":657,"context_line":"                            from_snap \u003d src_vol_snapshots.pop(0)[\u0027name\u0027]"},{"line_number":658,"context_line":"                    from_snap \u003d None"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"                # Create new base image"},{"line_number":661,"context_line":"                self._create_base_image(base_name, length, client)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_6ce9c918","line":658,"updated":"2017-07-25 12:43:11.000000000","message":"-1: This will destroy any value that we set on L657","commit_id":"366b12fd9c9c7259d1168230f7c58bfaf736d286"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"10e7317e96ddddf5c38b12875f880bd72d2cac4e","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                while from_snap and not self._snap_exists("},{"line_number":671,"context_line":"                        base_name, from_snap, client):"},{"line_number":672,"context_line":"                    source_rbd_image.remove_snap(from_snap)"},{"line_number":673,"context_line":"                    from_snap \u003d self._get_most_recent_snap(source_rbd_image)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"        LOG.debug(\"Using --from-snap \u0027%(snap)s\u0027 for incremental backup of \""},{"line_number":676,"context_line":"                  \"volume %(volume)s.\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_6c60a9a6","line":673,"updated":"2017-07-25 12:43:11.000000000","message":"-1: We should be making all the cleanup of snapshots in the _get_most_recent_snap method, that way we know from the start if we really have a snapshot to work from or not.","commit_id":"366b12fd9c9c7259d1168230f7c58bfaf736d286"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"293241829c6667640e0d02b7dad5f5f7cfe426b6","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                if src_vol_snapshots:"},{"line_number":668,"context_line":"                    # If there are source volume snapshots but base does not"},{"line_number":669,"context_line":"                    # exist then we delete it and set from_snap to None"},{"line_number":670,"context_line":"                    LOG.debug(\"Volume \u0027%(volume)s\u0027 has stale source\""},{"line_number":671,"context_line":"                              \"snapshots so deleting them.\","},{"line_number":672,"context_line":"                              {\u0027volume\u0027: volume_id})"},{"line_number":673,"context_line":"                while src_vol_snapshots:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_cc766c07","line":670,"range":{"start_line":670,"start_character":66,"end_line":670,"end_character":68},"updated":"2017-08-10 19:09:53.000000000","message":"Missing space on the end.","commit_id":"fd98b9141611f3b2bed0591d008d63bb6a22b51a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"293241829c6667640e0d02b7dad5f5f7cfe426b6","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                    LOG.debug(\"Volume \u0027%(volume)s\u0027 has stale source\""},{"line_number":671,"context_line":"                              \"snapshots so deleting them.\","},{"line_number":672,"context_line":"                              {\u0027volume\u0027: volume_id})"},{"line_number":673,"context_line":"                while src_vol_snapshots:"},{"line_number":674,"context_line":"                    from_snap \u003d src_vol_snapshots.pop(0)[\u0027name\u0027]"},{"line_number":675,"context_line":"                    source_rbd_image.remove_snap(from_snap)"},{"line_number":676,"context_line":"                from_snap \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_4cd15ccd","line":673,"updated":"2017-08-10 19:09:53.000000000","message":"Might want to use a for loop here. I think Python is OK with it, but can cause issues with modifying a collection being used inside a loop.","commit_id":"fd98b9141611f3b2bed0591d008d63bb6a22b51a"}]}