)]}'
{"cinder/volume/drivers/ibm/ibm_storage/xiv_proxy.py":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"35a2e5d7f72973247ee25cdc7a50e36f04186063","unresolved":false,"context_lines":[{"line_number":589,"context_line":"            group_name \u003d self._cg_name_from_group(group)"},{"line_number":590,"context_line":"            try:"},{"line_number":591,"context_line":"                self._create_consistencygroup_on_remote(context, group_name)"},{"line_number":592,"context_line":"            except errors.CgNameExistsError:"},{"line_number":593,"context_line":"                pass"},{"line_number":594,"context_line":"            repl.GroupReplication(self).create_replication(group_name,"},{"line_number":595,"context_line":"                                                           replication_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_23ed0625","line":592,"range":{"start_line":592,"start_character":12,"end_line":592,"end_character":44},"updated":"2017-08-10 20:07:38.000000000","message":"How about logging a debug message?","commit_id":"c4a2282351edc3d66fe059611b47af2db2645d16"},{"author":{"_account_id":17947,"name":"Tzur Eliyahu","email":"tzure@il.ibm.com","username":"TzurEliyahu"},"change_message_id":"23993d75ec19abfe1765d7eb9b5a100aeb1bd650","unresolved":false,"context_lines":[{"line_number":589,"context_line":"            group_name \u003d self._cg_name_from_group(group)"},{"line_number":590,"context_line":"            try:"},{"line_number":591,"context_line":"                self._create_consistencygroup_on_remote(context, group_name)"},{"line_number":592,"context_line":"            except errors.CgNameExistsError:"},{"line_number":593,"context_line":"                pass"},{"line_number":594,"context_line":"            repl.GroupReplication(self).create_replication(group_name,"},{"line_number":595,"context_line":"                                                           replication_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_971f1ab6","line":592,"range":{"start_line":592,"start_character":12,"end_line":592,"end_character":44},"in_reply_to":"9f436f4f_23ed0625","updated":"2017-08-13 08:28:19.000000000","message":"Done","commit_id":"c4a2282351edc3d66fe059611b47af2db2645d16"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"35a2e5d7f72973247ee25cdc7a50e36f04186063","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                # xiv locks volumes after deletion of replication."},{"line_number":641,"context_line":"                # we need to unlock it for further use."},{"line_number":642,"context_line":"                try:"},{"line_number":643,"context_line":"                    self.ibm_storage_cli.cmd.vol_unlock(vol\u003dvolume[\u0027name\u0027])"},{"line_number":644,"context_line":"                    self.ibm_storage_remote_cli.cmd.vol_unlock("},{"line_number":645,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":646,"context_line":"                    self.ibm_storage_remote_cli.cmd.cg_remove_vol("},{"line_number":647,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":648,"context_line":"                except errors.XCLIError as e:"},{"line_number":649,"context_line":"                    details \u003d self._get_code_and_status_or_message(e)"},{"line_number":650,"context_line":"                    msg \u003d (\u0027Failed to unlock volumes %(details)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_035b22f7","line":647,"range":{"start_line":643,"start_character":20,"end_line":647,"end_character":43},"updated":"2017-08-10 20:07:38.000000000","message":"better add special handling in case volume does not exist","commit_id":"c4a2282351edc3d66fe059611b47af2db2645d16"},{"author":{"_account_id":17947,"name":"Tzur Eliyahu","email":"tzure@il.ibm.com","username":"TzurEliyahu"},"change_message_id":"23993d75ec19abfe1765d7eb9b5a100aeb1bd650","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                # xiv locks volumes after deletion of replication."},{"line_number":641,"context_line":"                # we need to unlock it for further use."},{"line_number":642,"context_line":"                try:"},{"line_number":643,"context_line":"                    self.ibm_storage_cli.cmd.vol_unlock(vol\u003dvolume[\u0027name\u0027])"},{"line_number":644,"context_line":"                    self.ibm_storage_remote_cli.cmd.vol_unlock("},{"line_number":645,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":646,"context_line":"                    self.ibm_storage_remote_cli.cmd.cg_remove_vol("},{"line_number":647,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":648,"context_line":"                except errors.XCLIError as e:"},{"line_number":649,"context_line":"                    details \u003d self._get_code_and_status_or_message(e)"},{"line_number":650,"context_line":"                    msg \u003d (\u0027Failed to unlock volumes %(details)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_577bf2f3","line":647,"range":{"start_line":643,"start_character":20,"end_line":647,"end_character":43},"in_reply_to":"9f436f4f_035b22f7","updated":"2017-08-13 08:28:19.000000000","message":"Done","commit_id":"c4a2282351edc3d66fe059611b47af2db2645d16"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"35a2e5d7f72973247ee25cdc7a50e36f04186063","unresolved":false,"context_lines":[{"line_number":665,"context_line":"            # update status"},{"line_number":666,"context_line":"            for volume in volumes:"},{"line_number":667,"context_line":"                try:"},{"line_number":668,"context_line":"                    self.ibm_storage_cli.cmd.vol_unlock(vol\u003dvolume[\u0027name\u0027])"},{"line_number":669,"context_line":"                    self.ibm_storage_remote_cli.cmd.vol_unlock("},{"line_number":670,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":671,"context_line":"                except errors.XCLIError as e:"},{"line_number":672,"context_line":"                    details \u003d self._get_code_and_status_or_message(e)"},{"line_number":673,"context_line":"                    msg \u003d (\u0027Failed to unlock volumes %(details)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_a36fb690","line":670,"range":{"start_line":668,"start_character":20,"end_line":670,"end_character":43},"updated":"2017-08-10 20:07:38.000000000","message":"same comment as above","commit_id":"c4a2282351edc3d66fe059611b47af2db2645d16"},{"author":{"_account_id":17947,"name":"Tzur Eliyahu","email":"tzure@il.ibm.com","username":"TzurEliyahu"},"change_message_id":"23993d75ec19abfe1765d7eb9b5a100aeb1bd650","unresolved":false,"context_lines":[{"line_number":665,"context_line":"            # update status"},{"line_number":666,"context_line":"            for volume in volumes:"},{"line_number":667,"context_line":"                try:"},{"line_number":668,"context_line":"                    self.ibm_storage_cli.cmd.vol_unlock(vol\u003dvolume[\u0027name\u0027])"},{"line_number":669,"context_line":"                    self.ibm_storage_remote_cli.cmd.vol_unlock("},{"line_number":670,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":671,"context_line":"                except errors.XCLIError as e:"},{"line_number":672,"context_line":"                    details \u003d self._get_code_and_status_or_message(e)"},{"line_number":673,"context_line":"                    msg \u003d (\u0027Failed to unlock volumes %(details)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_7771560c","line":670,"range":{"start_line":668,"start_character":20,"end_line":670,"end_character":43},"in_reply_to":"9f436f4f_a36fb690","updated":"2017-08-13 08:28:19.000000000","message":"This is the local volume. If we get any exception here like vol bad name (not exists) we should raise it and not just pass like in the other case with the remote vol.","commit_id":"c4a2282351edc3d66fe059611b47af2db2645d16"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"54c9f8bfd3267a85c68075279fab3152ba431887","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            try:"},{"line_number":591,"context_line":"                self._create_consistencygroup_on_remote(context, group_name)"},{"line_number":592,"context_line":"            except errors.CgNameExistsError:"},{"line_number":593,"context_line":"                LOG.debug(\"CG name exists, no need to open it on \""},{"line_number":594,"context_line":"                          \"secondary backend.\")"},{"line_number":595,"context_line":"                pass"},{"line_number":596,"context_line":"            repl.GroupReplication(self).create_replication(group_name,"},{"line_number":597,"context_line":"                                                           replication_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_5a4f976a","line":594,"range":{"start_line":593,"start_character":1,"end_line":594,"end_character":47},"updated":"2017-08-13 10:33:47.000000000","message":"what CG? better add it to the debug message","commit_id":"d1a418213b02f2ca57476ad655492da1ea6ac586"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"54c9f8bfd3267a85c68075279fab3152ba431887","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                    self.ibm_storage_remote_cli.cmd.cg_remove_vol("},{"line_number":649,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":650,"context_line":"                except errors.VolumeBadNameError:"},{"line_number":651,"context_line":"                    LOG.debug(\"ignore in case volume does not exist.\")"},{"line_number":652,"context_line":"                    pass"},{"line_number":653,"context_line":"                except errors.XCLIError as e:"},{"line_number":654,"context_line":"                    details \u003d self._get_code_and_status_or_message(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_ba3fa3b2","line":651,"range":{"start_line":651,"start_character":20,"end_line":651,"end_character":70},"updated":"2017-08-13 10:33:47.000000000","message":"which volume? what happened? \"Failed to remove volume %(vol)s - ignoring\" would be better","commit_id":"d1a418213b02f2ca57476ad655492da1ea6ac586"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"be0f10bd452cfe7fe5dac8099530a1bac30af008","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            except errors.CgNameExistsError:"},{"line_number":593,"context_line":"                LOG.debug(\"CG name %(cg)s exists, no need to open it on \""},{"line_number":594,"context_line":"                          \"secondary backend.\", {\u0027cg\u0027: group_name})"},{"line_number":595,"context_line":"                pass"},{"line_number":596,"context_line":"            repl.GroupReplication(self).create_replication(group_name,"},{"line_number":597,"context_line":"                                                           replication_info)"},{"line_number":598,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_71a6d0ad","line":595,"range":{"start_line":595,"start_character":16,"end_line":595,"end_character":20},"updated":"2017-08-15 14:32:40.000000000","message":"Remove this pass.","commit_id":"612fbb23d9b18062b8a0094a702cd4a8d1fd7b9c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"be0f10bd452cfe7fe5dac8099530a1bac30af008","unresolved":false,"context_lines":[{"line_number":650,"context_line":"                except errors.VolumeBadNameError:"},{"line_number":651,"context_line":"                    LOG.debug(\"Failed to delete vol %(vol)s - \""},{"line_number":652,"context_line":"                              \"ignoring.\", {\u0027vol\u0027: volume[\u0027name\u0027]})"},{"line_number":653,"context_line":"                    pass"},{"line_number":654,"context_line":"                except errors.XCLIError as e:"},{"line_number":655,"context_line":"                    details \u003d self._get_code_and_status_or_message(e)"},{"line_number":656,"context_line":"                    msg \u003d (\u0027Failed to unlock volumes %(details)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_31be08b4","line":653,"range":{"start_line":653,"start_character":20,"end_line":653,"end_character":24},"updated":"2017-08-15 14:32:40.000000000","message":"Same","commit_id":"612fbb23d9b18062b8a0094a702cd4a8d1fd7b9c"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"cfeafd49f2f1f6a97617fd60a7121f09ad18b731","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":677,"context_line":"                except errors.XCLIError as e:"},{"line_number":678,"context_line":"                    details \u003d self._get_code_and_status_or_message(e)"},{"line_number":679,"context_line":"                    msg \u003d (\u0027Failed to unlock volumes %(details)s\u0027 %"},{"line_number":680,"context_line":"                           {\u0027details\u0027: details})"},{"line_number":681,"context_line":"                    LOG.error(msg)"},{"line_number":682,"context_line":"                    raise self.meta[\u0027exception\u0027].VolumeBackendAPIException("},{"line_number":683,"context_line":"                        data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_d1d33c03","line":680,"range":{"start_line":679,"start_character":0,"end_line":680,"end_character":48},"updated":"2017-08-15 14:34:53.000000000","message":"Since this is going to an exception it should be translated please.","commit_id":"612fbb23d9b18062b8a0094a702cd4a8d1fd7b9c"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"7ec1de8b49c25a7e118ff3a196d2376c883d7540","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                # xiv locks volumes after deletion of replication."},{"line_number":656,"context_line":"                # we need to unlock it for further use."},{"line_number":657,"context_line":"                try:"},{"line_number":658,"context_line":"                    self.ibm_storage_cli.cmd.vol_unlock(vol\u003dvolume[\u0027name\u0027])"},{"line_number":659,"context_line":"                    self.ibm_storage_remote_cli.cmd.vol_unlock("},{"line_number":660,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":661,"context_line":"                    self.ibm_storage_remote_cli.cmd.cg_remove_vol("},{"line_number":662,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":663,"context_line":"                except errors.VolumeBadNameError:"},{"line_number":664,"context_line":"                    LOG.debug(\"Failed to delete vol %(vol)s - \""},{"line_number":665,"context_line":"                              \"ignoring.\", {\u0027vol\u0027: volume[\u0027name\u0027]})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_9a90c397","line":662,"range":{"start_line":658,"start_character":1,"end_line":662,"end_character":43},"updated":"2017-09-04 03:25:31.000000000","message":"Change volume[\u0027name\u0027] to volume.name","commit_id":"cb5ce14453c059dc7efe14630e3ed328f27fb8b7"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"7ec1de8b49c25a7e118ff3a196d2376c883d7540","unresolved":false,"context_lines":[{"line_number":682,"context_line":""},{"line_number":683,"context_line":"            # update status"},{"line_number":684,"context_line":"            for volume in volumes:"},{"line_number":685,"context_line":"                try:"},{"line_number":686,"context_line":"                    self.ibm_storage_cli.cmd.vol_unlock(vol\u003dvolume[\u0027name\u0027])"},{"line_number":687,"context_line":"                    self.ibm_storage_remote_cli.cmd.vol_unlock("},{"line_number":688,"context_line":"                        vol\u003dvolume[\u0027name\u0027])"},{"line_number":689,"context_line":"                except errors.XCLIError as e:"},{"line_number":690,"context_line":"                    details \u003d self._get_code_and_status_or_message(e)"},{"line_number":691,"context_line":"                    msg \u003d (_(\u0027Failed to unlock volumes %(details)s\u0027),"},{"line_number":692,"context_line":"                           {\u0027details\u0027: details})"},{"line_number":693,"context_line":"                    LOG.error(msg)"},{"line_number":694,"context_line":"                    raise self.meta[\u0027exception\u0027].VolumeBackendAPIException("},{"line_number":695,"context_line":"                        data\u003dmsg)"},{"line_number":696,"context_line":"                updated_volumes.append("},{"line_number":697,"context_line":"                    {\u0027id\u0027: volume[\u0027id\u0027],"},{"line_number":698,"context_line":"                     \u0027replication_status\u0027: fields.ReplicationStatus.DISABLED})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_5ae81b15","line":695,"range":{"start_line":685,"start_character":0,"end_line":695,"end_character":33},"updated":"2017-09-04 03:25:31.000000000","message":"Ditto","commit_id":"cb5ce14453c059dc7efe14630e3ed328f27fb8b7"}]}