)]}'
{"cinder/brick/initiator/connector.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"bdf2a88f784a99a8d07fe5aa99acc9a57eb79f35","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @staticmethod"},{"line_number":89,"context_line":"    def factory(protocol, root_helper, driver\u003dNone,"},{"line_number":90,"context_line":"                execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":91,"context_line":"                device_scan_attempts\u003d3, *args, **kwargs):"},{"line_number":92,"context_line":"        \"\"\"Build a Connector object based upon protocol.\"\"\""},{"line_number":93,"context_line":"        LOG.debug(\"Factory for %s\" % protocol)"},{"line_number":94,"context_line":"        protocol \u003d protocol.upper()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FU0g%3D","line":91,"updated":"2013-09-30 07:28:57.000000000","message":"It\u0027d be better if make \u00273\u0027 a global variable/const in the scope of this file, in case it has be changed to some other value.","commit_id":"c04d565726a11b216dfaa7981b068ee6ada7b088"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"8d4f43fa6c8ddde2326d5bd250a460b1789c6496","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @staticmethod"},{"line_number":89,"context_line":"    def factory(protocol, root_helper, driver\u003dNone,"},{"line_number":90,"context_line":"                execute\u003dputils.execute, use_multipath\u003dFalse,"},{"line_number":91,"context_line":"                device_scan_attempts\u003d3, *args, **kwargs):"},{"line_number":92,"context_line":"        \"\"\"Build a Connector object based upon protocol.\"\"\""},{"line_number":93,"context_line":"        LOG.debug(\"Factory for %s\" % protocol)"},{"line_number":94,"context_line":"        protocol \u003d protocol.upper()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FUgA%3D","line":91,"in_reply_to":"AAAAS3%2F%2FU0g%3D","updated":"2013-09-30 09:31:25.000000000","message":"I\u0027m not so sure that\u0027s a good idea. Unless the number appears in more than one place in the code and all instances of the number have to be maintained at the same value. Otherwise this would just mean that people maintaining the code would have to search a bit more for the value when they were debugging etc.\nI\u0027m assuming that this value does not have to be kept in sync with the default value for \u0027num_volume_device_scan_tries\u0027, which is the only other place that I can see in this file where the constant \u00273\u0027 is used, correct me if I\u0027m wrong","commit_id":"c04d565726a11b216dfaa7981b068ee6ada7b088"}]}