)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"3980aff492298a2157524fde379c916396faba00","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                      \u0027vhd\u0027, \u0027vhdx\u0027, \u0027parallels\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def validate_disk_format(disk_format):"},{"line_number":72,"context_line":"    return disk_format in VALID_DISK_FORMATS"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_664f5d6b","side":"PARENT","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":24},"updated":"2017-07-27 04:52:24.000000000","message":"this method was used in [1]\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_actions.py#L245","commit_id":"5134cf136173b223cfe3c156f0fce40c55ae7ac5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c6d4c1fdb118d32f3d858b8793864c9485cf2865","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                      \u0027vhd\u0027, \u0027vhdx\u0027, \u0027parallels\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def validate_disk_format(disk_format):"},{"line_number":72,"context_line":"    return disk_format in VALID_DISK_FORMATS"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff346bd7_54a2b5fd","side":"PARENT","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":24},"in_reply_to":"ff346bd7_664f5d6b","updated":"2017-07-27 13:29:50.000000000","message":"Oops, thanks.","commit_id":"5134cf136173b223cfe3c156f0fce40c55ae7ac5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a99756b78fcb5040ce041a510d192f35753adb86","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                      \u0027vhd\u0027, \u0027vhdx\u0027, \u0027parallels\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Image formats that should be treated as \u0027raw\u0027 during conversion"},{"line_number":67,"context_line":"QEMU_IMG_RAW_FORMATS \u003d (\u0027iso\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def validate_disk_format(disk_format):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_105e5975","line":67,"updated":"2017-07-28 08:16:50.000000000","message":"-1: This is not a tuple, this is just a string, so `\u0027is\u0027 in QEMU_IMG_RAW_FORMATS` will also evaluate to True.\n\n QEMU_IMG_RAW_FORMATS \u003d (\u0027iso\u0027,)","commit_id":"2f7c17f725b1766a9b43c0c2b8f71e874863bb6a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a99756b78fcb5040ce041a510d192f35753adb86","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    if disk_format \u003d\u003d \u0027vhd\u0027:"},{"line_number":81,"context_line":"        # qemu-img uses the term \u0027vpc\u0027 for \u0027vhd\u0027 images"},{"line_number":82,"context_line":"        return \u0027vpc\u0027"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    return disk_format"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_f08bd5bf","line":82,"updated":"2017-07-28 08:16:50.000000000","message":"nit: I think it would be best to generalize the solution via a mapping:\n\n QEMU_IMG_EQUIVALENCE_MAP \u003d {\n     \u0027iso\u0027: \u0027raw\u0027,\n     \u0027vhd\u0027: \u0027vpc\u0027,\n }\n\n return QEMU_IMG_EQUIVALENCE_MAP.get(disk_format, disk_format)","commit_id":"2f7c17f725b1766a9b43c0c2b8f71e874863bb6a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8a9a53c86abf9ba0893989e7a45a7e436835b955","unresolved":false,"context_lines":[{"line_number":66,"context_line":"QEMU_IMG_FORMAT_MAP \u003d {"},{"line_number":67,"context_line":"    # Convert formats of Glance images to how they are processed with qemu-img."},{"line_number":68,"context_line":"    \u0027iso\u0027: \u0027raw\u0027,"},{"line_number":69,"context_line":"    \u0027vhd\u0027: \u0027vpc\u0027"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_cf6ee4fe","line":69,"range":{"start_line":69,"start_character":15,"end_line":69,"end_character":16},"updated":"2017-07-28 15:12:37.000000000","message":"nit: Add a comma at the end","commit_id":"21d63adf80d12da91fec9349c0fd8dc3b3226670"}],"cinder/tests/unit/test_image_utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8a9a53c86abf9ba0893989e7a45a7e436835b955","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.check_available_space\u0027)"},{"line_number":829,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.convert_image\u0027)"},{"line_number":830,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.volume_utils.copy_volume\u0027)"},{"line_number":831,"context_line":"    @mock.patch("},{"line_number":832,"context_line":"        \u0027cinder.image.image_utils.replace_xenserver_image_with_coalesced_vhd\u0027)"},{"line_number":833,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.is_xenserver_format\u0027,"},{"line_number":834,"context_line":"                return_value\u003dTrue)"},{"line_number":835,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.fetch\u0027)"},{"line_number":836,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.qemu_img_info\u0027)"},{"line_number":837,"context_line":"    @mock.patch(\u0027cinder.image.image_utils.temporary_file\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_322b9783","line":834,"range":{"start_line":831,"start_character":0,"end_line":834,"end_character":34},"updated":"2017-07-28 15:12:37.000000000","message":"nit: We only need the second mock if we return True","commit_id":"21d63adf80d12da91fec9349c0fd8dc3b3226670"}]}