)]}'
{"cinder/brick/initiator/connector.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"6895cb61237aaf005c86ec02652480443d6514d8","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def setUp(self):"},{"line_number":84,"context_line":"        super(InitiatorConnector).setUp()"},{"line_number":85,"context_line":"        lockutils.set_defaults(\u0027/var/lib/cinder/tmp\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def set_driver(self, driver):"},{"line_number":88,"context_line":"        \"\"\"The driver is used to find used LUNs.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2F0Dk%3D","line":85,"updated":"2013-10-09 14:05:35.000000000","message":"There\u0027s a config option for this, why hard code it?","commit_id":"80f0a44840039a4163ead40789874bac9a8b99c3"}],"cinder/openstack/common/db/api.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"6895cb61237aaf005c86ec02652480443d6514d8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.__backend_mapping \u003d backend_mapping"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @lockutils.synchronized(\u0027dbapi_backend\u0027, \u0027cinder-\u0027,"},{"line_number":73,"context_line":"                            lock_path\u003d\u0027/var/lib/cinder/tmp\u0027)"},{"line_number":74,"context_line":"    def __get_backend(self):"},{"line_number":75,"context_line":"        \"\"\"Get the actual backend.  May be a module or an instance of"},{"line_number":76,"context_line":"        a class.  Doesn\u0027t matter to us.  We do this synchronized as it\u0027s"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2F0D8%3D","line":73,"updated":"2013-10-09 14:05:35.000000000","message":"We have a lock path config option, why hard code it here?","commit_id":"80f0a44840039a4163ead40789874bac9a8b99c3"}],"cinder/openstack/common/lockutils.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"3f8d21bf40fd585cae56a7adc7dce6b4bb7303b2","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    :param external: The external keyword argument denotes whether this lock"},{"line_number":148,"context_line":"    should work across multiple processes. This means that if two different"},{"line_number":149,"context_line":"    workers both run a a method decorated with @synchronized(\u0027mylock\u0027,"},{"line_number":150,"context_line":"    external\u003dTrue), only one of them will execute at a time."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    :param lock_path: The lock_path keyword argument is used to specify a"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2F79Y%3D","line":149,"updated":"2013-10-07 19:43:58.000000000","message":"typo \u0027a a\u0027","commit_id":"9b43ceb550f58783522bb6d55a2199bcf4b3ccd3"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f28d62f1b03d9b8700bcd3f4e64b6b19de736910","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027disable_process_locking\u0027, default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Whether to disable inter-process locks\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027lock_path\u0027,"},{"line_number":46,"context_line":"               default\u003dos.environ.get(\"CINDER_LOCK_PATH\"),"},{"line_number":47,"context_line":"               help\u003d(\u0027Directory to use for lock files.\u0027))"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F%2B154%3D","line":46,"updated":"2013-11-19 13:26:56.000000000","message":"Does this still behave in the same way if no env var is set? The \"local_lock_path \u003d tempfile.mkdtemp()\" seems to have vanished, which means previously working configs will now break","commit_id":"9ee2f270e749a75bd62c5a694ce391e48ad7199f"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"b2bd03648799108afa8257a4b344c9f452f0f9c1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027disable_process_locking\u0027, default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Whether to disable inter-process locks\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027lock_path\u0027,"},{"line_number":46,"context_line":"               default\u003dos.environ.get(\"CINDER_LOCK_PATH\"),"},{"line_number":47,"context_line":"               help\u003d(\u0027Directory to use for lock files.\u0027))"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F%2B1ps%3D","line":46,"in_reply_to":"AAAATn%2F%2B154%3D","updated":"2013-11-19 14:34:13.000000000","message":"Hello Duncan. You are right, that \"local_lock_path \u003d tempfile.mkdtemp()\" was vanished. This default value is used just for testing (you can look at tox.ini). Now this  doesn\u0027t work without option lock_path defined in config files. Thus special line was added in devstack (https://review.openstack.org/#/c/50920/), but still not merged in grenade (https://review.openstack.org/#/c/52070/).","commit_id":"9ee2f270e749a75bd62c5a694ce391e48ad7199f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ced5748651ee864e80b524da1e85ca8ba067d69b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027disable_process_locking\u0027, default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Whether to disable inter-process locks\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027lock_path\u0027,"},{"line_number":46,"context_line":"               default\u003dos.environ.get(\"CINDER_LOCK_PATH\"),"},{"line_number":47,"context_line":"               help\u003d(\u0027Directory to use for lock files.\u0027))"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F9uco%3D","line":46,"in_reply_to":"AAAATn%2F%2B1ps%3D","updated":"2013-12-06 17:30:10.000000000","message":"This really needs a real default, not relying on the config file, because that will break people\u0027s changes otherwise. I don\u0027t think this should come from an env variable either.","commit_id":"9ee2f270e749a75bd62c5a694ce391e48ad7199f"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"b2bf321818330b3fb3c599fb64450e57db679a96","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027disable_process_locking\u0027, default\u003dFalse,"},{"line_number":44,"context_line":"                help\u003d\u0027Whether to disable inter-process locks\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027lock_path\u0027,"},{"line_number":46,"context_line":"               default\u003dos.environ.get(\"CINDER_LOCK_PATH\"),"},{"line_number":47,"context_line":"               help\u003d(\u0027Directory to use for lock files.\u0027))"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F9t9c%3D","line":46,"in_reply_to":"AAAATn%2F9uco%3D","updated":"2013-12-06 19:19:12.000000000","message":"@Sean: Thnks for the comment. I hope your patch in oslo will be merged or we get more safety solution. Anyway I wait some fix from oslo for rebasing)","commit_id":"9ee2f270e749a75bd62c5a694ce391e48ad7199f"}],"cinder/volume/drivers/coraid.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"6895cb61237aaf005c86ec02652480443d6514d8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                splitted.scheme)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @lockutils.synchronized(\u0027coraid_rpc\u0027, \u0027cinder-\u0027, False,"},{"line_number":91,"context_line":"                            lock_path\u003dtempfile.mkdtemp())"},{"line_number":92,"context_line":"    def rpc(self, handle, url_params, data, allow_empty_response\u003dFalse):"},{"line_number":93,"context_line":"        return self._rpc(handle, url_params, data, allow_empty_response)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2F0DA%3D","line":91,"updated":"2013-10-09 14:05:35.000000000","message":"Again, this is ignoring the config file option I think?","commit_id":"80f0a44840039a4163ead40789874bac9a8b99c3"}],"etc/cinder/cinder.conf.sample":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"3f8d21bf40fd585cae56a7adc7dce6b4bb7303b2","unresolved":false,"context_lines":[{"line_number":636,"context_line":"#disable_process_locking\u003dfalse"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"# Directory to use for lock files. (string value)"},{"line_number":639,"context_line":"#lock_path\u003d\u003cNone\u003e"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAATH%2F%2F75o%3D","line":639,"updated":"2013-10-07 19:43:58.000000000","message":"Given this design, do we not want to have this default to $state_path/lock or something like that.  I think there used to be some useful default set up like /var/lib/cinder/tmp .  Now not providing a default seems like a step backwards.","commit_id":"9b43ceb550f58783522bb6d55a2199bcf4b3ccd3"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"2cba5d30b7e7502dcc0821eaa0e1b7c3a7e9ae82","unresolved":false,"context_lines":[{"line_number":636,"context_line":"#disable_process_locking\u003dfalse"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"# Directory to use for lock files. (string value)"},{"line_number":639,"context_line":"#lock_path\u003d\u003cNone\u003e"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"AAAATH%2F%2Fu2U%3D","line":639,"updated":"2013-10-10 15:08:32.000000000","message":"This option is None, according other projects with similar oslo updates.","commit_id":"47784db1ff5f424691a1a1e953cee257305425a3"}]}