)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"aa53b32cd6a3f60661d30a913c80242a3bf7071c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tingting Zha \u003czhatt.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-03 14:14:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fujitsu DX Driver: Fix exception in terminate_connection with no connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fujitsu ETERNUS CI \u0027test_force_detach_volume\u0027 test was failed because of"},{"line_number":10,"context_line":"terminate_connection being called without connector."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_c92623cf","line":7,"range":{"start_line":7,"start_character":72,"end_line":7,"end_character":74},"updated":"2017-08-03 08:58:47.000000000","message":"nit, make this line \u003c 52 chars","commit_id":"634354eae6c6007371a7770d470f85429069b376"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"a14c9ae2b1c3572140b505039224cffd44b4ccb4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fujitsu Driver: Fix exception in terminate_connection with no connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fujitsu ETERNUS CI \u0027test_force_detach_volume\u0027 test was failed because of"},{"line_number":10,"context_line":"terminate_connection being called without connector."},{"line_number":11,"context_line":"We\u0027ve added a check on this condition."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df3967d1_74cdb464","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":61},"updated":"2017-08-04 01:41:56.000000000","message":"Is this explanation necessary?  This commit seems to add a validation for a connector in terminate_connection.","commit_id":"487efe6782337c7c05c85a234bc9bb3a1687012b"},{"author":{"_account_id":26559,"name":"ZhaTingting","email":"zhatt.fnst@cn.fujitsu.com","username":"zhatingting"},"change_message_id":"f0cf69cf76bc5d2792998a6ec3fd77ac2e5d3168","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fujitsu Driver: Fix exception in terminate_connection with no connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fujitsu ETERNUS CI \u0027test_force_detach_volume\u0027 test was failed because of"},{"line_number":10,"context_line":"terminate_connection being called without connector."},{"line_number":11,"context_line":"We\u0027ve added a check on this condition."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df3967d1_4a3d60c2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":61},"in_reply_to":"df3967d1_74cdb464","updated":"2017-08-04 07:06:49.000000000","message":"Hi FURUKAWA,\n    Thanks for your review. We have updated the commit message in our new patch.","commit_id":"487efe6782337c7c05c85a234bc9bb3a1687012b"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"a14c9ae2b1c3572140b505039224cffd44b4ccb4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fujitsu Driver: Fix exception in terminate_connection with no connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fujitsu ETERNUS CI \u0027test_force_detach_volume\u0027 test was failed because of"},{"line_number":10,"context_line":"terminate_connection being called without connector."},{"line_number":11,"context_line":"We\u0027ve added a check on this condition."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I244e392ff00ef333a4ea823fb7b27da457c4fcea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df3967d1_b4fd5c6f","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":52},"updated":"2017-08-04 01:41:56.000000000","message":"No need to return(\u0027\\n\u0027) here.\n\n ... without connector. We\u0027ve added ...","commit_id":"487efe6782337c7c05c85a234bc9bb3a1687012b"},{"author":{"_account_id":26559,"name":"ZhaTingting","email":"zhatt.fnst@cn.fujitsu.com","username":"zhatingting"},"change_message_id":"f0cf69cf76bc5d2792998a6ec3fd77ac2e5d3168","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fujitsu Driver: Fix exception in terminate_connection with no connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fujitsu ETERNUS CI \u0027test_force_detach_volume\u0027 test was failed because of"},{"line_number":10,"context_line":"terminate_connection being called without connector."},{"line_number":11,"context_line":"We\u0027ve added a check on this condition."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I244e392ff00ef333a4ea823fb7b27da457c4fcea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df3967d1_0a33d8f7","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":52},"in_reply_to":"df3967d1_b4fd5c6f","updated":"2017-08-04 07:06:49.000000000","message":"ditto","commit_id":"487efe6782337c7c05c85a234bc9bb3a1687012b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bec4b3ac6f4afd384ce0b3c199972c4ebc30fbc7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tingting Zha \u003czhatt.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-04 14:35:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fujitsu Driver: Fix exception in terminate_connection with no connector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Force-detach should be ok when connector is None. When connector"},{"line_number":10,"context_line":"is None, we change the driver to detach the volume from anything"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f436f4f_b1ecf3f3","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":14},"updated":"2017-08-08 10:06:37.000000000","message":"Summary line is a little too long. If you end up doing an update, please at least remove Driver from this.","commit_id":"2d888670817a1761e27d7482267ad1fcab0443a9"}],"cinder/volume/drivers/fujitsu/eternus_dx_fc.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"aa53b32cd6a3f60661d30a913c80242a3bf7071c","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    @fczm_utils.remove_fc_zone"},{"line_number":172,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"},{"line_number":173,"context_line":"        \"\"\"Disallow connection from connector.\"\"\""},{"line_number":174,"context_line":"        wwpns \u003d connector.get(\u0027wwpns\u0027, None) if connector else None"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        LOG.debug(\u0027terminate_connection, volume id: %(vid)s, \u0027"},{"line_number":177,"context_line":"                  \u0027wwpns: %(wwpns)s, enter method.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_0912eb62","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":43},"updated":"2017-08-03 08:58:47.000000000","message":"redundant","commit_id":"634354eae6c6007371a7770d470f85429069b376"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"4f949df98d4065e4b3f5de8568c7285fe3729d79","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                  \u0027wwpns: %(wwpns)s, enter method.\u0027,"},{"line_number":178,"context_line":"                  {\u0027vid\u0027: volume[\u0027id\u0027], \u0027wwpns\u0027: wwpns})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        map_exist \u003d self.common.terminate_connection(volume, connector)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        info \u003d {\u0027driver_volume_type\u0027: \u0027fibre_channel\u0027,"},{"line_number":183,"context_line":"                \u0027data\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_342cccaa","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":71},"updated":"2017-08-04 01:58:37.000000000","message":"I think it raises in [1] If connector is None in case of \u0027fc\u0027 and \u0027iscsi\u0027.  Please consider not to call this method when connector is None.\n\n[1]https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/fujitsu/eternus_dx_common.py#L1768-L1777","commit_id":"487efe6782337c7c05c85a234bc9bb3a1687012b"}],"cinder/volume/drivers/fujitsu/eternus_dx_iscsi.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"aa53b32cd6a3f60661d30a913c80242a3bf7071c","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"},{"line_number":175,"context_line":"        \"\"\"Disallow connection from connector.\"\"\""},{"line_number":176,"context_line":"        initiator \u003d connector.get(\u0027initiator\u0027, None) if connector else None"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        LOG.info(\u0027terminate_connection, volume id: %(vid)s, \u0027"},{"line_number":179,"context_line":"                 \u0027initiator: %(initiator)s, Enter method.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_4401fa04","line":176,"range":{"start_line":176,"start_character":45,"end_line":176,"end_character":51},"updated":"2017-08-03 08:58:47.000000000","message":"redundant","commit_id":"634354eae6c6007371a7770d470f85429069b376"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"4f949df98d4065e4b3f5de8568c7285fe3729d79","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                 \u0027initiator: %(initiator)s, Enter method.\u0027,"},{"line_number":180,"context_line":"                 {\u0027vid\u0027: volume[\u0027id\u0027], \u0027initiator\u0027: initiator})"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        map_exist \u003d self.common.terminate_connection(volume, connector)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        LOG.info(\u0027terminate_connection, unmap: %s, Exit method.\u0027, map_exist)"},{"line_number":185,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_1402e80b","line":182,"range":{"start_line":182,"start_character":8,"end_line":182,"end_character":71},"updated":"2017-08-04 01:58:37.000000000","message":"ditto","commit_id":"487efe6782337c7c05c85a234bc9bb3a1687012b"}]}