)]}'
{"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b9b4ff12f3f0408e6968323aead4f6b203f084fd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    cfg.BoolOpt(\u0027sio_unmap_volume_before_deletion\u0027,"},{"line_number":69,"context_line":"                default\u003dFalse,"},{"line_number":70,"context_line":"                help\u003d\u0027Unmap volume before deletion.\u0027),"},{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027sio_volume_clear_on_delete\u0027,"},{"line_number":72,"context_line":"                default\u003dFalse,"},{"line_number":73,"context_line":"                help\u003d\u0027Clear the volume by writing zeros to the device.\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027sio_volume_clear_mb\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_a7d15532","line":71,"updated":"2017-08-17 21:12:08.000000000","message":"Shouldn\u0027t this be on by default, since there\u0027s a data exposure if it doesn\u0027t happen?","commit_id":"aa641e8013ecaf4af66b1350984e659c9acfab10"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"88215a022dcc1927166d151640f106c47895ec67","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    cfg.BoolOpt(\u0027sio_unmap_volume_before_deletion\u0027,"},{"line_number":69,"context_line":"                default\u003dFalse,"},{"line_number":70,"context_line":"                help\u003d\u0027Unmap volume before deletion.\u0027),"},{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027sio_volume_clear_on_delete\u0027,"},{"line_number":72,"context_line":"                default\u003dFalse,"},{"line_number":73,"context_line":"                help\u003d\u0027Clear the volume by writing zeros to the device.\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027sio_volume_clear_mb\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_47ed098a","line":71,"in_reply_to":"9f436f4f_a7d15532","updated":"2017-08-17 21:28:30.000000000","message":"I want the option off by default so existing driver installations continue to work as they do today.","commit_id":"aa641e8013ecaf4af66b1350984e659c9acfab10"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b9b4ff12f3f0408e6968323aead4f6b203f084fd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027sio_volume_clear_on_delete\u0027,"},{"line_number":72,"context_line":"                default\u003dFalse,"},{"line_number":73,"context_line":"                help\u003d\u0027Clear the volume by writing zeros to the device.\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027sio_volume_clear_mb\u0027,"},{"line_number":75,"context_line":"               default\u003d50,"},{"line_number":76,"context_line":"               help\u003d\u0027Size in MiB to wipe at the start of volumes.\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027sio_storage_pools\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_47e069fb","line":74,"updated":"2017-08-17 21:12:08.000000000","message":"Why is 50MB adequate?  Doesn\u0027t it need to wipe the whole volume?","commit_id":"aa641e8013ecaf4af66b1350984e659c9acfab10"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"519830a809ec48037dd8f5dc11160fc1bed9aed9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027sio_volume_clear_on_delete\u0027,"},{"line_number":72,"context_line":"                default\u003dFalse,"},{"line_number":73,"context_line":"                help\u003d\u0027Clear the volume by writing zeros to the device.\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027sio_volume_clear_mb\u0027,"},{"line_number":75,"context_line":"               default\u003d50,"},{"line_number":76,"context_line":"               help\u003d\u0027Size in MiB to wipe at the start of volumes.\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027sio_storage_pools\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_da33f561","line":74,"in_reply_to":"9f436f4f_27b0c58b","updated":"2017-08-18 13:43:37.000000000","message":"Wiping the filesystem table isn\u0027t enough to prevent data from leaking from a volume owned by one user to a new volume owned by a different user.  It all needs to be wiped or this is a security problem.","commit_id":"aa641e8013ecaf4af66b1350984e659c9acfab10"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"88215a022dcc1927166d151640f106c47895ec67","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027sio_volume_clear_on_delete\u0027,"},{"line_number":72,"context_line":"                default\u003dFalse,"},{"line_number":73,"context_line":"                help\u003d\u0027Clear the volume by writing zeros to the device.\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027sio_volume_clear_mb\u0027,"},{"line_number":75,"context_line":"               default\u003d50,"},{"line_number":76,"context_line":"               help\u003d\u0027Size in MiB to wipe at the start of volumes.\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027sio_storage_pools\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_27b0c58b","line":74,"in_reply_to":"9f436f4f_47e069fb","updated":"2017-08-17 21:28:30.000000000","message":"50MB is enough to wipe the filesystem table on the volume","commit_id":"aa641e8013ecaf4af66b1350984e659c9acfab10"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"00ae2d31c7dee993038ce2be8860b89c17ae34b0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027sio_volume_clear_on_delete\u0027,"},{"line_number":72,"context_line":"                default\u003dFalse,"},{"line_number":73,"context_line":"                help\u003d\u0027Clear the volume by writing zeros to the device.\u0027),"},{"line_number":74,"context_line":"    cfg.IntOpt(\u0027sio_volume_clear_mb\u0027,"},{"line_number":75,"context_line":"               default\u003d50,"},{"line_number":76,"context_line":"               help\u003d\u0027Size in MiB to wipe at the start of volumes.\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027sio_storage_pools\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_d9d53a45","line":74,"in_reply_to":"9f436f4f_da33f561","updated":"2017-08-18 17:30:03.000000000","message":"I don\u0027t disagree just trying for a sane default that takes performance into account as well. I do believe that I can clear volumes on create with minimal impact (as the issue only appears in certain cases).","commit_id":"aa641e8013ecaf4af66b1350984e659c9acfab10"}]}