)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26242,"name":"Viktor Varga","email":"vvarga@inf.u-szeged.hu","username":"vvargaszte"},"change_message_id":"cd98a462251e6a381581f24dea51cdafafe960b7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unused variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of items() use the values() or keys() methods if the key or value is not used."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If95b81ffcde765ca9639fff2dda7054b3da3fd27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_727bd2bd","line":9,"updated":"2017-08-22 06:45:59.000000000","message":"Could you insert a new line here?","commit_id":"6018a1925b353a4e927fb1732e6b57d95e120b3f"}],"cinder/api/contrib/quotas.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        # If the project which is being deleted has allocated part of its"},{"line_number":412,"context_line":"        # quota to its subprojects, then subprojects\u0027 quotas should be"},{"line_number":413,"context_line":"        # deleted first."},{"line_number":414,"context_line":"        for res in project_quotas.keys():"},{"line_number":415,"context_line":"            if \u0027allocated\u0027 in project_quotas[res].keys():"},{"line_number":416,"context_line":"                if project_quotas[res][\u0027allocated\u0027] \u003e 0:"},{"line_number":417,"context_line":"                    msg \u003d _(\"About to delete child projects having \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_89a54ab8","line":414,"updated":"2017-08-22 15:15:09.000000000","message":"It would be more Pythonic to just say\n\n    for res in project_quotas:","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        except exception.AdminRequired:"},{"line_number":427,"context_line":"            raise webob.exc.HTTPForbidden()"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        for res in project_quotas.keys():"},{"line_number":430,"context_line":"            # Update child limit to 0 so the parent hierarchy gets it\u0027s"},{"line_number":431,"context_line":"            # allocated values updated properly"},{"line_number":432,"context_line":"            self._update_nested_quota_allocated("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_49af6294","line":429,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8b6ec0e418eb36d99e9617f77742f53fa8549c65","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        # If the project which is being deleted has allocated part of its"},{"line_number":412,"context_line":"        # quota to its subprojects, then subprojects\u0027 quotas should be"},{"line_number":413,"context_line":"        # deleted first."},{"line_number":414,"context_line":"        for res in project_quotas:"},{"line_number":415,"context_line":"            if \u0027allocated\u0027 in project_quotas[res].keys():"},{"line_number":416,"context_line":"                if project_quotas[res][\u0027allocated\u0027] \u003e 0:"},{"line_number":417,"context_line":"                    msg \u003d _(\"About to delete child projects having \""},{"line_number":418,"context_line":"                            \"non-zero quota. This should not be performed\")"},{"line_number":419,"context_line":"                    raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_227b7d7b","line":416,"range":{"start_line":414,"start_character":0,"end_line":416,"end_character":56},"updated":"2017-09-07 13:03:09.000000000","message":"-1:\n\n for res, value in project_quotas.items():\n     if value.get(\u0027allocated\u0027) \u003e 0:","commit_id":"327546da41b6a5beacacdd05d11de01870e0d369"},{"author":{"_account_id":18529,"name":"Dongdong Pei","email":"peidongdong121@163.com","username":"dongdongpei"},"change_message_id":"75c8d89cc6f0c2b2df7672da0d5c0f4c0f8c89a3","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        # If the project which is being deleted has allocated part of its"},{"line_number":412,"context_line":"        # quota to its subprojects, then subprojects\u0027 quotas should be"},{"line_number":413,"context_line":"        # deleted first."},{"line_number":414,"context_line":"        for res in project_quotas:"},{"line_number":415,"context_line":"            if \u0027allocated\u0027 in project_quotas[res].keys():"},{"line_number":416,"context_line":"                if project_quotas[res][\u0027allocated\u0027] \u003e 0:"},{"line_number":417,"context_line":"                    msg \u003d _(\"About to delete child projects having \""},{"line_number":418,"context_line":"                            \"non-zero quota. This should not be performed\")"},{"line_number":419,"context_line":"                    raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_4378f328","line":416,"range":{"start_line":414,"start_character":0,"end_line":416,"end_character":56},"in_reply_to":"7f287b81_227b7d7b","updated":"2017-09-14 03:46:31.000000000","message":"-1:\n for value in project_quotas.values():\n     if value.get(\u0027allocated\u0027) \u003e 0:","commit_id":"327546da41b6a5beacacdd05d11de01870e0d369"}],"cinder/objects/cgsnapshot.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def _from_db_object(cls, context, cgsnapshot, db_cgsnapshots,"},{"line_number":55,"context_line":"                        expected_attrs\u003dNone):"},{"line_number":56,"context_line":"        expected_attrs \u003d expected_attrs or []"},{"line_number":57,"context_line":"        for name in cgsnapshot.fields.keys():"},{"line_number":58,"context_line":"            if name in cls.OPTIONAL_FIELDS:"},{"line_number":59,"context_line":"                continue"},{"line_number":60,"context_line":"            value \u003d db_cgsnapshots.get(name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_c99a326d","line":57,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/objects/cluster.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def _from_db_object(context, cluster, db_cluster, expected_attrs\u003dNone):"},{"line_number":93,"context_line":"        \"\"\"Fill cluster OVO fields from cluster ORM instance.\"\"\""},{"line_number":94,"context_line":"        expected_attrs \u003d expected_attrs or tuple()"},{"line_number":95,"context_line":"        for name in cluster.fields.keys():"},{"line_number":96,"context_line":"            # The only field that cannot be assigned using setattr is services,"},{"line_number":97,"context_line":"            # because it is an ObjectField.   So we don\u0027t assign the value if"},{"line_number":98,"context_line":"            # it\u0027s a non expected optional field or if it\u0027s services field."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_898e6a2c","line":95,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/objects/consistencygroup.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                        expected_attrs\u003dNone):"},{"line_number":72,"context_line":"        if expected_attrs is None:"},{"line_number":73,"context_line":"            expected_attrs \u003d []"},{"line_number":74,"context_line":"        for name in consistencygroup.fields.keys():"},{"line_number":75,"context_line":"            if name in cls.OPTIONAL_FIELDS:"},{"line_number":76,"context_line":"                continue"},{"line_number":77,"context_line":"            value \u003d db_consistencygroup.get(name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_89930a50","line":74,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/objects/group.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                        expected_attrs\u003dNone):"},{"line_number":74,"context_line":"        if expected_attrs is None:"},{"line_number":75,"context_line":"            expected_attrs \u003d []"},{"line_number":76,"context_line":"        for name in group.fields.keys():"},{"line_number":77,"context_line":"            if name in Group.OPTIONAL_FIELDS:"},{"line_number":78,"context_line":"                continue"},{"line_number":79,"context_line":"            value \u003d db_group.get(name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_e9abae72","line":76,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/objects/group_snapshot.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def _from_db_object(cls, context, group_snapshot, db_group_snapshots,"},{"line_number":53,"context_line":"                        expected_attrs\u003dNone):"},{"line_number":54,"context_line":"        expected_attrs \u003d expected_attrs or []"},{"line_number":55,"context_line":"        for name in group_snapshot.fields.keys():"},{"line_number":56,"context_line":"            if name in cls.OPTIONAL_FIELDS:"},{"line_number":57,"context_line":"                continue"},{"line_number":58,"context_line":"            value \u003d db_group_snapshots.get(name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_e9c4ce42","line":55,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/objects/manageableresources.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def from_primitives(cls, context, dict_resource):"},{"line_number":33,"context_line":"        resource \u003d cls()"},{"line_number":34,"context_line":"        driverkeys \u003d set(dict_resource.keys()) - set(cls.fields.keys())"},{"line_number":35,"context_line":"        for name in cls.fields.keys():"},{"line_number":36,"context_line":"            value \u003d dict_resource.get(name)"},{"line_number":37,"context_line":"            resource[name] \u003d value"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_69e69eeb","line":35,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/volume/drivers/datera/datera_api2.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            initiator \u003d connector[\u0027initiator\u0027]"},{"line_number":257,"context_line":"            current_initiators \u003d self._issue_api_request("},{"line_number":258,"context_line":"                \u0027initiators\u0027, api_version\u003d\u00272\u0027)"},{"line_number":259,"context_line":"            for iqn in current_initiators.keys():"},{"line_number":260,"context_line":"                if initiator \u003d\u003d iqn:"},{"line_number":261,"context_line":"                    found \u003d True"},{"line_number":262,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_29d096f7","line":259,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/volume/drivers/dell_emc/vmax/utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            \u0027RestPassword\u0027: ("},{"line_number":286,"context_line":"                self._process_tag(rest_element, \u0027RestPassword\u0027))}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        for k in connargs.keys():"},{"line_number":289,"context_line":"            if connargs[k] is None:"},{"line_number":290,"context_line":"                exception_message \u003d (_("},{"line_number":291,"context_line":"                    \"RestServerIp, RestServerPort, RestUserName, \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_09cdda5c","line":288,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8b6ec0e418eb36d99e9617f77742f53fa8549c65","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            \u0027RestPassword\u0027: ("},{"line_number":286,"context_line":"                self._process_tag(rest_element, \u0027RestPassword\u0027))}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        for k in connargs:"},{"line_number":289,"context_line":"            if connargs[k] is None:"},{"line_number":290,"context_line":"                exception_message \u003d (_("},{"line_number":291,"context_line":"                    \"RestServerIp, RestServerPort, RestUserName, \""},{"line_number":292,"context_line":"                    \"RestPassword must have valid values.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_6732b712","line":289,"range":{"start_line":288,"start_character":0,"end_line":289,"end_character":35},"updated":"2017-09-07 13:03:09.000000000","message":"-1:\n\n for k, v in connargs.items():\n     if v is None","commit_id":"327546da41b6a5beacacdd05d11de01870e0d369"},{"author":{"_account_id":18529,"name":"Dongdong Pei","email":"peidongdong121@163.com","username":"dongdongpei"},"change_message_id":"75c8d89cc6f0c2b2df7672da0d5c0f4c0f8c89a3","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                self._process_tag(rest_element, \u0027RestPassword\u0027))}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        for k in connargs:"},{"line_number":289,"context_line":"            if connargs[k] is None:"},{"line_number":290,"context_line":"                exception_message \u003d (_("},{"line_number":291,"context_line":"                    \"RestServerIp, RestServerPort, RestUserName, \""},{"line_number":292,"context_line":"                    \"RestPassword must have valid values.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_038b0b1f","line":289,"range":{"start_line":289,"start_character":15,"end_line":289,"end_character":23},"updated":"2017-09-14 03:46:31.000000000","message":"-1:\n for v in connargs.values():\n     if v is None","commit_id":"327546da41b6a5beacacdd05d11de01870e0d369"}],"cinder/volume/drivers/huawei/smartx.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _is_high_priority(self, qos):"},{"line_number":97,"context_line":"        \"\"\"Check QoS priority.\"\"\""},{"line_number":98,"context_line":"        for key in qos.keys():"},{"line_number":99,"context_line":"            if (key.find(\u0027MIN\u0027) \u003d\u003d 0) or (key.find(\u0027LATENCY\u0027) \u003d\u003d 0):"},{"line_number":100,"context_line":"                return True"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_a905a67c","line":98,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/volume/drivers/infortrend/raidcmd_cli/common_cli.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    @log_func"},{"line_number":317,"context_line":"    def _update_map_info_by_slot(self, map_info, slot_key):"},{"line_number":318,"context_line":"        for key in self.map_dict[slot_key].keys():"},{"line_number":319,"context_line":"            self.map_dict[slot_key][key] \u003d list("},{"line_number":320,"context_line":"                range(self.constants[\u0027MAX_LUN_MAP_PER_CHL\u0027]))"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_a92a46e4","line":318,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/volume/drivers/nec/volume_helper.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        # rv expand."},{"line_number":407,"context_line":"        if ld[\u0027RPL Attribute\u0027] \u003d\u003d \u0027MV\u0027:"},{"line_number":408,"context_line":"            # ld expand."},{"line_number":409,"context_line":"            for ldn in rvs.keys():"},{"line_number":410,"context_line":"                self._cli.expand(ldn, new_size)"},{"line_number":411,"context_line":"        elif ld[\u0027RPL Attribute\u0027] !\u003d \u0027IV\u0027:"},{"line_number":412,"context_line":"            msg \u003d (_(\u0027RPL Attribute Error. RPL Attribute \u003d %s.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_892f8af5","line":409,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}],"cinder/volume/drivers/netapp/utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0cef7e04783db3bdb44d064bb8cd0a1dc6f4ccc8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        return"},{"line_number":180,"context_line":"    normalized_qos_keys \u003d [key.lower() for key in QOS_KEYS]"},{"line_number":181,"context_line":"    keylist \u003d []"},{"line_number":182,"context_line":"    for key in qos_spec.keys():"},{"line_number":183,"context_line":"        lower_case_key \u003d key.lower()"},{"line_number":184,"context_line":"        if lower_case_key not in normalized_qos_keys:"},{"line_number":185,"context_line":"            msg \u003d _(\u0027Unrecognized QOS keyword: \"%s\"\u0027) % key"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_293e5629","line":182,"updated":"2017-08-22 15:15:09.000000000","message":"Same","commit_id":"d5d675bc4ab2b6b8fc95d910950115125c90a864"}]}