)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e0f15919e4b6132456a1c9edb0bd1cdf3afac2c1","unresolved":false,"context_lines":[{"line_number":2432,"context_line":"        # the data from the special fixed pool created by"},{"line_number":2433,"context_line":"        # _count_allocated_capacity."},{"line_number":2434,"context_line":"        else:"},{"line_number":2435,"context_line":"            vol_stats.update(next(iter(self.stats[\u0027pools\u0027].values())))"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"    def _append_filter_goodness_functions(self, volume_stats):"},{"line_number":2438,"context_line":"        \"\"\"Returns volume_stats updated as needed.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_b4c48f60","line":2435,"range":{"start_line":2435,"start_character":39,"end_line":2435,"end_character":58},"updated":"2017-08-24 19:53:59.000000000","message":"Looks like this probably needs to be vol_stats[\u0027pools\u0027].values() or just pools.values().","commit_id":"c75687a43db02eddd33c7a97a338450de0862fd7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9c2894884ac7f4c65b84ff22618ca63d16018dbc","unresolved":false,"context_lines":[{"line_number":2432,"context_line":"        # the data from the special fixed pool created by"},{"line_number":2433,"context_line":"        # _count_allocated_capacity."},{"line_number":2434,"context_line":"        else:"},{"line_number":2435,"context_line":"            vol_stats.update(next(iter(self.stats[\u0027pools\u0027].values())))"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"    def _append_filter_goodness_functions(self, volume_stats):"},{"line_number":2438,"context_line":"        \"\"\"Returns volume_stats updated as needed.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_f87c37ec","line":2435,"range":{"start_line":2435,"start_character":39,"end_line":2435,"end_character":58},"in_reply_to":"7f287b81_7865e7e0","updated":"2017-08-25 13:15:56.000000000","message":"Yup, I see why it is now, this issue comes from a poor design of the allocation_capacity_gb calculation feature.  But we also have a good number of implementation errors around it...  I\u0027ll just work around the design issue for now.","commit_id":"c75687a43db02eddd33c7a97a338450de0862fd7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1f8c7abb31d26504d3653b601c0f62f99592ea3e","unresolved":false,"context_lines":[{"line_number":2432,"context_line":"        # the data from the special fixed pool created by"},{"line_number":2433,"context_line":"        # _count_allocated_capacity."},{"line_number":2434,"context_line":"        else:"},{"line_number":2435,"context_line":"            vol_stats.update(next(iter(self.stats[\u0027pools\u0027].values())))"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"    def _append_filter_goodness_functions(self, volume_stats):"},{"line_number":2438,"context_line":"        \"\"\"Returns volume_stats updated as needed.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d8097b2c","line":2435,"range":{"start_line":2435,"start_character":39,"end_line":2435,"end_character":58},"in_reply_to":"7f287b81_b4c48f60","updated":"2017-08-25 12:58:58.000000000","message":"No, that would not get us what we want, since we know there are no pools (this is the else of L2416), so either vol_stats has no \u0027pools\u0027 key or the list is actually empty.\n\nWhat we want is to update the volume stats that we are going to report with the values we have been calculating in the cinder core code.\n\nI tried to explain it on L2431-2433, if the comment is insufficient I can try to improve the comment.","commit_id":"c75687a43db02eddd33c7a97a338450de0862fd7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ef36d631e07d1ca48bb7ba706a59b6fa4a7fd17c","unresolved":false,"context_lines":[{"line_number":2432,"context_line":"        # the data from the special fixed pool created by"},{"line_number":2433,"context_line":"        # _count_allocated_capacity."},{"line_number":2434,"context_line":"        else:"},{"line_number":2435,"context_line":"            vol_stats.update(next(iter(self.stats[\u0027pools\u0027].values())))"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"    def _append_filter_goodness_functions(self, volume_stats):"},{"line_number":2438,"context_line":"        \"\"\"Returns volume_stats updated as needed.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_7865e7e0","line":2435,"range":{"start_line":2435,"start_character":39,"end_line":2435,"end_character":58},"in_reply_to":"7f287b81_d8097b2c","updated":"2017-08-25 13:01:41.000000000","message":"Well, it\u0027s more an issue that it\u0027s blowing up here, so... :)","commit_id":"c75687a43db02eddd33c7a97a338450de0862fd7"}]}