)]}'
{"api-ref/source/v3/attachments.inc":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2a7866bb62e23bd3875d9682be4831ec913eefc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f287b81_10e42f3b","line":275,"updated":"2017-08-29 13:32:25.000000000","message":"Please include a request example to show the POST data.","commit_id":"a25ec9341c3e379affca4ba3eb66dbbcfe7139db"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"b056f0d30a36f61b32593b7c0e8d83e139048501","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f287b81_e08c0a37","line":275,"in_reply_to":"7f287b81_10e42f3b","updated":"2017-08-30 16:59:26.000000000","message":"Done","commit_id":"a25ec9341c3e379affca4ba3eb66dbbcfe7139db"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"35a1bf49e392f54d94fd74e3414758cf7d7df362","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f287b81_cb003804","line":275,"in_reply_to":"7f287b81_10e42f3b","updated":"2017-08-29 13:56:27.000000000","message":"Sean, I don\u0027t think this should add a request example because there is only a param \u0027attachment_id\u0027. HDYT?","commit_id":"a25ec9341c3e379affca4ba3eb66dbbcfe7139db"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"546131a110e5fd545b9035c72b2139970cc68ac3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f287b81_e6b20949","line":275,"in_reply_to":"7f287b81_cb003804","updated":"2017-08-29 14:29:43.000000000","message":"Yes, since the user of the API needs to know that that is the data they need to post for this call. You can\u0027t just post to /action without a payload, and they need to know what that payload is.","commit_id":"a25ec9341c3e379affca4ba3eb66dbbcfe7139db"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"f92dbe76ea79f8f5ef21aeefa46cd27d55747bfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f287b81_1c6b281e","line":275,"in_reply_to":"7f287b81_e6b20949","updated":"2017-08-29 15:47:20.000000000","message":"Hah, this is what I repeated thinking when reading that patch. It seems weird there is no more payload except \u0027action\u0027.\nhttps://review.openstack.org/#/c/493263/2/cinderclient/v3/attachments.py","commit_id":"a25ec9341c3e379affca4ba3eb66dbbcfe7139db"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"920c2c3c0f9071b5e7dc465815e5e290bdb0b8b3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"Request Example"},{"line_number":276,"context_line":"---------------"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":".. literalinclude:: ./samples/attachment-complete.json"},{"line_number":279,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"7f287b81_407bde26","line":278,"updated":"2017-08-30 17:00:18.000000000","message":"Forgot to actually add this file to the patch.","commit_id":"b8c2b31512d312f96d01204c28aa03cfa82db0b2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e6b2aa969b7e0e795c08328d059782b9c8b323a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"   :language: javascript"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Complete attachment"},{"line_number":257,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":".. rest_method::  POST /v3/{project_id}/attachments/{attachment_id}/action"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f2577a7_b976dfa3","line":256,"updated":"2017-09-12 16:43:14.000000000","message":"This should point out which microversion from which this API is available.","commit_id":"89fe1b7d68359b28f83235d4c5a9a435dd4283cc"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"1f73cc73843c0c399315f74c501d530f90560560","unresolved":false,"context_lines":[{"line_number":253,"context_line":"   :language: javascript"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"Complete attachment"},{"line_number":257,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":".. rest_method::  POST /v3/{project_id}/attachments/{attachment_id}/action"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f2577a7_545fc271","line":256,"in_reply_to":"5f2577a7_b976dfa3","updated":"2017-09-12 17:40:53.000000000","message":"yep, this should be added the specified microversion.","commit_id":"89fe1b7d68359b28f83235d4c5a9a435dd4283cc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e6b2aa969b7e0e795c08328d059782b9c8b323a","unresolved":false,"context_lines":[{"line_number":267,"context_line":"Request"},{"line_number":268,"context_line":"-------"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"   - project_id: project_id_path"},{"line_number":273,"context_line":"   - attachment_id: attachment_id_1"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f2577a7_3941cf3a","line":270,"updated":"2017-09-12 16:43:14.000000000","message":"Missing the os-complete body.","commit_id":"89fe1b7d68359b28f83235d4c5a9a435dd4283cc"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"1f73cc73843c0c399315f74c501d530f90560560","unresolved":false,"context_lines":[{"line_number":267,"context_line":"Request"},{"line_number":268,"context_line":"-------"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"   - project_id: project_id_path"},{"line_number":273,"context_line":"   - attachment_id: attachment_id_1"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f2577a7_5486a2dd","line":270,"in_reply_to":"5f2577a7_3941cf3a","updated":"2017-09-12 17:40:53.000000000","message":"not sure what body should be added. it\u0027s just \u0027os-complete\u0027.","commit_id":"89fe1b7d68359b28f83235d4c5a9a435dd4283cc"}],"api-ref/source/v3/samples/attachment-complete.json":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e6b2aa969b7e0e795c08328d059782b9c8b323a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-complete\": {"},{"line_number":3,"context_line":"    }"},{"line_number":4,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"5f2577a7_9950c30c","line":2,"updated":"2017-09-12 16:43:14.000000000","message":"This body isn\u0027t in the request parameters API reference.","commit_id":"89fe1b7d68359b28f83235d4c5a9a435dd4283cc"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"1f73cc73843c0c399315f74c501d530f90560560","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-complete\": {"},{"line_number":3,"context_line":"    }"},{"line_number":4,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"5f2577a7_14d6dac4","line":2,"in_reply_to":"5f2577a7_9950c30c","updated":"2017-09-12 17:40:53.000000000","message":"I don\u0027t think the request should be added with this because it\u0027s just an empty body. HDYT?","commit_id":"89fe1b7d68359b28f83235d4c5a9a435dd4283cc"}]}