)]}'
{"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8e79ddec02268b811c1ff2d4a0a71c6afabf641e","unresolved":false,"context_lines":[{"line_number":3272,"context_line":"                                    \u0027grpSnapshot\u0027: source_id})"},{"line_number":3273,"context_line":"            LOG.exception(exception_message)"},{"line_number":3274,"context_line":"            if array is not None:"},{"line_number":3275,"context_line":"                LOG.info(\"Attempting rollback for the create group from src\")"},{"line_number":3276,"context_line":"                self._rollback_create_group_from_src(array, rollback_dict)"},{"line_number":3277,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":3278,"context_line":"        volumes_model_update \u003d self.utils.update_volume_model_updates("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_bf150a4b","line":3275,"range":{"start_line":3275,"start_character":71,"end_line":3275,"end_character":75},"updated":"2017-08-30 14:22:25.000000000","message":"Should have a \u0027.\u0027 at EOL.","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"f624b226569341fd7b69d313d1b24aebc910086d","unresolved":false,"context_lines":[{"line_number":3272,"context_line":"                                    \u0027grpSnapshot\u0027: source_id})"},{"line_number":3273,"context_line":"            LOG.exception(exception_message)"},{"line_number":3274,"context_line":"            if array is not None:"},{"line_number":3275,"context_line":"                LOG.info(\"Attempting rollback for the create group from src\")"},{"line_number":3276,"context_line":"                self._rollback_create_group_from_src(array, rollback_dict)"},{"line_number":3277,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":3278,"context_line":"        volumes_model_update \u003d self.utils.update_volume_model_updates("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_30c38759","line":3275,"range":{"start_line":3275,"start_character":71,"end_line":3275,"end_character":75},"in_reply_to":"7f287b81_bf150a4b","updated":"2017-08-30 15:27:42.000000000","message":"Done","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8e79ddec02268b811c1ff2d4a0a71c6afabf641e","unresolved":false,"context_lines":[{"line_number":3324,"context_line":"            if rollback_dict.get(\"target_group_name\"):"},{"line_number":3325,"context_line":"                self.rest.delete_storage_group("},{"line_number":3326,"context_line":"                    array, rollback_dict[\u0027target_group_name\u0027])"},{"line_number":3327,"context_line":"            LOG.info(\"Rollback completed for create group from src\")"},{"line_number":3328,"context_line":"        except Exception:"},{"line_number":3329,"context_line":"            LOG.error(\"Rollback failed for the create group from src\")"},{"line_number":3330,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_1a2b0c83","line":3327,"range":{"start_line":3327,"start_character":63,"end_line":3327,"end_character":66},"updated":"2017-08-30 14:22:25.000000000","message":"\u0027.\u0027 here.","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"f624b226569341fd7b69d313d1b24aebc910086d","unresolved":false,"context_lines":[{"line_number":3324,"context_line":"            if rollback_dict.get(\"target_group_name\"):"},{"line_number":3325,"context_line":"                self.rest.delete_storage_group("},{"line_number":3326,"context_line":"                    array, rollback_dict[\u0027target_group_name\u0027])"},{"line_number":3327,"context_line":"            LOG.info(\"Rollback completed for create group from src\")"},{"line_number":3328,"context_line":"        except Exception:"},{"line_number":3329,"context_line":"            LOG.error(\"Rollback failed for the create group from src\")"},{"line_number":3330,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_10a40bb9","line":3327,"range":{"start_line":3327,"start_character":63,"end_line":3327,"end_character":66},"in_reply_to":"7f287b81_1a2b0c83","updated":"2017-08-30 15:27:42.000000000","message":"Done","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8e79ddec02268b811c1ff2d4a0a71c6afabf641e","unresolved":false,"context_lines":[{"line_number":3326,"context_line":"                    array, rollback_dict[\u0027target_group_name\u0027])"},{"line_number":3327,"context_line":"            LOG.info(\"Rollback completed for create group from src\")"},{"line_number":3328,"context_line":"        except Exception:"},{"line_number":3329,"context_line":"            LOG.error(\"Rollback failed for the create group from src\")"},{"line_number":3330,"context_line":""},{"line_number":3331,"context_line":"    def _sync_check_group("},{"line_number":3332,"context_line":"            self, array, volume_group, vol_device_id, extra_specs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_da5584fb","line":3329,"range":{"start_line":3329,"start_character":64,"end_line":3329,"end_character":68},"updated":"2017-08-30 14:22:25.000000000","message":"\u0027.\u0027 here.\n\nAlso, is it possible to report what the exception was so that there is something for the admin to go from if this happens?","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"f624b226569341fd7b69d313d1b24aebc910086d","unresolved":false,"context_lines":[{"line_number":3326,"context_line":"                    array, rollback_dict[\u0027target_group_name\u0027])"},{"line_number":3327,"context_line":"            LOG.info(\"Rollback completed for create group from src\")"},{"line_number":3328,"context_line":"        except Exception:"},{"line_number":3329,"context_line":"            LOG.error(\"Rollback failed for the create group from src\")"},{"line_number":3330,"context_line":""},{"line_number":3331,"context_line":"    def _sync_check_group("},{"line_number":3332,"context_line":"            self, array, volume_group, vol_device_id, extra_specs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_9097db48","line":3329,"range":{"start_line":3329,"start_character":64,"end_line":3329,"end_character":68},"in_reply_to":"7f287b81_da5584fb","updated":"2017-08-30 15:27:42.000000000","message":"Done","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8e79ddec02268b811c1ff2d4a0a71c6afabf641e","unresolved":false,"context_lines":[{"line_number":3350,"context_line":"                target_group_name \u003d self._get_link_details("},{"line_number":3351,"context_line":"                    array, source_group_name, snapshot)"},{"line_number":3352,"context_line":"                if target_group_name is not None:"},{"line_number":3353,"context_line":"                    LOG.info(\"_sync_check_group - Cleaning up replica\")"},{"line_number":3354,"context_line":"                    self.provision.break_and_delete_replica("},{"line_number":3355,"context_line":"                        array, source_group_name, target_group_name,"},{"line_number":3356,"context_line":"                        snapshot, extra_specs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_ba7198aa","line":3353,"range":{"start_line":3353,"start_character":24,"end_line":3353,"end_character":28},"updated":"2017-08-30 14:22:25.000000000","message":"This should be LOG.debug","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"f624b226569341fd7b69d313d1b24aebc910086d","unresolved":false,"context_lines":[{"line_number":3350,"context_line":"                target_group_name \u003d self._get_link_details("},{"line_number":3351,"context_line":"                    array, source_group_name, snapshot)"},{"line_number":3352,"context_line":"                if target_group_name is not None:"},{"line_number":3353,"context_line":"                    LOG.info(\"_sync_check_group - Cleaning up replica\")"},{"line_number":3354,"context_line":"                    self.provision.break_and_delete_replica("},{"line_number":3355,"context_line":"                        array, source_group_name, target_group_name,"},{"line_number":3356,"context_line":"                        snapshot, extra_specs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_509df363","line":3353,"range":{"start_line":3353,"start_character":24,"end_line":3353,"end_character":28},"in_reply_to":"7f287b81_ba7198aa","updated":"2017-08-30 15:27:42.000000000","message":"Done","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8e79ddec02268b811c1ff2d4a0a71c6afabf641e","unresolved":false,"context_lines":[{"line_number":3371,"context_line":"                        snapshots \u003d source_group[\"snapVXSnapshots\"]"},{"line_number":3372,"context_line":"                        for snapshot in snapshots:"},{"line_number":3373,"context_line":"                            if snapshot \u003d\u003d snap_name:"},{"line_number":3374,"context_line":"                                LOG.info("},{"line_number":3375,"context_line":"                                    \"_sync_check_group - Cleaning up replica\")"},{"line_number":3376,"context_line":"                                self.provision.break_and_delete_replica("},{"line_number":3377,"context_line":"                                    array, storage_group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_3a5da814","line":3374,"range":{"start_line":3374,"start_character":37,"end_line":3374,"end_character":40},"updated":"2017-08-30 14:22:25.000000000","message":"LOG.debug","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"f624b226569341fd7b69d313d1b24aebc910086d","unresolved":false,"context_lines":[{"line_number":3371,"context_line":"                        snapshots \u003d source_group[\"snapVXSnapshots\"]"},{"line_number":3372,"context_line":"                        for snapshot in snapshots:"},{"line_number":3373,"context_line":"                            if snapshot \u003d\u003d snap_name:"},{"line_number":3374,"context_line":"                                LOG.info("},{"line_number":3375,"context_line":"                                    \"_sync_check_group - Cleaning up replica\")"},{"line_number":3376,"context_line":"                                self.provision.break_and_delete_replica("},{"line_number":3377,"context_line":"                                    array, storage_group,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_108d2b31","line":3374,"range":{"start_line":3374,"start_character":37,"end_line":3374,"end_character":40},"in_reply_to":"7f287b81_3a5da814","updated":"2017-08-30 15:27:42.000000000","message":"Done","commit_id":"1988565e20c9cbc9d9b0be6af7d1b5e4224d9b7a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"429bd64d77c652cbe760236c905bd817eaef0c1f","unresolved":false,"context_lines":[{"line_number":3326,"context_line":"                    array, rollback_dict[\u0027target_group_name\u0027])"},{"line_number":3327,"context_line":"            LOG.info(\"Rollback completed for create group from src.\")"},{"line_number":3328,"context_line":"        except Exception as e:"},{"line_number":3329,"context_line":"            LOG.error(\"Rollback failed for the create group from src.\""},{"line_number":3330,"context_line":"                      \"Exception received: %(e)s.\", {\u0027e\u0027: e})"},{"line_number":3331,"context_line":""},{"line_number":3332,"context_line":"    def _sync_check_group("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_9058fb87","line":3329,"range":{"start_line":3329,"start_character":68,"end_line":3329,"end_character":70},"updated":"2017-08-30 15:29:57.000000000","message":"Need a space at EOL here.","commit_id":"6397b2ace4d6fa52153642e3db9a59b5e2ace3e5"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"2752da50672f034fbf3f6cad1313fa3375fd6caf","unresolved":false,"context_lines":[{"line_number":3326,"context_line":"                    array, rollback_dict[\u0027target_group_name\u0027])"},{"line_number":3327,"context_line":"            LOG.info(\"Rollback completed for create group from src.\")"},{"line_number":3328,"context_line":"        except Exception as e:"},{"line_number":3329,"context_line":"            LOG.error(\"Rollback failed for the create group from src.\""},{"line_number":3330,"context_line":"                      \"Exception received: %(e)s.\", {\u0027e\u0027: e})"},{"line_number":3331,"context_line":""},{"line_number":3332,"context_line":"    def _sync_check_group("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_3053873b","line":3329,"range":{"start_line":3329,"start_character":68,"end_line":3329,"end_character":70},"in_reply_to":"7f287b81_9058fb87","updated":"2017-08-30 15:35:59.000000000","message":"I will add this, thanks","commit_id":"6397b2ace4d6fa52153642e3db9a59b5e2ace3e5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"429bd64d77c652cbe760236c905bd817eaef0c1f","unresolved":false,"context_lines":[{"line_number":3386,"context_line":"        :param array:"},{"line_number":3387,"context_line":"        :param storagegroup_name:"},{"line_number":3388,"context_line":"        :param snapshot_name:"},{"line_number":3389,"context_line":"        :return: target storage group name or None3328"},{"line_number":3390,"context_line":"        \"\"\""},{"line_number":3391,"context_line":"        link_details \u003d self.rest.get_storage_group_link_details("},{"line_number":3392,"context_line":"            array, storagegroup_name, snapshot_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_5075f3f8","line":3389,"range":{"start_line":3389,"start_character":50,"end_line":3389,"end_character":54},"updated":"2017-08-30 15:29:57.000000000","message":"Please remove this extra text.","commit_id":"6397b2ace4d6fa52153642e3db9a59b5e2ace3e5"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"2752da50672f034fbf3f6cad1313fa3375fd6caf","unresolved":false,"context_lines":[{"line_number":3386,"context_line":"        :param array:"},{"line_number":3387,"context_line":"        :param storagegroup_name:"},{"line_number":3388,"context_line":"        :param snapshot_name:"},{"line_number":3389,"context_line":"        :return: target storage group name or None3328"},{"line_number":3390,"context_line":"        \"\"\""},{"line_number":3391,"context_line":"        link_details \u003d self.rest.get_storage_group_link_details("},{"line_number":3392,"context_line":"            array, storagegroup_name, snapshot_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_90623b09","line":3389,"range":{"start_line":3389,"start_character":50,"end_line":3389,"end_character":54},"in_reply_to":"7f287b81_5075f3f8","updated":"2017-08-30 15:35:59.000000000","message":"Whoops! Thanks, will do!","commit_id":"6397b2ace4d6fa52153642e3db9a59b5e2ace3e5"}]}