)]}'
{"cinder/volume/drivers/huawei/huawei_driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"00686bd858255561e0b6c034349b8dc3b8e31ae2","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                smart_qos.remove(qos_id, lun_id)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        metadata \u003d huawei_utils.get_lun_metadata(volume)"},{"line_number":474,"context_line":"        if metadata.get(\u0027hypermetro_id\u0027):"},{"line_number":475,"context_line":"            metro \u003d hypermetro.HuaweiHyperMetro(self.client,"},{"line_number":476,"context_line":"                                                self.rmt_client,"},{"line_number":477,"context_line":"                                                self.configuration)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_1eaee4e6","line":474,"updated":"2017-09-05 14:19:06.000000000","message":"Isn\u0027t this the same?  Why change this check?","commit_id":"e0d3c471f0c43d7973d39ee4b3df0955ef0a0eb5"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7d3a876408e1840d7a5247c86364628ed16c4cdd","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                smart_qos.remove(qos_id, lun_id)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        metadata \u003d huawei_utils.get_lun_metadata(volume)"},{"line_number":474,"context_line":"        if metadata.get(\u0027hypermetro_id\u0027):"},{"line_number":475,"context_line":"            metro \u003d hypermetro.HuaweiHyperMetro(self.client,"},{"line_number":476,"context_line":"                                                self.rmt_client,"},{"line_number":477,"context_line":"                                                self.configuration)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_f47d696e","line":474,"in_reply_to":"7f287b81_1eaee4e6","updated":"2017-09-06 01:05:17.000000000","message":"Thanks Eric, it\u0027s not the same, because at the issue situation, hypermetro_id is in metadata, but it\u0027s value is None, so change to this form will check more precisely.","commit_id":"e0d3c471f0c43d7973d39ee4b3df0955ef0a0eb5"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"a9241c2a19bf780e75ff1d2418f4f9c105005669","unresolved":false,"context_lines":[{"line_number":2172,"context_line":""},{"line_number":2173,"context_line":"        metadata \u003d huawei_utils.get_lun_metadata(volume)"},{"line_number":2174,"context_line":"        LOG.info(\"initialize_connection, metadata is: %s.\", metadata)"},{"line_number":2175,"context_line":"        hypermetro_lun \u003d (\u0027hypermetro_id\u0027 in metadata and"},{"line_number":2176,"context_line":"                          metadata[\u0027hypermetro_id\u0027])"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"        map_info \u003d self.client.do_mapping(lun_id, hostgroup_id,"},{"line_number":2179,"context_line":"                                          host_id, portg_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_97a5204a","line":2176,"range":{"start_line":2175,"start_character":7,"end_line":2176,"end_character":52},"updated":"2017-09-05 09:39:42.000000000","message":"Does this below work for your case?\n```\nhypermetro_lun \u003d metadata(\u0027hypermetro_id\u0027) is not None\n```","commit_id":"e0d3c471f0c43d7973d39ee4b3df0955ef0a0eb5"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"41b17a3c821f0e93e153cef1c534ac8a38f38eac","unresolved":false,"context_lines":[{"line_number":2172,"context_line":""},{"line_number":2173,"context_line":"        metadata \u003d huawei_utils.get_lun_metadata(volume)"},{"line_number":2174,"context_line":"        LOG.info(\"initialize_connection, metadata is: %s.\", metadata)"},{"line_number":2175,"context_line":"        hypermetro_lun \u003d (\u0027hypermetro_id\u0027 in metadata and"},{"line_number":2176,"context_line":"                          metadata[\u0027hypermetro_id\u0027])"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"        map_info \u003d self.client.do_mapping(lun_id, hostgroup_id,"},{"line_number":2179,"context_line":"                                          host_id, portg_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_da63cfdc","line":2176,"range":{"start_line":2175,"start_character":7,"end_line":2176,"end_character":52},"in_reply_to":"7f287b81_97a5204a","updated":"2017-09-05 09:47:06.000000000","message":"Thanks TommyLike,\nIt doesn\u0027t have much difference, does it?\nIs there any other reason your way better?","commit_id":"e0d3c471f0c43d7973d39ee4b3df0955ef0a0eb5"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1d4e4506572191547d6f0ea1db44d9a8ac05b55a","unresolved":false,"context_lines":[{"line_number":2172,"context_line":""},{"line_number":2173,"context_line":"        metadata \u003d huawei_utils.get_lun_metadata(volume)"},{"line_number":2174,"context_line":"        LOG.info(\"initialize_connection, metadata is: %s.\", metadata)"},{"line_number":2175,"context_line":"        hypermetro_lun \u003d (\u0027hypermetro_id\u0027 in metadata and"},{"line_number":2176,"context_line":"                          metadata[\u0027hypermetro_id\u0027])"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"        map_info \u003d self.client.do_mapping(lun_id, hostgroup_id,"},{"line_number":2179,"context_line":"                                          host_id, portg_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_e83da12c","line":2176,"range":{"start_line":2175,"start_character":7,"end_line":2176,"end_character":52},"in_reply_to":"7f287b81_da63cfdc","updated":"2017-09-05 11:32:48.000000000","message":"Sorry,it\u0027s metadata.get(\u0027hypermetro_id\u0027) not metada(\u0027hypermetro_id\u0027) and the reason I commented here is it\u0027s more clean and only needs one comparsion.","commit_id":"e0d3c471f0c43d7973d39ee4b3df0955ef0a0eb5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"00686bd858255561e0b6c034349b8dc3b8e31ae2","unresolved":false,"context_lines":[{"line_number":2172,"context_line":""},{"line_number":2173,"context_line":"        metadata \u003d huawei_utils.get_lun_metadata(volume)"},{"line_number":2174,"context_line":"        LOG.info(\"initialize_connection, metadata is: %s.\", metadata)"},{"line_number":2175,"context_line":"        hypermetro_lun \u003d (\u0027hypermetro_id\u0027 in metadata and"},{"line_number":2176,"context_line":"                          metadata[\u0027hypermetro_id\u0027])"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"        map_info \u003d self.client.do_mapping(lun_id, hostgroup_id,"},{"line_number":2179,"context_line":"                                          host_id, portg_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_fe6318dc","line":2176,"range":{"start_line":2175,"start_character":7,"end_line":2176,"end_character":52},"in_reply_to":"7f287b81_e83da12c","updated":"2017-09-05 14:19:06.000000000","message":"I agree, this should use .get().","commit_id":"e0d3c471f0c43d7973d39ee4b3df0955ef0a0eb5"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"7d3a876408e1840d7a5247c86364628ed16c4cdd","unresolved":false,"context_lines":[{"line_number":2172,"context_line":""},{"line_number":2173,"context_line":"        metadata \u003d huawei_utils.get_lun_metadata(volume)"},{"line_number":2174,"context_line":"        LOG.info(\"initialize_connection, metadata is: %s.\", metadata)"},{"line_number":2175,"context_line":"        hypermetro_lun \u003d (\u0027hypermetro_id\u0027 in metadata and"},{"line_number":2176,"context_line":"                          metadata[\u0027hypermetro_id\u0027])"},{"line_number":2177,"context_line":""},{"line_number":2178,"context_line":"        map_info \u003d self.client.do_mapping(lun_id, hostgroup_id,"},{"line_number":2179,"context_line":"                                          host_id, portg_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d4802d49","line":2176,"range":{"start_line":2175,"start_character":7,"end_line":2176,"end_character":52},"in_reply_to":"7f287b81_fe6318dc","updated":"2017-09-06 01:05:17.000000000","message":"Done","commit_id":"e0d3c471f0c43d7973d39ee4b3df0955ef0a0eb5"}]}