)]}'
{"cinder/volume/drivers/huawei/huawei_driver.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b379759bdbeb23777b97bb5fa749428f31cf7f08","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            LOG.error(\u0027Unable to rename lun %s on array.\u0027, new_lun_id)"},{"line_number":599,"context_line":"            return {"},{"line_number":600,"context_line":"                \u0027_name_id\u0027: new_volume.name_id,"},{"line_number":601,"context_line":"                \u0027provider_location\u0027: huawei_utils.to_string(**new_metadata),"},{"line_number":602,"context_line":"            }"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        LOG.debug(\"Renamed lun %(id)s to %(name)s successfully.\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_29a378b4","line":601,"range":{"start_line":601,"start_character":37,"end_line":601,"end_character":75},"updated":"2017-09-14 17:26:41.000000000","message":"don\u0027t need to calculate the string value of the provider_location here and below twice.","commit_id":"9a1c2018bfd6c0e32519ad9c8f9f7cbe9cdde300"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"9e60262ef71746de4fc6e63fa4d033fe744ffdaa","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            LOG.error(\u0027Unable to rename lun %s on array.\u0027, new_lun_id)"},{"line_number":599,"context_line":"            return {"},{"line_number":600,"context_line":"                \u0027_name_id\u0027: new_volume.name_id,"},{"line_number":601,"context_line":"                \u0027provider_location\u0027: huawei_utils.to_string(**new_metadata),"},{"line_number":602,"context_line":"            }"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        LOG.debug(\"Renamed lun %(id)s to %(name)s successfully.\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_370ce592","line":601,"range":{"start_line":601,"start_character":37,"end_line":601,"end_character":75},"in_reply_to":"5f2577a7_29a378b4","updated":"2017-09-15 06:23:33.000000000","message":"Done. Thanks.","commit_id":"9a1c2018bfd6c0e32519ad9c8f9f7cbe9cdde300"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4dc93ffdc0f2f52a1d7e37d2a0028c77b22d877b","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":601,"context_line":"            LOG.error(\u0027Unable to rename lun %s on array.\u0027, new_lun_id)"},{"line_number":602,"context_line":"            model_update[\u0027_name_id\u0027] \u003d new_volume.name_id"},{"line_number":603,"context_line":"        else:"},{"line_number":604,"context_line":"            LOG.debug(\"Renamed lun %(id)s to %(name)s successfully.\","},{"line_number":605,"context_line":"                      {\u0027id\u0027: new_lun_id,"},{"line_number":606,"context_line":"                       \u0027name\u0027: orig_lun_name})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_5e2f6187","line":603,"range":{"start_line":603,"start_character":7,"end_line":603,"end_character":13},"updated":"2017-09-18 12:54:03.000000000","message":"I don\u0027t understand the need for the else here.  If you hit the exception the _name_id will be set to new_volume.name_id .  Otherwise it will run this code.  If you want to make it clear that this is only run in the non-exception case I would add a comment instead.","commit_id":"011daa9b463043a15f9e97986ecce6233ac72de5"}]}