)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9b6c3b731e092ff1e92b4a752ebed2de8e3f7e7c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMAX driver - Volume identifier issues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a VMAX volume through cinder, a \u0027volume_identifier\u0027 is set on"},{"line_number":10,"context_line":"the device on the backend. This takes the form \u0027OS-\u003ccinderUUID\u003e. There are a"},{"line_number":11,"context_line":"couple of issues with how this is currently being done:"},{"line_number":12,"context_line":"1. When the VMAX driver retrieves the volume using the \u0027device_id\u0027 value"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f5c4f37_9f669951","line":9,"updated":"2017-09-21 11:30:37.000000000","message":"Line length is too long. Should be less than 73 chars","commit_id":"6aff4042664001e862a1986e7f16dedbcf1bd905"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"b059026f205595ffd8c4923b0089b1d00e6f3e7c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMAX driver - Volume identifier issues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a VMAX volume through cinder, a \u0027volume_identifier\u0027 is set on"},{"line_number":10,"context_line":"the device on the backend. This takes the form \u0027OS-\u003ccinderUUID\u003e. There are a"},{"line_number":11,"context_line":"couple of issues with how this is currently being done:"},{"line_number":12,"context_line":"1. When the VMAX driver retrieves the volume using the \u0027device_id\u0027 value"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f5c4f37_028fedcc","line":9,"in_reply_to":"9f5c4f37_9f669951","updated":"2017-09-21 14:09:33.000000000","message":"Thanks, I\u0027ll fix this","commit_id":"6aff4042664001e862a1986e7f16dedbcf1bd905"}],"cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b263727b7857382dd6c321e1c46a79419bfd2a60","unresolved":false,"context_lines":[{"line_number":1776,"context_line":""},{"line_number":1777,"context_line":"    def test_delete_volume(self):"},{"line_number":1778,"context_line":"        device_id \u003d self.data.device_id"},{"line_number":1779,"context_line":"        with mock.patch.object(self.rest, \u0027delete_resource\u0027):"},{"line_number":1780,"context_line":"            with mock.patch.object("},{"line_number":1781,"context_line":"                    self.rest, \u0027_modify_volume\u0027,"},{"line_number":1782,"context_line":"                    side_effect\u003d[None, None, None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f5c4f37_e2317eee","line":1779,"updated":"2017-09-21 11:37:53.000000000","message":"Nit. You can also eliminate nested mocks. see test_delete_group_success for an example\nhttps://review.openstack.org/#/c/505559/3/cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py@4296","commit_id":"6aff4042664001e862a1986e7f16dedbcf1bd905"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"b059026f205595ffd8c4923b0089b1d00e6f3e7c","unresolved":false,"context_lines":[{"line_number":1776,"context_line":""},{"line_number":1777,"context_line":"    def test_delete_volume(self):"},{"line_number":1778,"context_line":"        device_id \u003d self.data.device_id"},{"line_number":1779,"context_line":"        with mock.patch.object(self.rest, \u0027delete_resource\u0027):"},{"line_number":1780,"context_line":"            with mock.patch.object("},{"line_number":1781,"context_line":"                    self.rest, \u0027_modify_volume\u0027,"},{"line_number":1782,"context_line":"                    side_effect\u003d[None, None, None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f5c4f37_c2c2f5e9","line":1779,"in_reply_to":"9f5c4f37_e2317eee","updated":"2017-09-21 14:09:33.000000000","message":"Sure, will do.","commit_id":"6aff4042664001e862a1986e7f16dedbcf1bd905"}],"cinder/volume/drivers/dell_emc/vmax/rest.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"64d4c14e64d191e8cc5533d05ddf65dd1da8c448","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        vol_details \u003d self.get_volume(array, device_id)"},{"line_number":710,"context_line":"        if vol_details:"},{"line_number":711,"context_line":"            vol_identifier \u003d vol_details.get(\u0027volume_identifier\u0027, None)"},{"line_number":712,"context_line":"            LOG.info(\u0027Element name \u003d %(en)s, Vol identifier \u003d %(vi)s, \u0027"},{"line_number":713,"context_line":"                     \u0027Device id \u003d %(di)s, vol details \u003d %(vd)s\u0027,"},{"line_number":714,"context_line":"                     {\u0027en\u0027: element_name, \u0027vi\u0027: vol_identifier,"},{"line_number":715,"context_line":"                      \u0027di\u0027: device_id, \u0027vd\u0027: vol_details})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_61946745","line":712,"range":{"start_line":712,"start_character":12,"end_line":712,"end_character":20},"updated":"2017-09-20 14:53:08.000000000","message":"Info seems a little verbose for this message.  Would probably do debug instead, but don\u0027t know that it is work pushing up another patch for.","commit_id":"0cc67b570408ce8f315fbb20504e98ccb6490ff7"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"3ef09378093e4915e1acc9c6df9f0964d6855b75","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        vol_details \u003d self.get_volume(array, device_id)"},{"line_number":710,"context_line":"        if vol_details:"},{"line_number":711,"context_line":"            vol_identifier \u003d vol_details.get(\u0027volume_identifier\u0027, None)"},{"line_number":712,"context_line":"            LOG.info(\u0027Element name \u003d %(en)s, Vol identifier \u003d %(vi)s, \u0027"},{"line_number":713,"context_line":"                     \u0027Device id \u003d %(di)s, vol details \u003d %(vd)s\u0027,"},{"line_number":714,"context_line":"                     {\u0027en\u0027: element_name, \u0027vi\u0027: vol_identifier,"},{"line_number":715,"context_line":"                      \u0027di\u0027: device_id, \u0027vd\u0027: vol_details})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_3eed5def","line":712,"range":{"start_line":712,"start_character":12,"end_line":712,"end_character":20},"in_reply_to":"bf57530f_61946745","updated":"2017-09-20 20:21:11.000000000","message":"Thanks Jay - this was an oversight, I intended it to be a debug. I will change it, I agree that it is information overload for an info message. Thanks for the feedback!","commit_id":"0cc67b570408ce8f315fbb20504e98ccb6490ff7"}]}