)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fa83b6af9850ce773fcf6e872311a7a592935ac9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Unana Okpoyo \u003cunana.okpoyo@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-02 11:33:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This commit deprecates the use of xml file for backend configuration for the vmax. The configuration should be included in the cinder.conf file for security and uniformity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic7fc1827608190ec47db30b1265bebde616b616b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f515b1d_09d98620","line":7,"updated":"2017-10-02 10:40:26.000000000","message":"Please fix your commit message:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"bb56e6d190c664c40fd5c17be132bee284ddda6b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"47b91b1626bfe70953cad6aaaf478a8ab2d3d883","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The use of xml files for vmax backend configuration is deprecated."},{"line_number":10,"context_line":"Configuration parameters should be set in cinder.conf for security and"},{"line_number":11,"context_line":"uniformity. The xml file can still be used but will not be supported after"},{"line_number":12,"context_line":"the queens release."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic7fc1827608190ec47db30b1265bebde616b616b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f515b1d_abb81410","line":11,"updated":"2017-10-03 08:42:26.000000000","message":"Keep comment lines under 73 chars.  Thanks","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"}],"cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"47b91b1626bfe70953cad6aaaf478a8ab2d3d883","unresolved":false,"context_lines":[{"line_number":4515,"context_line":"                source_group, source_vols))"},{"line_number":4516,"context_line":"        self.assertEqual(ref_model_update, model_update)"},{"line_number":4517,"context_line":""},{"line_number":4518,"context_line":"    def test_get_attributes_from_local_config(self):"},{"line_number":4519,"context_line":"        kwargs_expected \u003d ("},{"line_number":4520,"context_line":"            {\u0027RestServerIp\u0027: \u00271.1.1.1\u0027,"},{"line_number":4521,"context_line":"             \u0027RestServerPort\u0027: 8443,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_eb704c74","line":4518,"updated":"2017-10-03 08:42:26.000000000","message":"This should be cinder instead of local","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":4515,"context_line":"                source_group, source_vols))"},{"line_number":4516,"context_line":"        self.assertEqual(ref_model_update, model_update)"},{"line_number":4517,"context_line":""},{"line_number":4518,"context_line":"    def test_get_attributes_from_local_config(self):"},{"line_number":4519,"context_line":"        kwargs_expected \u003d ("},{"line_number":4520,"context_line":"            {\u0027RestServerIp\u0027: \u00271.1.1.1\u0027,"},{"line_number":4521,"context_line":"             \u0027RestServerPort\u0027: 8443,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ab701441","line":4518,"in_reply_to":"7f515b1d_eb704c74","updated":"2017-10-03 08:51:31.000000000","message":"Will change to cinder.conf.....thanks","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9721b8c834263daf3c788292795ee34155fd5b43","unresolved":false,"context_lines":[{"line_number":851,"context_line":"        if replication_device:"},{"line_number":852,"context_line":"            self.replication_device \u003d [replication_device]"},{"line_number":853,"context_line":"        for key, value in kwargs.items():"},{"line_number":854,"context_line":"            if key \u003d\u003d \u0027san_login\u0027:"},{"line_number":855,"context_line":"                self.san_login \u003d value"},{"line_number":856,"context_line":"            elif key \u003d\u003d \u0027san_password\u0027:"},{"line_number":857,"context_line":"                self.san_password \u003d value"},{"line_number":858,"context_line":"            elif key \u003d\u003d \u0027san_ip\u0027:"},{"line_number":859,"context_line":"                self.san_ip \u003d value"},{"line_number":860,"context_line":"            elif key \u003d\u003d \u0027san_rest_port\u0027:"},{"line_number":861,"context_line":"                self.san_rest_port \u003d value"},{"line_number":862,"context_line":"            elif key \u003d\u003d \u0027vmax_srp\u0027:"},{"line_number":863,"context_line":"                self.vmax_srp \u003d value"},{"line_number":864,"context_line":"            elif key \u003d\u003d \u0027vmax_service_level\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_af8f5521","line":861,"range":{"start_line":854,"start_character":0,"end_line":861,"end_character":42},"updated":"2017-10-09 17:23:18.000000000","message":"Wasn\u0027t wanting you to just change the names.  Was hoping you could inherit from the san driver so we don\u0027t have duplicate configuration options.\n\nHere is an example of how the storwizeSVC driver does it:  https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py#L2151","commit_id":"3c00f3db1324dcac829496c180462f8faaef34c9"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"dadfe5948f980ea13e18984836ba834178a02a9e","unresolved":false,"context_lines":[{"line_number":851,"context_line":"        if replication_device:"},{"line_number":852,"context_line":"            self.replication_device \u003d [replication_device]"},{"line_number":853,"context_line":"        for key, value in kwargs.items():"},{"line_number":854,"context_line":"            if key \u003d\u003d \u0027san_login\u0027:"},{"line_number":855,"context_line":"                self.san_login \u003d value"},{"line_number":856,"context_line":"            elif key \u003d\u003d \u0027san_password\u0027:"},{"line_number":857,"context_line":"                self.san_password \u003d value"},{"line_number":858,"context_line":"            elif key \u003d\u003d \u0027san_ip\u0027:"},{"line_number":859,"context_line":"                self.san_ip \u003d value"},{"line_number":860,"context_line":"            elif key \u003d\u003d \u0027san_rest_port\u0027:"},{"line_number":861,"context_line":"                self.san_rest_port \u003d value"},{"line_number":862,"context_line":"            elif key \u003d\u003d \u0027vmax_srp\u0027:"},{"line_number":863,"context_line":"                self.vmax_srp \u003d value"},{"line_number":864,"context_line":"            elif key \u003d\u003d \u0027vmax_service_level\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f4e5783_d12d37a9","line":861,"range":{"start_line":854,"start_character":0,"end_line":861,"end_character":42},"in_reply_to":"7f515b1d_af8f5521","updated":"2017-10-10 08:22:14.000000000","message":"Hi Jay, I did inherit from the san driver. If you take a look at the iscsi.py and fc.py, it reflects the change. Here I mocked the configuration options for our unit tests. Please review......thanks","commit_id":"3c00f3db1324dcac829496c180462f8faaef34c9"}],"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                default\u003dFalse,"},{"line_number":72,"context_line":"                help\u003d\u0027Use this value to enable \u0027"},{"line_number":73,"context_line":"                     \u0027the initiator_check.\u0027),"},{"line_number":74,"context_line":"    cfg.StrOpt(utils.RestUserName,"},{"line_number":75,"context_line":"               default\u003dNone,"},{"line_number":76,"context_line":"               help\u003d\u0027Rest server user name\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.RestPassword,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ae7ef0e0","line":74,"updated":"2017-10-02 17:30:11.000000000","message":"This should have a name like \"vmax_user_name\" since it\u0027s a Cinder conf option that is only applicable to this driver.\n\nOr just use san.san_login.","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                default\u003dFalse,"},{"line_number":72,"context_line":"                help\u003d\u0027Use this value to enable \u0027"},{"line_number":73,"context_line":"                     \u0027the initiator_check.\u0027),"},{"line_number":74,"context_line":"    cfg.StrOpt(utils.RestUserName,"},{"line_number":75,"context_line":"               default\u003dNone,"},{"line_number":76,"context_line":"               help\u003d\u0027Rest server user name\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.RestPassword,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_4b26406a","line":74,"in_reply_to":"7f515b1d_ae7ef0e0","updated":"2017-10-03 08:51:31.000000000","message":"Thanks Eric. Will use the prefix vmax so this conf option will be vmax_user_name","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"51f564fade0942ffe337e6c4c29799cf96a350f5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                     \u0027the initiator_check.\u0027),"},{"line_number":74,"context_line":"    cfg.StrOpt(utils.RestUserName,"},{"line_number":75,"context_line":"               default\u003dNone,"},{"line_number":76,"context_line":"               help\u003d\u0027Rest server user name\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.RestPassword,"},{"line_number":78,"context_line":"               secret\u003dTrue,"},{"line_number":79,"context_line":"               help\u003d\u0027Rest server password of administrator for logging in \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_0e53c4e3","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":25},"updated":"2017-10-02 17:11:51.000000000","message":"Suggest REST","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                     \u0027the initiator_check.\u0027),"},{"line_number":74,"context_line":"    cfg.StrOpt(utils.RestUserName,"},{"line_number":75,"context_line":"               default\u003dNone,"},{"line_number":76,"context_line":"               help\u003d\u0027Rest server user name\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.RestPassword,"},{"line_number":78,"context_line":"               secret\u003dTrue,"},{"line_number":79,"context_line":"               help\u003d\u0027Rest server password of administrator for logging in \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ab1494e9","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":25},"in_reply_to":"7f515b1d_0e53c4e3","updated":"2017-10-03 08:51:31.000000000","message":"will do","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    cfg.StrOpt(utils.RestUserName,"},{"line_number":75,"context_line":"               default\u003dNone,"},{"line_number":76,"context_line":"               help\u003d\u0027Rest server user name\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.RestPassword,"},{"line_number":78,"context_line":"               secret\u003dTrue,"},{"line_number":79,"context_line":"               help\u003d\u0027Rest server password of administrator for logging in \u0027"},{"line_number":80,"context_line":"                    \u0027vmax storage.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_6e8478d3","line":77,"updated":"2017-10-02 17:30:11.000000000","message":"Same, or san.san_password.","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    cfg.StrOpt(utils.RestUserName,"},{"line_number":75,"context_line":"               default\u003dNone,"},{"line_number":76,"context_line":"               help\u003d\u0027Rest server user name\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.RestPassword,"},{"line_number":78,"context_line":"               secret\u003dTrue,"},{"line_number":79,"context_line":"               help\u003d\u0027Rest server password of administrator for logging in \u0027"},{"line_number":80,"context_line":"                    \u0027vmax storage.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_4bdbe04d","line":77,"in_reply_to":"7f515b1d_6e8478d3","updated":"2017-10-03 08:51:31.000000000","message":"will change to vmax_password","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"51f564fade0942ffe337e6c4c29799cf96a350f5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"               help\u003d\u0027Rest server user name\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.RestPassword,"},{"line_number":78,"context_line":"               secret\u003dTrue,"},{"line_number":79,"context_line":"               help\u003d\u0027Rest server password of administrator for logging in \u0027"},{"line_number":80,"context_line":"                    \u0027vmax storage.\u0027),"},{"line_number":81,"context_line":"    cfg.HostAddressOpt(utils.RestServerIP,"},{"line_number":82,"context_line":"                       default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ee4d083b","line":79,"range":{"start_line":79,"start_character":21,"end_line":79,"end_character":25},"updated":"2017-10-02 17:11:51.000000000","message":"Same here.","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":76,"context_line":"               help\u003d\u0027Rest server user name\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.RestPassword,"},{"line_number":78,"context_line":"               secret\u003dTrue,"},{"line_number":79,"context_line":"               help\u003d\u0027Rest server password of administrator for logging in \u0027"},{"line_number":80,"context_line":"                    \u0027vmax storage.\u0027),"},{"line_number":81,"context_line":"    cfg.HostAddressOpt(utils.RestServerIP,"},{"line_number":82,"context_line":"                       default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_8bbe78d2","line":79,"range":{"start_line":79,"start_character":21,"end_line":79,"end_character":25},"in_reply_to":"7f515b1d_ee4d083b","updated":"2017-10-03 08:51:31.000000000","message":"will do","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               secret\u003dTrue,"},{"line_number":79,"context_line":"               help\u003d\u0027Rest server password of administrator for logging in \u0027"},{"line_number":80,"context_line":"                    \u0027vmax storage.\u0027),"},{"line_number":81,"context_line":"    cfg.HostAddressOpt(utils.RestServerIP,"},{"line_number":82,"context_line":"                       default\u003dNone,"},{"line_number":83,"context_line":"                       help\u003d\u0027Rest server end point\u0027),"},{"line_number":84,"context_line":"    cfg.PortOpt(utils.RestServerPort,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_2e6a0019","line":81,"updated":"2017-10-02 17:30:11.000000000","message":"Same, or san.san_ip.","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"51f564fade0942ffe337e6c4c29799cf96a350f5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    \u0027vmax storage.\u0027),"},{"line_number":81,"context_line":"    cfg.HostAddressOpt(utils.RestServerIP,"},{"line_number":82,"context_line":"                       default\u003dNone,"},{"line_number":83,"context_line":"                       help\u003d\u0027Rest server end point\u0027),"},{"line_number":84,"context_line":"    cfg.PortOpt(utils.RestServerPort,"},{"line_number":85,"context_line":"                default\u003d8443,"},{"line_number":86,"context_line":"                help\u003d\u0027rest server port number\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ae65d0b6","line":83,"range":{"start_line":83,"start_character":29,"end_line":83,"end_character":33},"updated":"2017-10-02 17:11:51.000000000","message":"and here.","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.HostAddressOpt(utils.RestServerIP,"},{"line_number":82,"context_line":"                       default\u003dNone,"},{"line_number":83,"context_line":"                       help\u003d\u0027Rest server end point\u0027),"},{"line_number":84,"context_line":"    cfg.PortOpt(utils.RestServerPort,"},{"line_number":85,"context_line":"                default\u003d8443,"},{"line_number":86,"context_line":"                help\u003d\u0027rest server port number\u0027),"},{"line_number":87,"context_line":"    cfg.StrOpt(utils.ARRAY,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ee6f4825","line":84,"range":{"start_line":84,"start_character":16,"end_line":84,"end_character":36},"updated":"2017-10-02 17:30:11.000000000","message":"vmax_server_port.","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"51f564fade0942ffe337e6c4c29799cf96a350f5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                       help\u003d\u0027Rest server end point\u0027),"},{"line_number":84,"context_line":"    cfg.PortOpt(utils.RestServerPort,"},{"line_number":85,"context_line":"                default\u003d8443,"},{"line_number":86,"context_line":"                help\u003d\u0027rest server port number\u0027),"},{"line_number":87,"context_line":"    cfg.StrOpt(utils.ARRAY,"},{"line_number":88,"context_line":"               help\u003d\u0027Array\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(utils.SRP,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_2e71e076","line":86,"range":{"start_line":86,"start_character":22,"end_line":86,"end_character":26},"updated":"2017-10-02 17:11:51.000000000","message":"And here.","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    cfg.PortOpt(utils.RestServerPort,"},{"line_number":85,"context_line":"                default\u003d8443,"},{"line_number":86,"context_line":"                help\u003d\u0027rest server port number\u0027),"},{"line_number":87,"context_line":"    cfg.StrOpt(utils.ARRAY,"},{"line_number":88,"context_line":"               help\u003d\u0027Array\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(utils.SRP,"},{"line_number":90,"context_line":"               help\u003d\u0027srp\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_2e53206d","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":26},"updated":"2017-10-02 17:30:11.000000000","message":"Should be named vmax_array...","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                default\u003d8443,"},{"line_number":86,"context_line":"                help\u003d\u0027rest server port number\u0027),"},{"line_number":87,"context_line":"    cfg.StrOpt(utils.ARRAY,"},{"line_number":88,"context_line":"               help\u003d\u0027Array\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(utils.SRP,"},{"line_number":90,"context_line":"               help\u003d\u0027srp\u0027),"},{"line_number":91,"context_line":"    cfg.StrOpt(\u0027service_level\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_cec92c26","line":88,"range":{"start_line":88,"start_character":15,"end_line":88,"end_character":27},"updated":"2017-10-02 17:30:11.000000000","message":"Chould use an actual help message here.","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                help\u003d\u0027rest server port number\u0027),"},{"line_number":87,"context_line":"    cfg.StrOpt(utils.ARRAY,"},{"line_number":88,"context_line":"               help\u003d\u0027Array\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(utils.SRP,"},{"line_number":90,"context_line":"               help\u003d\u0027srp\u0027),"},{"line_number":91,"context_line":"    cfg.StrOpt(\u0027service_level\u0027,"},{"line_number":92,"context_line":"               help\u003d\u0027service level\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_aeccb034","line":89,"range":{"start_line":89,"start_character":15,"end_line":89,"end_character":24},"updated":"2017-10-02 17:30:11.000000000","message":"Should be named \"vmax_srp\".","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               help\u003d\u0027Array\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(utils.SRP,"},{"line_number":90,"context_line":"               help\u003d\u0027srp\u0027),"},{"line_number":91,"context_line":"    cfg.StrOpt(\u0027service_level\u0027,"},{"line_number":92,"context_line":"               help\u003d\u0027service level\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(utils.WORKLOAD,"},{"line_number":94,"context_line":"               help\u003d\u0027workload\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_2ed8c0ec","line":91,"range":{"start_line":91,"start_character":15,"end_line":91,"end_character":30},"updated":"2017-10-02 17:30:11.000000000","message":"Should be named \"vmax_service_level\".","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f6b8563b152f7b263277dcfc73da462705edba49","unresolved":false,"context_lines":[{"line_number":90,"context_line":"               help\u003d\u0027srp\u0027),"},{"line_number":91,"context_line":"    cfg.StrOpt(\u0027service_level\u0027,"},{"line_number":92,"context_line":"               help\u003d\u0027service level\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(utils.WORKLOAD,"},{"line_number":94,"context_line":"               help\u003d\u0027workload\u0027),"},{"line_number":95,"context_line":"    cfg.ListOpt(utils.PortGroups,"},{"line_number":96,"context_line":"                bounds\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_0ee3c4a5","line":93,"range":{"start_line":93,"start_character":15,"end_line":93,"end_character":29},"updated":"2017-10-02 17:30:11.000000000","message":"Should be named \"vmax_workload\".","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"47b91b1626bfe70953cad6aaaf478a8ab2d3d883","unresolved":false,"context_lines":[{"line_number":3591,"context_line":""},{"line_number":3592,"context_line":"        return model_update, vol_model_updates"},{"line_number":3593,"context_line":""},{"line_number":3594,"context_line":"    def get_attributes_from_local_config(self):"},{"line_number":3595,"context_line":"        LOG.debug(\"Using local.conf file\")"},{"line_number":3596,"context_line":"        kwargs \u003d None"},{"line_number":3597,"context_line":"        username \u003d self.configuration.safe_get(utils.RestUserName)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_8b30b8a0","line":3594,"updated":"2017-10-03 08:42:26.000000000","message":"Please change the name of the method to reflect it is cinder and not local","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":3591,"context_line":""},{"line_number":3592,"context_line":"        return model_update, vol_model_updates"},{"line_number":3593,"context_line":""},{"line_number":3594,"context_line":"    def get_attributes_from_local_config(self):"},{"line_number":3595,"context_line":"        LOG.debug(\"Using local.conf file\")"},{"line_number":3596,"context_line":"        kwargs \u003d None"},{"line_number":3597,"context_line":"        username \u003d self.configuration.safe_get(utils.RestUserName)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_4b97603b","line":3594,"in_reply_to":"7f515b1d_8b30b8a0","updated":"2017-10-03 08:51:31.000000000","message":"Will do.....thanks","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"51f564fade0942ffe337e6c4c29799cf96a350f5","unresolved":false,"context_lines":[{"line_number":3592,"context_line":"        return model_update, vol_model_updates"},{"line_number":3593,"context_line":""},{"line_number":3594,"context_line":"    def get_attributes_from_local_config(self):"},{"line_number":3595,"context_line":"        LOG.debug(\"Using local.conf file\")"},{"line_number":3596,"context_line":"        kwargs \u003d None"},{"line_number":3597,"context_line":"        username \u003d self.configuration.safe_get(utils.RestUserName)"},{"line_number":3598,"context_line":"        password \u003d self.configuration.safe_get(utils.RestPassword)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_4e241c5e","line":3595,"range":{"start_line":3595,"start_character":25,"end_line":3595,"end_character":34},"updated":"2017-10-02 17:11:51.000000000","message":"Don\u0027t you mean cinder.conf here?","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":3592,"context_line":"        return model_update, vol_model_updates"},{"line_number":3593,"context_line":""},{"line_number":3594,"context_line":"    def get_attributes_from_local_config(self):"},{"line_number":3595,"context_line":"        LOG.debug(\"Using local.conf file\")"},{"line_number":3596,"context_line":"        kwargs \u003d None"},{"line_number":3597,"context_line":"        username \u003d self.configuration.safe_get(utils.RestUserName)"},{"line_number":3598,"context_line":"        password \u003d self.configuration.safe_get(utils.RestPassword)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ab97f444","line":3595,"range":{"start_line":3595,"start_character":25,"end_line":3595,"end_character":34},"in_reply_to":"7f515b1d_4e241c5e","updated":"2017-10-03 08:51:31.000000000","message":"Will change to cinder.conf","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"51f564fade0942ffe337e6c4c29799cf96a350f5","unresolved":false,"context_lines":[{"line_number":3599,"context_line":"        if username and password:"},{"line_number":3600,"context_line":"            serial_number \u003d self.configuration.safe_get(utils.ARRAY)"},{"line_number":3601,"context_line":"            if serial_number is None:"},{"line_number":3602,"context_line":"                LOG.error(\"Array Serial Number must be set in local.conf\")"},{"line_number":3603,"context_line":"            srp_name \u003d self.configuration.safe_get(\u0027srp\u0027)"},{"line_number":3604,"context_line":"            if srp_name is None:"},{"line_number":3605,"context_line":"                LOG.error(\"SRP Name must be set in local.conf\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_0e1aa415","line":3602,"range":{"start_line":3602,"start_character":62,"end_line":3602,"end_character":72},"updated":"2017-10-02 17:11:51.000000000","message":"cinder.conf","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":3599,"context_line":"        if username and password:"},{"line_number":3600,"context_line":"            serial_number \u003d self.configuration.safe_get(utils.ARRAY)"},{"line_number":3601,"context_line":"            if serial_number is None:"},{"line_number":3602,"context_line":"                LOG.error(\"Array Serial Number must be set in local.conf\")"},{"line_number":3603,"context_line":"            srp_name \u003d self.configuration.safe_get(\u0027srp\u0027)"},{"line_number":3604,"context_line":"            if srp_name is None:"},{"line_number":3605,"context_line":"                LOG.error(\"SRP Name must be set in local.conf\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_6b8fbc29","line":3602,"range":{"start_line":3602,"start_character":62,"end_line":3602,"end_character":72},"in_reply_to":"7f515b1d_0e1aa415","updated":"2017-10-03 08:51:31.000000000","message":"same","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"51f564fade0942ffe337e6c4c29799cf96a350f5","unresolved":false,"context_lines":[{"line_number":3602,"context_line":"                LOG.error(\"Array Serial Number must be set in local.conf\")"},{"line_number":3603,"context_line":"            srp_name \u003d self.configuration.safe_get(\u0027srp\u0027)"},{"line_number":3604,"context_line":"            if srp_name is None:"},{"line_number":3605,"context_line":"                LOG.error(\"SRP Name must be set in local.conf\")"},{"line_number":3606,"context_line":"            slo \u003d self.configuration.safe_get(\u0027ServiceLevel\u0027)"},{"line_number":3607,"context_line":"            workload \u003d self.configuration.safe_get(utils.WORKLOAD)"},{"line_number":3608,"context_line":"            portgroups \u003d self.configuration.safe_get(utils.PortGroups)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_ced5ac1d","line":3605,"range":{"start_line":3605,"start_character":51,"end_line":3605,"end_character":61},"updated":"2017-10-02 17:11:51.000000000","message":"cinder.conf","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"7cebf1770ac46a27c1d13b0d5ab24be813749f01","unresolved":false,"context_lines":[{"line_number":3602,"context_line":"                LOG.error(\"Array Serial Number must be set in local.conf\")"},{"line_number":3603,"context_line":"            srp_name \u003d self.configuration.safe_get(\u0027srp\u0027)"},{"line_number":3604,"context_line":"            if srp_name is None:"},{"line_number":3605,"context_line":"                LOG.error(\"SRP Name must be set in local.conf\")"},{"line_number":3606,"context_line":"            slo \u003d self.configuration.safe_get(\u0027ServiceLevel\u0027)"},{"line_number":3607,"context_line":"            workload \u003d self.configuration.safe_get(utils.WORKLOAD)"},{"line_number":3608,"context_line":"            portgroups \u003d self.configuration.safe_get(utils.PortGroups)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_4b82c001","line":3605,"range":{"start_line":3605,"start_character":51,"end_line":3605,"end_character":61},"in_reply_to":"7f515b1d_ced5ac1d","updated":"2017-10-03 08:51:31.000000000","message":"same","commit_id":"6592b8c146d165bada976632ce6816b91b8e9a7e"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"ab04790c1cad9956d48799a36b4e3bf81b755658","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                     \u0027the initiator_check.\u0027),"},{"line_number":74,"context_line":"    cfg.PortOpt(utils.VMAX_SERVER_PORT,"},{"line_number":75,"context_line":"                default\u003d8443,"},{"line_number":76,"context_line":"                help\u003d\u0027REST server port number\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.VMAX_ARRAY,"},{"line_number":78,"context_line":"               help\u003d\u0027Serial number of the array to connect to\u0027),"},{"line_number":79,"context_line":"    cfg.StrOpt(utils.VMAX_SRP,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_29db65ed","line":76,"range":{"start_line":76,"start_character":45,"end_line":76,"end_character":46},"updated":"2017-10-09 16:25:12.000000000","message":".","commit_id":"3c00f3db1324dcac829496c180462f8faaef34c9"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"dadfe5948f980ea13e18984836ba834178a02a9e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                     \u0027the initiator_check.\u0027),"},{"line_number":74,"context_line":"    cfg.PortOpt(utils.VMAX_SERVER_PORT,"},{"line_number":75,"context_line":"                default\u003d8443,"},{"line_number":76,"context_line":"                help\u003d\u0027REST server port number\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.VMAX_ARRAY,"},{"line_number":78,"context_line":"               help\u003d\u0027Serial number of the array to connect to\u0027),"},{"line_number":79,"context_line":"    cfg.StrOpt(utils.VMAX_SRP,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f4e5783_a48dd77c","line":76,"range":{"start_line":76,"start_character":45,"end_line":76,"end_character":46},"in_reply_to":"7f515b1d_29db65ed","updated":"2017-10-10 08:22:14.000000000","message":"Will fix and resubmit....thanks","commit_id":"3c00f3db1324dcac829496c180462f8faaef34c9"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"ab04790c1cad9956d48799a36b4e3bf81b755658","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                default\u003d8443,"},{"line_number":76,"context_line":"                help\u003d\u0027REST server port number\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(utils.VMAX_ARRAY,"},{"line_number":78,"context_line":"               help\u003d\u0027Serial number of the array to connect to\u0027),"},{"line_number":79,"context_line":"    cfg.StrOpt(utils.VMAX_SRP,"},{"line_number":80,"context_line":"               help\u003d\u0027Storage resource pool on array to use for provisioning\u0027),"},{"line_number":81,"context_line":"    cfg.StrOpt(utils.VMAX_SERVICE_LEVEL,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_e9e0ad99","line":78,"range":{"start_line":78,"start_character":59,"end_line":78,"end_character":62},"updated":"2017-10-09 16:25:12.000000000","message":".","commit_id":"3c00f3db1324dcac829496c180462f8faaef34c9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7bd38ec436ad14c644fec31e5572e820a6f9bcaf","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    It supports VMAX 3 and VMAX All Flash arrays."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    \"\"\""},{"line_number":101,"context_line":"    VERSION \u003d \"3.0.0\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    stats \u003d {\u0027driver_version\u0027: \u00273.0\u0027,"},{"line_number":104,"context_line":"             \u0027free_capacity_gb\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f4e5783_aaa1a348","line":101,"updated":"2017-10-13 16:52:02.000000000","message":"this is a pretty big change and should be a driver version bump","commit_id":"f80a1a6ef7c6dc54abd7b2d2a70ead4126bf2802"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"a52fe80ce45c999bdfd118f10ade64f31e62783c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    It supports VMAX 3 and VMAX All Flash arrays."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    \"\"\""},{"line_number":101,"context_line":"    VERSION \u003d \"3.0.0\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    stats \u003d {\u0027driver_version\u0027: \u00273.0\u0027,"},{"line_number":104,"context_line":"             \u0027free_capacity_gb\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f4e5783_11ec2628","line":101,"in_reply_to":"5f4e5783_aaa1a348","updated":"2017-10-17 13:42:12.000000000","message":"I will remove VERSION from this file as we are getting it from iscsi.py and fc.py. There I will include it in the 3.1.0 version history.....Thanks","commit_id":"f80a1a6ef7c6dc54abd7b2d2a70ead4126bf2802"}],"cinder/volume/drivers/dell_emc/vmax/fc.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"771905fa21b3a88fa7fd93d969aa36b03f5e9139","unresolved":false,"context_lines":[{"line_number":83,"context_line":"              - Support for volume replication"},{"line_number":84,"context_line":"              - Support for live migration"},{"line_number":85,"context_line":"              - Support for Generic Volume Group"},{"line_number":86,"context_line":"        3.1.0 - Support for replication groups (Tiramisu)"},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    VERSION \u003d \"3.1.0\""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_8489bb27","line":86,"range":{"start_line":86,"start_character":16,"end_line":86,"end_character":38},"updated":"2017-10-18 13:14:37.000000000","message":"The version information should be updated here as well.","commit_id":"b4fe06f5cda35af54fc1c1cde67071d5a68742b8"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"96d02df5468880543a15cf7ec74e0f70b462adfa","unresolved":false,"context_lines":[{"line_number":83,"context_line":"              - Support for volume replication"},{"line_number":84,"context_line":"              - Support for live migration"},{"line_number":85,"context_line":"              - Support for Generic Volume Group"},{"line_number":86,"context_line":"        3.1.0 - Support for replication groups (Tiramisu)"},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    VERSION \u003d \"3.1.0\""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_922c3d48","line":86,"range":{"start_line":86,"start_character":16,"end_line":86,"end_character":38},"in_reply_to":"3f4b6375_8489bb27","updated":"2017-10-19 10:38:23.000000000","message":"Hi Jay,\nSince Newton we have not incremented per feature.  Queens is our 3.1 release.  If we backport we do increment the minor part e.g. 3.0.1","commit_id":"b4fe06f5cda35af54fc1c1cde67071d5a68742b8"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"cd122d4f4e1d8416c3697183c4591ebe3b0874f9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"              - Support for volume replication"},{"line_number":84,"context_line":"              - Support for live migration"},{"line_number":85,"context_line":"              - Support for Generic Volume Group"},{"line_number":86,"context_line":"        3.1.0 - Support for replication groups (Tiramisu)"},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    VERSION \u003d \"3.1.0\""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_6c174147","line":86,"range":{"start_line":86,"start_character":16,"end_line":86,"end_character":38},"in_reply_to":"3f4b6375_8489bb27","updated":"2017-10-24 09:47:56.000000000","message":"Will update the version information here....thanks Jay","commit_id":"b4fe06f5cda35af54fc1c1cde67071d5a68742b8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cef74652df2af3cc7f187aff2c140c8a0bbf5c7a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"              - Support for volume replication"},{"line_number":84,"context_line":"              - Support for live migration"},{"line_number":85,"context_line":"              - Support for Generic Volume Group"},{"line_number":86,"context_line":"        3.1.0 - Support for replication groups (Tiramisu)"},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    VERSION \u003d \"3.1.0\""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f4b6375_087dc0b0","line":86,"range":{"start_line":86,"start_character":16,"end_line":86,"end_character":38},"in_reply_to":"3f4b6375_922c3d48","updated":"2017-10-19 12:30:48.000000000","message":"You wouldn\u0027t be able to backport a deprecation, but for other situations I think if you can\u0027t backport the full history up until that point from master (where you would just use whatever full version is in master) then what you are suggesting would work.","commit_id":"b4fe06f5cda35af54fc1c1cde67071d5a68742b8"}],"cinder/volume/drivers/dell_emc/vmax/utils.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"71eec4f80e24bc5e172a1c82bbd95fb6d35c65d1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"DISABLECOMPRESSION \u003d \u0027storagetype:disablecompression\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Cinder.conf vmax configuration"},{"line_number":63,"context_line":"VMAX_SERVER_IP \u003d \u0027vmax_server_ip\u0027"},{"line_number":64,"context_line":"VMAX_USER_NAME \u003d \u0027vmax_user_name\u0027"},{"line_number":65,"context_line":"VMAX_PASSWORD \u003d \u0027vmax_password\u0027"},{"line_number":66,"context_line":"VMAX_SERVER_PORT \u003d \u0027vmax_server_port\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_04180ed1","line":63,"range":{"start_line":63,"start_character":18,"end_line":63,"end_character":32},"updated":"2017-10-04 17:24:18.000000000","message":"Sorry to spin around on this a bit but I am realizing that this falls into the category of options that we talked about at the PTG that we are trying to consolidate.  So, for server ip, username, password, etc it should use the common configuration items from the san class.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/san/san.py \n\nSorry for not thinking of this earlier.","commit_id":"a35e0b642a6f0f6ae2506833929d9e07bfa2e35f"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"cf744e02897c3e56dd1df85b64d29308ba463b0d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"DISABLECOMPRESSION \u003d \u0027storagetype:disablecompression\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Cinder.conf vmax configuration"},{"line_number":63,"context_line":"VMAX_SERVER_IP \u003d \u0027vmax_server_ip\u0027"},{"line_number":64,"context_line":"VMAX_USER_NAME \u003d \u0027vmax_user_name\u0027"},{"line_number":65,"context_line":"VMAX_PASSWORD \u003d \u0027vmax_password\u0027"},{"line_number":66,"context_line":"VMAX_SERVER_PORT \u003d \u0027vmax_server_port\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_f3fc2c73","line":63,"range":{"start_line":63,"start_character":18,"end_line":63,"end_character":32},"in_reply_to":"7f515b1d_04180ed1","updated":"2017-10-09 08:11:49.000000000","message":"Hi Jay, I will make the change to san_ip, san_login, san_password.  As we are using REST in connecting to the SAN, I will be using san_rest_port as opposed to san_ssh_port as indicated......Thanks for your feedback","commit_id":"a35e0b642a6f0f6ae2506833929d9e07bfa2e35f"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"ab04790c1cad9956d48799a36b4e3bf81b755658","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        :returns: list"},{"line_number":338,"context_line":"        \"\"\""},{"line_number":339,"context_line":"        LOG.warning(\"Use of xml file in backend configuration is deprecated \""},{"line_number":340,"context_line":"                    \"in Queens and will not be supported in future releases \")"},{"line_number":341,"context_line":"        kwargs \u003d {}"},{"line_number":342,"context_line":"        my_file \u003d open(file_name, \u0027r\u0027)"},{"line_number":343,"context_line":"        data \u003d my_file.read()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_e94b0dae","line":340,"range":{"start_line":340,"start_character":75,"end_line":340,"end_character":76},"updated":"2017-10-09 16:25:12.000000000","message":".","commit_id":"3c00f3db1324dcac829496c180462f8faaef34c9"}]}