)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"803945914a3175e1cec073d0dd798585274b8a52","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ann Kamyshnikova \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-06 15:22:50 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass per-driver config to copy_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will allow to set it up differently for every instance"},{"line_number":10,"context_line":"in multi-backend mode."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F%2B2LQ%3D","line":7,"updated":"2013-11-19 12:24:14.000000000","message":"I think this commit message could be worded better. Something like:\n\n\"Allow volume_dd_blocksize config option to be configurable on a per-driver basis.\n\nThis allows drivers used in multi-backend configurations to define their own values. We port this to the LVM and block_device drivers here but it can easily be ported to others as and when needed.\"","commit_id":"949b12e6477df43b4e6d8b0adc2263e16919b3e5"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"736507092eb347f25554dc8308d1d6b4ed5a0c84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ann Kamyshnikova \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-06 15:22:50 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass per-driver config to copy_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will allow to set it up differently for every instance"},{"line_number":10,"context_line":"in multi-backend mode."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F%2B2GE%3D","line":7,"in_reply_to":"AAAATn%2F%2B2LQ%3D","updated":"2013-11-19 12:47:01.000000000","message":"thanks, I will change it.","commit_id":"949b12e6477df43b4e6d8b0adc2263e16919b3e5"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"923e5872c3b30ee5ce049735f76f93ce0f34656e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ann Kamyshnikova \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-22 14:29:35 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass per-driver config to copy_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow volume_dd_blocksize config option to be configurable on a"},{"line_number":10,"context_line":"per-driver basis."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F%2BhO8%3D","line":7,"updated":"2013-11-25 08:07:31.000000000","message":"The title is too big/general for this change.","commit_id":"22ee0d6adfd18002c72cc415f5fd8f000a7d671d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ae8a6b3eb8f15cef1c5b8b5e32ef18a6fdb050d9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass per-driver config to copy_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow volume_dd_blocksize config option to be configurable on a"},{"line_number":10,"context_line":"per-driver basis."},{"line_number":11,"context_line":"This allows drivers used in multi-backend configurations"},{"line_number":12,"context_line":"to define their own values. We port this to the LVM and block_device"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F%2BbdA%3D","line":9,"updated":"2013-11-26 07:52:22.000000000","message":"ok","commit_id":"22ee0d6adfd18002c72cc415f5fd8f000a7d671d"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"923e5872c3b30ee5ce049735f76f93ce0f34656e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"drivers here but it can easily be ported to others as and when"},{"line_number":14,"context_line":"needed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"bp: per-driver-config-for-utils-functions"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ice9e815f18e5ebf3727aab7d3a221acacb710cd4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F%2BhOE%3D","line":16,"updated":"2013-11-25 08:07:31.000000000","message":"Per my understanding, the bp has bigger goal than just making \u0027dd\u0027 size option configurable for every driver although the bp itself is way too simple.  If what you want to achieve is just not just this single config option, then you should use \u0027partially implement BP-NAME\u0027 instead.\n\nAlso I\u0027d suggest you write more information in the BP.  At least please include background/problem statement and proposed solution, and maybe potential impact to other part of Cinder code as well.","commit_id":"22ee0d6adfd18002c72cc415f5fd8f000a7d671d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ae8a6b3eb8f15cef1c5b8b5e32ef18a6fdb050d9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"drivers here but it can easily be ported to others as and when"},{"line_number":14,"context_line":"needed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"bp: per-driver-config-for-utils-functions"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ice9e815f18e5ebf3727aab7d3a221acacb710cd4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F%2Bbc8%3D","line":16,"in_reply_to":"AAAATn%2F%2BhOE%3D","updated":"2013-11-26 07:52:22.000000000","message":"I created bp because Walter A. Boring asked for it. I don\u0027t think that this change needs it myself. When I have time I\u0027ll write more information about my work.","commit_id":"22ee0d6adfd18002c72cc415f5fd8f000a7d671d"}],"cinder/tests/test_volume_utils.py":[{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"9cae8e482c9e8ff0d3d1f9b8d088f9baa606b061","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertEqual(count, 1024)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # Test \u0027volume_dd_blocksize\u0027 with fraction"},{"line_number":134,"context_line":"        CONF.set_override(\u0027volume_dd_blocksize\u0027, \u00271.3M\u0027)"},{"line_number":135,"context_line":"        bs, count \u003d volume_utils._calculate_count(1024, \u00271.3M\u0027)"},{"line_number":136,"context_line":"        self.assertEqual(bs, \u00271M\u0027)"},{"line_number":137,"context_line":"        self.assertEqual(count, 1024)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BhkM%3D","line":134,"updated":"2013-11-25 05:18:09.000000000","message":"It\u0027s just a nitpick but I think that it can be deleted.","commit_id":"22ee0d6adfd18002c72cc415f5fd8f000a7d671d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"ae8a6b3eb8f15cef1c5b8b5e32ef18a6fdb050d9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertEqual(count, 1024)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # Test \u0027volume_dd_blocksize\u0027 with fraction"},{"line_number":134,"context_line":"        CONF.set_override(\u0027volume_dd_blocksize\u0027, \u00271.3M\u0027)"},{"line_number":135,"context_line":"        bs, count \u003d volume_utils._calculate_count(1024, \u00271.3M\u0027)"},{"line_number":136,"context_line":"        self.assertEqual(bs, \u00271M\u0027)"},{"line_number":137,"context_line":"        self.assertEqual(count, 1024)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Bbf0%3D","line":134,"in_reply_to":"AAAATn%2F%2BhkM%3D","updated":"2013-11-26 07:52:22.000000000","message":"thanks, I didn\u0027t notice, I\u0027ll correct.","commit_id":"22ee0d6adfd18002c72cc415f5fd8f000a7d671d"}],"cinder/volume/driver.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"3d7486d7d5ce9a60b656649d030b8182d52cd829","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        try:"},{"line_number":316,"context_line":"            size_in_mb \u003d int(src_vol[\u0027size\u0027]) * 1024    # vol size is in GB"},{"line_number":317,"context_line":"            volume_utils.copy_volume(src_attach_info[\u0027device\u0027][\u0027path\u0027],"},{"line_number":318,"context_line":"                                     dest_attach_info[\u0027device\u0027][\u0027path\u0027],"},{"line_number":319,"context_line":"                                     size_in_mb)"},{"line_number":320,"context_line":"            copy_error \u003d False"},{"line_number":321,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BGx0%3D","line":318,"updated":"2013-12-02 15:05:28.000000000","message":"Please add blocksize and execute args here","commit_id":"aec8d7aa0c1716de920dd1cd4b3dbe12070a1233"}],"cinder/volume/utils.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"e9c3b5ba88b0522ddb55815d1a3b4c0bd72e9ba9","unresolved":false,"context_lines":[{"line_number":164,"context_line":"def copy_volume(srcstr, deststr, size_in_m, sync\u003dFalse,"},{"line_number":165,"context_line":"                execute\u003dutils.execute, blocksize\u003dNone):"},{"line_number":166,"context_line":"    if blocksize is None:"},{"line_number":167,"context_line":"        blocksize \u003d CONF.volume_dd_blocksize"},{"line_number":168,"context_line":"    # Use O_DIRECT to avoid thrashing the system buffer cache"},{"line_number":169,"context_line":"    extra_flags \u003d [\u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027]"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9i0o%3D","line":167,"updated":"2013-12-10 12:10:17.000000000","message":"CONF.volume_dd_blocksize doesn\u0027t exist any more","commit_id":"a66896b98812296c37415c7554866c834be0cf3e"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"30a75c3a00c1b16cdfe7a00095cccb0d259e9b44","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def copy_volume(srcstr, deststr, size_in_m, sync\u003dFalse,"},{"line_number":165,"context_line":"                execute\u003dutils.execute, blocksize\u003dNone):"},{"line_number":166,"context_line":"    assert blocksize is not None"},{"line_number":167,"context_line":"    # Use O_DIRECT to avoid thrashing the system buffer cache"},{"line_number":168,"context_line":"    extra_flags \u003d [\u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027]"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9iCo%3D","line":166,"updated":"2013-12-10 14:38:07.000000000","message":"I am not seeing any use of the default value of blocksize\u003dNone if we\u0027re anyways asserting it to be not None in the very first statement. Am I missing something?","commit_id":"975564f3e0de40e2da071b32e412dd14c1ab8bd2"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"412e8e410ab38fbe55bc84e78e8c870b1b3068e6","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def copy_volume(srcstr, deststr, size_in_m, sync\u003dFalse,"},{"line_number":165,"context_line":"                execute\u003dutils.execute, blocksize\u003dNone):"},{"line_number":166,"context_line":"    assert blocksize is not None"},{"line_number":167,"context_line":"    # Use O_DIRECT to avoid thrashing the system buffer cache"},{"line_number":168,"context_line":"    extra_flags \u003d [\u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027]"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9FZE%3D","line":166,"in_reply_to":"AAAATn%2F9eBI%3D","updated":"2013-12-16 23:01:07.000000000","message":"If blocksize is now required, that typically means it needs to not be None.   This doesn\u0027t seem right to me to add it as a parameter that can default to None (meaning it\u0027s not required), and then force it to be a value other than the default.  \n\nI think it\u0027s probably better to change the order of parameters and add it prior to sync.","commit_id":"975564f3e0de40e2da071b32e412dd14c1ab8bd2"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"711bf6f248dba350ad9156c4c43033b95afa42b9","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def copy_volume(srcstr, deststr, size_in_m, sync\u003dFalse,"},{"line_number":165,"context_line":"                execute\u003dutils.execute, blocksize\u003dNone):"},{"line_number":166,"context_line":"    assert blocksize is not None"},{"line_number":167,"context_line":"    # Use O_DIRECT to avoid thrashing the system buffer cache"},{"line_number":168,"context_line":"    extra_flags \u003d [\u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027]"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9eBI%3D","line":166,"in_reply_to":"AAAATn%2F9hz8%3D","updated":"2013-12-11 07:10:39.000000000","message":"This parameter is required but it was added to the end to give an opportunity not to change order of arguments in all calls of this method.","commit_id":"975564f3e0de40e2da071b32e412dd14c1ab8bd2"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"f6eba08706c2da2f613f2ba6b4cbe71222931b9a","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def copy_volume(srcstr, deststr, size_in_m, sync\u003dFalse,"},{"line_number":165,"context_line":"                execute\u003dutils.execute, blocksize\u003dNone):"},{"line_number":166,"context_line":"    assert blocksize is not None"},{"line_number":167,"context_line":"    # Use O_DIRECT to avoid thrashing the system buffer cache"},{"line_number":168,"context_line":"    extra_flags \u003d [\u0027iflag\u003ddirect\u0027, \u0027oflag\u003ddirect\u0027]"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9hz8%3D","line":166,"in_reply_to":"AAAATn%2F9iCo%3D","updated":"2013-12-10 15:13:01.000000000","message":"The author used to assign default value, CONF.volume_dd_blocksize, in parameter \u0027blocksize\u0027 declaration, and then change the default value to \u0027None\u0027. Is he attempting to defend the caller to input \u0027None\u0027 as this parameter value?","commit_id":"975564f3e0de40e2da071b32e412dd14c1ab8bd2"}]}