)]}'
{"cinder/tests/unit/volume/drivers/test_remotefs.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"bc5e5b135ead93ab12de3fe7656fbb71aaa1a87b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self._fake_snapshot \u003d fake_snapshot.fake_snapshot_obj(self.context)"},{"line_number":51,"context_line":"        self._fake_snapshot_path \u003d (self._fake_volume_path + \u0027.\u0027 +"},{"line_number":52,"context_line":"                                    self._fake_snapshot.id)"},{"line_number":53,"context_line":"        self._fake_snapshot_name \u003d os.path.basename("},{"line_number":54,"context_line":"            self._fake_snapshot_path)"},{"line_number":55,"context_line":"        self._fake_snapshot.volume \u003d self._fake_volume"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @ddt.data({\u0027current_state\u0027: \u0027in-use\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f4e5783_4b7c2c82","line":54,"range":{"start_line":53,"start_character":8,"end_line":54,"end_character":37},"updated":"2017-10-17 12:13:44.000000000","message":"Seems unused.","commit_id":"eff6ad65508baf3ac1cd07cf6a7d55bbf6e1a71a"}],"cinder/tests/unit/volume/test_volume.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"828f88d8cdbc8999b918e4e57a477ef27dbabbb5","unresolved":false,"context_lines":[{"line_number":1771,"context_line":"            if driver_error:"},{"line_number":1772,"context_line":"                generic_revert.assert_called_once_with(self.context, {}, {})"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":"    @ddt.data({}, "},{"line_number":1775,"context_line":"              {\u0027has_snapshot\u0027: True},"},{"line_number":1776,"context_line":"              {\u0027use_temp_snapshot\u0027: True},"},{"line_number":1777,"context_line":"              {\u0027use_temp_snapshot\u0027: True, \u0027has_snapshot\u0027: True})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_231df972","line":1774,"range":{"start_line":1774,"start_character":15,"end_line":1774,"end_character":18},"updated":"2017-10-06 16:03:01.000000000","message":"Trailing white space.  Please fix.","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"},{"author":{"_account_id":26415,"name":"Alexandru Muresan","email":"amuresan@cloudbasesolutions.com","username":"amuresan"},"change_message_id":"849a76cf3aa6a4b19263fda8f59f55ecc7b54c23","unresolved":false,"context_lines":[{"line_number":1771,"context_line":"            if driver_error:"},{"line_number":1772,"context_line":"                generic_revert.assert_called_once_with(self.context, {}, {})"},{"line_number":1773,"context_line":""},{"line_number":1774,"context_line":"    @ddt.data({}, "},{"line_number":1775,"context_line":"              {\u0027has_snapshot\u0027: True},"},{"line_number":1776,"context_line":"              {\u0027use_temp_snapshot\u0027: True},"},{"line_number":1777,"context_line":"              {\u0027use_temp_snapshot\u0027: True, \u0027has_snapshot\u0027: True})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_d353f7e1","line":1774,"range":{"start_line":1774,"start_character":15,"end_line":1774,"end_character":18},"in_reply_to":"7f515b1d_231df972","updated":"2017-10-10 11:10:48.000000000","message":"Done","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"828f88d8cdbc8999b918e4e57a477ef27dbabbb5","unresolved":false,"context_lines":[{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"    def _revert_to_snapshot(self, context, volume, snapshot):"},{"line_number":1615,"context_line":"        \"\"\"Revert a volume to specified snapshot"},{"line_number":1616,"context_line":"        "},{"line_number":1617,"context_line":"        If volume status is \u0027available\u0027, revert the volume to the latest"},{"line_number":1618,"context_line":"        snapshot."},{"line_number":1619,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_de0b9e21","line":1616,"range":{"start_line":1616,"start_character":0,"end_line":1616,"end_character":8},"updated":"2017-10-06 16:03:01.000000000","message":"White space.","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"},{"author":{"_account_id":26415,"name":"Alexandru Muresan","email":"amuresan@cloudbasesolutions.com","username":"amuresan"},"change_message_id":"849a76cf3aa6a4b19263fda8f59f55ecc7b54c23","unresolved":false,"context_lines":[{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"    def _revert_to_snapshot(self, context, volume, snapshot):"},{"line_number":1615,"context_line":"        \"\"\"Revert a volume to specified snapshot"},{"line_number":1616,"context_line":"        "},{"line_number":1617,"context_line":"        If volume status is \u0027available\u0027, revert the volume to the latest"},{"line_number":1618,"context_line":"        snapshot."},{"line_number":1619,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_535947fc","line":1616,"range":{"start_line":1616,"start_character":0,"end_line":1616,"end_character":8},"in_reply_to":"7f515b1d_de0b9e21","updated":"2017-10-10 11:10:48.000000000","message":"Done","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"828f88d8cdbc8999b918e4e57a477ef27dbabbb5","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"    def _revert_to_snapshot(self, context, volume, snapshot):"},{"line_number":1615,"context_line":"        \"\"\"Revert a volume to specified snapshot"},{"line_number":1616,"context_line":"        "},{"line_number":1617,"context_line":"        If volume status is \u0027available\u0027, revert the volume to the latest"},{"line_number":1618,"context_line":"        snapshot."},{"line_number":1619,"context_line":"        \"\"\""},{"line_number":1620,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_5e30cee8","line":1617,"range":{"start_line":1617,"start_character":28,"end_line":1617,"end_character":40},"updated":"2017-10-06 16:03:01.000000000","message":"Where is the state being checked?  I do not see a check here.","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"},{"author":{"_account_id":26415,"name":"Alexandru Muresan","email":"amuresan@cloudbasesolutions.com","username":"amuresan"},"change_message_id":"849a76cf3aa6a4b19263fda8f59f55ecc7b54c23","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"    def _revert_to_snapshot(self, context, volume, snapshot):"},{"line_number":1615,"context_line":"        \"\"\"Revert a volume to specified snapshot"},{"line_number":1616,"context_line":"        "},{"line_number":1617,"context_line":"        If volume status is \u0027available\u0027, revert the volume to the latest"},{"line_number":1618,"context_line":"        snapshot."},{"line_number":1619,"context_line":"        \"\"\""},{"line_number":1620,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_335ecbe6","line":1617,"range":{"start_line":1617,"start_character":28,"end_line":1617,"end_character":40},"in_reply_to":"7f515b1d_5e30cee8","updated":"2017-10-10 11:10:48.000000000","message":"Done","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"828f88d8cdbc8999b918e4e57a477ef27dbabbb5","unresolved":false,"context_lines":[{"line_number":1685,"context_line":"    @locked_volume_id_operation"},{"line_number":1686,"context_line":"    def revert_to_snapshot(self, context, volume, snapshot):"},{"line_number":1687,"context_line":"        \"\"\"Revert to specified snapshot.\"\"\""},{"line_number":1688,"context_line":"        "},{"line_number":1689,"context_line":"        return self._revert_to_snapshot(context, volume, snapshot)"},{"line_number":1690,"context_line":""},{"line_number":1691,"context_line":"    @locked_volume_id_operation"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_de24beb1","line":1688,"range":{"start_line":1688,"start_character":0,"end_line":1688,"end_character":8},"updated":"2017-10-06 16:03:01.000000000","message":"White space.","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"},{"author":{"_account_id":26415,"name":"Alexandru Muresan","email":"amuresan@cloudbasesolutions.com","username":"amuresan"},"change_message_id":"849a76cf3aa6a4b19263fda8f59f55ecc7b54c23","unresolved":false,"context_lines":[{"line_number":1685,"context_line":"    @locked_volume_id_operation"},{"line_number":1686,"context_line":"    def revert_to_snapshot(self, context, volume, snapshot):"},{"line_number":1687,"context_line":"        \"\"\"Revert to specified snapshot.\"\"\""},{"line_number":1688,"context_line":"        "},{"line_number":1689,"context_line":"        return self._revert_to_snapshot(context, volume, snapshot)"},{"line_number":1690,"context_line":""},{"line_number":1691,"context_line":"    @locked_volume_id_operation"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_1373cf82","line":1688,"range":{"start_line":1688,"start_character":0,"end_line":1688,"end_character":8},"in_reply_to":"7f515b1d_de24beb1","updated":"2017-10-10 11:10:48.000000000","message":"Done","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"}],"cinder/volume/drivers/windows/smbfs.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"bc5e5b135ead93ab12de3fe7656fbb71aaa1a87b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"@interface.volumedriver"},{"line_number":95,"context_line":"class WindowsSmbfsDriver(remotefs_drv.RevertToSnapshotMixin,"},{"line_number":96,"context_line":"                         remotefs_drv.RemoteFSPoolMixin,"},{"line_number":97,"context_line":"                         remotefs_drv.RemoteFSSnapDriverDistributed):"},{"line_number":98,"context_line":"    VERSION \u003d VERSION"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f4e5783_abbe00fc","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":56},"updated":"2017-10-17 12:13:44.000000000","message":"Judging by the commit message, this commit doesn\u0027t seem to target the SMBFS driver. Besides, you have a patch depending on this one that actually makes this change.","commit_id":"eff6ad65508baf3ac1cd07cf6a7d55bbf6e1a71a"}],"cinder/volume/manager.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"828f88d8cdbc8999b918e4e57a477ef27dbabbb5","unresolved":false,"context_lines":[{"line_number":935,"context_line":"            LOG.info(\"Start to perform revert to snapshot process.\")"},{"line_number":936,"context_line":"            # Create a snapshot which can be used to restore the volume"},{"line_number":937,"context_line":"            # data by hand if revert process failed."},{"line_number":938,"context_line":"       "},{"line_number":939,"context_line":"            if self.driver.snapshot_revert_use_temp_snapshot():"},{"line_number":940,"context_line":"                backup_snapshot \u003d self._create_backup_snapshot(context,"},{"line_number":941,"context_line":"                                                               volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_3e9bd2c9","line":938,"range":{"start_line":938,"start_character":0,"end_line":938,"end_character":7},"updated":"2017-10-06 16:03:01.000000000","message":"More white space.","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"},{"author":{"_account_id":26415,"name":"Alexandru Muresan","email":"amuresan@cloudbasesolutions.com","username":"amuresan"},"change_message_id":"849a76cf3aa6a4b19263fda8f59f55ecc7b54c23","unresolved":false,"context_lines":[{"line_number":935,"context_line":"            LOG.info(\"Start to perform revert to snapshot process.\")"},{"line_number":936,"context_line":"            # Create a snapshot which can be used to restore the volume"},{"line_number":937,"context_line":"            # data by hand if revert process failed."},{"line_number":938,"context_line":"       "},{"line_number":939,"context_line":"            if self.driver.snapshot_revert_use_temp_snapshot():"},{"line_number":940,"context_line":"                backup_snapshot \u003d self._create_backup_snapshot(context,"},{"line_number":941,"context_line":"                                                               volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_b3699b8c","line":938,"range":{"start_line":938,"start_character":0,"end_line":938,"end_character":7},"in_reply_to":"7f515b1d_3e9bd2c9","updated":"2017-10-10 11:10:48.000000000","message":"Done","commit_id":"ce97abb3ca353a83b59235e1e717f713c31eff5a"}]}