)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"99f7c9d3bdcdf7ae15f8365ec7ef57cf89fdd072","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use oslo_db.sqlalchemy.enginefacade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EngineFacade is deprecated, so use oslo_db.sqlalchemy.enginefacade"},{"line_number":10,"context_line":"and update \u0027get_session\u0027 method To keep backward compatibility."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idae54a17567b558352031ecc573d83ab8b8f04b9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f4e5783_732e35fb","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":34},"updated":"2017-10-12 12:39:38.000000000","message":"nit: s/To/to","commit_id":"8c3761d5bf1d8be6d156933a68a4561b4ad8ab60"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"b33e591cc4e8bca7ff2da91297ae2e2c9683687a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use oslo_db.sqlalchemy.enginefacade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"EngineFacade is deprecated, so use oslo_db.sqlalchemy.enginefacade"},{"line_number":10,"context_line":"and update \u0027get_session\u0027 method To keep backward compatibility."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idae54a17567b558352031ecc573d83ab8b8f04b9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f4e5783_625aca4f","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":34},"in_reply_to":"5f4e5783_732e35fb","updated":"2017-11-06 08:20:45.000000000","message":"Done","commit_id":"8c3761d5bf1d8be6d156933a68a4561b4ad8ab60"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"99f7c9d3bdcdf7ae15f8365ec7ef57cf89fdd072","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    :param project_only: if present and context is user-type, then restrict"},{"line_number":268,"context_line":"            query to match the context\u0027s project_id."},{"line_number":269,"context_line":"    \"\"\""},{"line_number":270,"context_line":"    if hasattr(context, \"session\"):"},{"line_number":271,"context_line":"        session \u003d context.session"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    session \u003d kwargs.get(\u0027session\u0027) or get_session()"},{"line_number":274,"context_line":"    read_deleted \u003d kwargs.get(\u0027read_deleted\u0027) or context.read_deleted"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_f3c6a549","line":271,"range":{"start_line":270,"start_character":4,"end_line":271,"end_character":33},"updated":"2017-10-12 12:39:38.000000000","message":"-1: Is there a reason we need this change?\n\n\u0027session\u0027 anyway is getting modified at line #273.\n\n\nOr you have a requirement like below:\n\nif hasattr(context, \"session\"):\n    session \u003d context.session\nelse:\n    session \u003d kwargs.get(\u0027session\u0027) or get_session()","commit_id":"8c3761d5bf1d8be6d156933a68a4561b4ad8ab60"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"b33e591cc4e8bca7ff2da91297ae2e2c9683687a","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    :param project_only: if present and context is user-type, then restrict"},{"line_number":268,"context_line":"            query to match the context\u0027s project_id."},{"line_number":269,"context_line":"    \"\"\""},{"line_number":270,"context_line":"    if hasattr(context, \"session\"):"},{"line_number":271,"context_line":"        session \u003d context.session"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    session \u003d kwargs.get(\u0027session\u0027) or get_session()"},{"line_number":274,"context_line":"    read_deleted \u003d kwargs.get(\u0027read_deleted\u0027) or context.read_deleted"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_ea7d7f1c","line":271,"range":{"start_line":270,"start_character":4,"end_line":271,"end_character":33},"in_reply_to":"5f4e5783_f3c6a549","updated":"2017-11-06 08:20:45.000000000","message":"Thanks for the hint :)","commit_id":"8c3761d5bf1d8be6d156933a68a4561b4ad8ab60"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"cf618b4fe2b109d5485901b5a81ea6bb959029fe","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    :param project_only: if present and context is user-type, then restrict"},{"line_number":268,"context_line":"            query to match the context\u0027s project_id."},{"line_number":269,"context_line":"    \"\"\""},{"line_number":270,"context_line":"    if hasattr(context, \"session\"):"},{"line_number":271,"context_line":"        session \u003d context.session"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    session \u003d kwargs.get(\u0027session\u0027) or get_session()"},{"line_number":274,"context_line":"    read_deleted \u003d kwargs.get(\u0027read_deleted\u0027) or context.read_deleted"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_5d0f4d2d","line":271,"range":{"start_line":270,"start_character":4,"end_line":271,"end_character":33},"in_reply_to":"5f4e5783_f3c6a549","updated":"2017-11-06 13:01:53.000000000","message":"actually session may be included in kwargs","commit_id":"8c3761d5bf1d8be6d156933a68a4561b4ad8ab60"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"22af5ed49cb6f17b716eeb2a5dc7dd6f7a3e8cd9","unresolved":false,"context_lines":[{"line_number":3138,"context_line":"    \"\"\"Tests for message operations\"\"\""},{"line_number":3139,"context_line":"    def setUp(self):"},{"line_number":3140,"context_line":"        super(EngineFacadeTestCase, self).setUp()"},{"line_number":3141,"context_line":"        self.user_id \u003d \u0027fake\u0027"},{"line_number":3142,"context_line":"        self.project_id \u003d \u0027fake\u0027"},{"line_number":3143,"context_line":"        self.context \u003d context.RequestContext(self.user_id, self.project_id)"},{"line_number":3144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_75521de0","line":3141,"updated":"2017-11-06 15:30:57.000000000","message":"Should we use UUID-like values here?","commit_id":"b0cb5d9d7f12e6f443c72562ba153426154667be"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"8600a597e1daad973d10aa979413d13f7be6a157","unresolved":false,"context_lines":[{"line_number":3138,"context_line":"    \"\"\"Tests for message operations\"\"\""},{"line_number":3139,"context_line":"    def setUp(self):"},{"line_number":3140,"context_line":"        super(EngineFacadeTestCase, self).setUp()"},{"line_number":3141,"context_line":"        self.user_id \u003d \u0027fake\u0027"},{"line_number":3142,"context_line":"        self.project_id \u003d \u0027fake\u0027"},{"line_number":3143,"context_line":"        self.context \u003d context.RequestContext(self.user_id, self.project_id)"},{"line_number":3144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f485f77_039dce58","line":3141,"in_reply_to":"3f4b6375_75521de0","updated":"2017-11-09 07:06:10.000000000","message":"Thanks e0ne for review! Do you mean use something like fake.USER_ID?","commit_id":"b0cb5d9d7f12e6f443c72562ba153426154667be"}]}
