)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":25376,"name":"zhuangzejian","email":"zzj123389602@gmail.com","username":"smartu3"},"change_message_id":"ef396af7fbad3e0bb2d3cb82d86194dac6b5e1c3","unresolved":false,"context_lines":[{"line_number":709,"context_line":"                        fields.VolumeAttachStatus.DETACHED),"},{"line_number":710,"context_line":"                    \u0027migration_status\u0027: self.AVAILABLE_MIGRATION_STATUS}"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027detaching\u0027}, expected)"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        if not (result or self._is_volume_migrating(volume)):"},{"line_number":715,"context_line":"            msg \u003d _(\"Unable to detach volume. Volume status must be \u0027in-use\u0027 \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_4817f1ee","line":712,"range":{"start_line":712,"start_character":8,"end_line":712,"end_character":77},"updated":"2017-10-23 11:09:30.000000000","message":"When the volume status is available, I don\u0027t know why we still change the volume\u0027s status to \u0027detaching\u0027 in DB.","commit_id":"a636aac02598a8d75163f01a334268aa160b263e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1ff2ae3e6363d2f1827df41d2863e236eea80d09","unresolved":false,"context_lines":[{"line_number":709,"context_line":"                        fields.VolumeAttachStatus.DETACHED),"},{"line_number":710,"context_line":"                    \u0027migration_status\u0027: self.AVAILABLE_MIGRATION_STATUS}"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027detaching\u0027}, expected)"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        if not (result or self._is_volume_migrating(volume)):"},{"line_number":715,"context_line":"            msg \u003d _(\"Unable to detach volume. Volume status must be \u0027in-use\u0027 \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_1fa69554","line":712,"range":{"start_line":712,"start_character":8,"end_line":712,"end_character":77},"in_reply_to":"3f4b6375_4817f1ee","updated":"2017-11-27 20:35:28.000000000","message":"This is to allow it to just go through the normal (noop) flow.","commit_id":"a636aac02598a8d75163f01a334268aa160b263e"},{"author":{"_account_id":25376,"name":"zhuangzejian","email":"zzj123389602@gmail.com","username":"smartu3"},"change_message_id":"ef396af7fbad3e0bb2d3cb82d86194dac6b5e1c3","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027detaching\u0027}, expected)"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        if not (result or self._is_volume_migrating(volume)):"},{"line_number":715,"context_line":"            msg \u003d _(\"Unable to detach volume. Volume status must be \u0027in-use\u0027 \""},{"line_number":716,"context_line":"                    \"and attach_status must be \u0027attached\u0027 to detach.\")"},{"line_number":717,"context_line":"            LOG.error(msg)"},{"line_number":718,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_a2f9e4c8","line":716,"range":{"start_line":715,"start_character":20,"end_line":716,"end_character":70},"updated":"2017-10-23 11:09:30.000000000","message":"And if we change the expected status, this message should also be modified.","commit_id":"a636aac02598a8d75163f01a334268aa160b263e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1ff2ae3e6363d2f1827df41d2863e236eea80d09","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027detaching\u0027}, expected)"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        if not (result or self._is_volume_migrating(volume)):"},{"line_number":715,"context_line":"            msg \u003d _(\"Unable to detach volume. Volume status must be \u0027in-use\u0027 \""},{"line_number":716,"context_line":"                    \"and attach_status must be \u0027attached\u0027 to detach.\")"},{"line_number":717,"context_line":"            LOG.error(msg)"},{"line_number":718,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_7f6a41ed","line":716,"range":{"start_line":715,"start_character":20,"end_line":716,"end_character":70},"in_reply_to":"3f4b6375_a2f9e4c8","updated":"2017-11-27 20:35:28.000000000","message":"I think we still want to official state only in-use, just be more flexible for the windows where something could go wrong.","commit_id":"a636aac02598a8d75163f01a334268aa160b263e"}]}