)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e6937a5da64cfb85216f062d29a4fa769e9da3ea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Cates \u003cjccates@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-11 16:58:50 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Permit clone and snapshot restore to oversized destination volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Permit clone volumes and volumes created from snapshots to be larger than their"},{"line_number":10,"context_line":"source volumes; implemented in response to failures in the following CI tests:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_efc0082d","line":7,"updated":"2017-10-11 22:21:02.000000000","message":"Could you change this to indicate it is specifically for FlashSystem? Maybe something like:\n\nFlashSystem: Permit clone or snapshot to larger size\n\nAlso would be good to add the line:\n\nCloses-bug: #1560655","commit_id":"83211b39247ce771cb9df2e4f9fedf9173fef27b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c5f7b54e0e6c3367f1ef840118dfe9a1414a76cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Cates \u003cjccates@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-11 16:58:50 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Permit clone and snapshot restore to oversized destination volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Permit clone volumes and volumes created from snapshots to be larger than their"},{"line_number":10,"context_line":"source volumes; implemented in response to failures in the following CI tests:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_059a256d","line":7,"in_reply_to":"5f4e5783_8a73c2b1","updated":"2017-10-12 00:02:22.000000000","message":"Oh weird, I totally did not see that on there. Nope, just ignore that bug part.","commit_id":"83211b39247ce771cb9df2e4f9fedf9173fef27b"},{"author":{"_account_id":27059,"name":"John Cates","email":"jccates@us.ibm.com","username":"jccates"},"change_message_id":"f2277fc9834016463d9f10c35883ac2251313f4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Cates \u003cjccates@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-11 16:58:50 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Permit clone and snapshot restore to oversized destination volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Permit clone volumes and volumes created from snapshots to be larger than their"},{"line_number":10,"context_line":"source volumes; implemented in response to failures in the following CI tests:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_8a73c2b1","line":7,"in_reply_to":"5f4e5783_efc0082d","updated":"2017-10-11 22:53:29.000000000","message":"Sure; I can add the FlashSystem prefix. Closes-Bug is already at the end of the message per examples in the developer manual:\n\nhttps://docs.openstack.org/infra/manual/developers.html#development-workflow\n\nI can move it up if you want.","commit_id":"83211b39247ce771cb9df2e4f9fedf9173fef27b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2ec031ceddecdb7de9ee449089f0200ce6f2dc47","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Cates \u003cjccates@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-12 11:29:21 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"FlashSystems: Permit clone and snapshot restore to larger size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Permit clone volumes and volumes created from snapshots to be larger than their"},{"line_number":10,"context_line":"source volumes; implemented in response to failures in the following CI tests:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f4e5783_a55a1a4c","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":47},"updated":"2017-10-12 17:02:01.000000000","message":"If you need to do another update, remove \"restore\" as nothing is being restored here.","commit_id":"c8e4705018c7b1b4c9fe26e5105bdcc6b93490e1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d16caadaf855e31a21da9b210a00b9018a258166","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Cates \u003cjccates@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-12 11:29:21 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"FlashSystems: Permit clone and snapshot restore to larger size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Permit clone volumes and volumes created from snapshots to be larger than their"},{"line_number":10,"context_line":"source volumes; implemented in response to failures in the following CI tests:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f4e5783_a6e580aa","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":47},"in_reply_to":"5f4e5783_46e12cd0","updated":"2017-10-12 18:53:36.000000000","message":"Hmm, maybe /snapshot/volume from snapshot/ ?\n\nNot a big deal really, so no worries.","commit_id":"c8e4705018c7b1b4c9fe26e5105bdcc6b93490e1"},{"author":{"_account_id":27059,"name":"John Cates","email":"jccates@us.ibm.com","username":"jccates"},"change_message_id":"b3798e09901f73a8f9468cba69fd24967e897f9f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Cates \u003cjccates@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-12 11:29:21 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"FlashSystems: Permit clone and snapshot restore to larger size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Permit clone volumes and volumes created from snapshots to be larger than their"},{"line_number":10,"context_line":"source volumes; implemented in response to failures in the following CI tests:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f4e5783_46e12cd0","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":47},"in_reply_to":"5f4e5783_a55a1a4c","updated":"2017-10-12 18:42:50.000000000","message":"Oh yeah, I guess \u0027restore\u0027 is inaccurate since we\u0027re creating a new volume, not reverting the original volume to the state recorded in the snapshot. I didn\u0027t want to use just \u0027snapshot\u0027, since that sounds like the commit has something to do with snapshot creation. Is there a term for the process of creating a volume from a snapshot?","commit_id":"c8e4705018c7b1b4c9fe26e5105bdcc6b93490e1"}],"cinder/volume/drivers/ibm/flashsystem_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e6937a5da64cfb85216f062d29a4fa769e9da3ea","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"            LOG.error(msg)"},{"line_number":1136,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        self._create_and_copy_vdisk_data(src_volume[\u0027name\u0027],"},{"line_number":1139,"context_line":"                                         src_volume[\u0027id\u0027],"},{"line_number":1140,"context_line":"                                         volume[\u0027name\u0027],"},{"line_number":1141,"context_line":"                                         volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_2fcce05f","line":1138,"updated":"2017-10-11 22:21:02.000000000","message":"I don\u0027t see where it is picking up the new size for either of these.","commit_id":"83211b39247ce771cb9df2e4f9fedf9173fef27b"},{"author":{"_account_id":27059,"name":"John Cates","email":"jccates@us.ibm.com","username":"jccates"},"change_message_id":"f2277fc9834016463d9f10c35883ac2251313f4d","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"            LOG.error(msg)"},{"line_number":1136,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        self._create_and_copy_vdisk_data(src_volume[\u0027name\u0027],"},{"line_number":1139,"context_line":"                                         src_volume[\u0027id\u0027],"},{"line_number":1140,"context_line":"                                         volume[\u0027name\u0027],"},{"line_number":1141,"context_line":"                                         volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_4a3caabe","line":1138,"in_reply_to":"5f4e5783_2fcce05f","updated":"2017-10-11 22:53:29.000000000","message":"Ah, right, it\u0027s just using source volume size. Sorry about that; I assumed they\u0027d do as the volume metadata says. I\u0027ll add a keyword for destination volume size to keep things non-invasive.","commit_id":"83211b39247ce771cb9df2e4f9fedf9173fef27b"}]}