)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/unity/test_client.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"189e39b5aab17c97582b2ddbe06f4e0164317caa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"from cinder import coordination"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import unittest"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_c04f9190","line":15,"updated":"2017-10-29 21:10:53.000000000","message":"Local cinder imports need to be below with the other local imports.","commit_id":"b3a0086754cca3d03dd7545840f661a7ea040649"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"cbe0f75f117a8797eaf03ac583c668ddccfb7796","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"from cinder import coordination"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import unittest"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_e2728d49","line":15,"in_reply_to":"3f4b6375_c04f9190","updated":"2017-10-31 02:04:55.000000000","message":"Will do","commit_id":"b3a0086754cca3d03dd7545840f661a7ea040649"}],"cinder/volume/drivers/dell_emc/unity/client.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a012472dd9023501c74015952fa768b3ac54650","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                        {\u0027name\u0027: name, \u0027err\u0027: err})"},{"line_number":187,"context_line":"        return None"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @coordination.synchronized(\u0027{self.host}-{name}\u0027)"},{"line_number":190,"context_line":"    def get_host(self, name):"},{"line_number":191,"context_line":"        \"\"\"Provides host object if exists else None.\"\"\""},{"line_number":192,"context_line":"        if name not in self.host_cache:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_a2179951","line":189,"updated":"2017-10-23 16:10:48.000000000","message":"Synchronization on \u0027get_\u0027 method looks strange. Looking throw the code, there is a \u0027create\u0027 call. I think it would be better to rename this  method","commit_id":"ad3cd9324aca401d0536e7cae1b827d2ce8c6a9f"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"b0a56e5217ce09a7633bee2f1567967b8c5b9334","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                        {\u0027name\u0027: name, \u0027err\u0027: err})"},{"line_number":187,"context_line":"        return None"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @coordination.synchronized(\u0027{self.host}-{name}\u0027)"},{"line_number":190,"context_line":"    def get_host(self, name):"},{"line_number":191,"context_line":"        \"\"\"Provides host object if exists else None.\"\"\""},{"line_number":192,"context_line":"        if name not in self.host_cache:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_1b9dacbb","line":189,"in_reply_to":"3f4b6375_a2179951","updated":"2017-10-24 01:49:34.000000000","message":"Renamed to \u0027create_host\u0027","commit_id":"ad3cd9324aca401d0536e7cae1b827d2ce8c6a9f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a012472dd9023501c74015952fa768b3ac54650","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @coordination.synchronized(\u0027{self.host}-{name}\u0027)"},{"line_number":190,"context_line":"    def get_host(self, name):"},{"line_number":191,"context_line":"        \"\"\"Provides host object if exists else None.\"\"\""},{"line_number":192,"context_line":"        if name not in self.host_cache:"},{"line_number":193,"context_line":"            try:"},{"line_number":194,"context_line":"                host \u003d self.system.get_host(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_3d1d0a66","line":191,"updated":"2017-10-23 16:10:48.000000000","message":"In which case will it return None? Looks like docstring is incorrect here","commit_id":"ad3cd9324aca401d0536e7cae1b827d2ce8c6a9f"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"b0a56e5217ce09a7633bee2f1567967b8c5b9334","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @coordination.synchronized(\u0027{self.host}-{name}\u0027)"},{"line_number":190,"context_line":"    def get_host(self, name):"},{"line_number":191,"context_line":"        \"\"\"Provides host object if exists else None.\"\"\""},{"line_number":192,"context_line":"        if name not in self.host_cache:"},{"line_number":193,"context_line":"            try:"},{"line_number":194,"context_line":"                host \u003d self.system.get_host(name\u003dname)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_fba1b0f9","line":191,"in_reply_to":"3f4b6375_3d1d0a66","updated":"2017-10-24 01:49:34.000000000","message":"This method always returns a host, Need to update it.","commit_id":"ad3cd9324aca401d0536e7cae1b827d2ce8c6a9f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3a012472dd9023501c74015952fa768b3ac54650","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                    # This make concurrent modification of"},{"line_number":215,"context_line":"                    # host initiators safe"},{"line_number":216,"context_line":"                    LOG.debug("},{"line_number":217,"context_line":"                        \u0027The uid({}) was already in \u0027"},{"line_number":218,"context_line":"                        \u0027{}.\u0027.format(uid, host.name))"},{"line_number":219,"context_line":"            host.update()"},{"line_number":220,"context_line":"            # Update host cached with new initiators."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_7d3ca2c7","line":217,"updated":"2017-10-23 16:10:48.000000000","message":"Please, change to:\nLOG.debug(\u0027The uid({0}) was already in {1]\u0027, uid, host.name)","commit_id":"ad3cd9324aca401d0536e7cae1b827d2ce8c6a9f"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"b0a56e5217ce09a7633bee2f1567967b8c5b9334","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                    # This make concurrent modification of"},{"line_number":215,"context_line":"                    # host initiators safe"},{"line_number":216,"context_line":"                    LOG.debug("},{"line_number":217,"context_line":"                        \u0027The uid({}) was already in \u0027"},{"line_number":218,"context_line":"                        \u0027{}.\u0027.format(uid, host.name))"},{"line_number":219,"context_line":"            host.update()"},{"line_number":220,"context_line":"            # Update host cached with new initiators."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_7badc0e7","line":217,"in_reply_to":"3f4b6375_7d3ca2c7","updated":"2017-10-24 01:49:34.000000000","message":"Done","commit_id":"ad3cd9324aca401d0536e7cae1b827d2ce8c6a9f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"189e39b5aab17c97582b2ddbe06f4e0164317caa","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                    # This make concurrent modification of"},{"line_number":215,"context_line":"                    # host initiators safe"},{"line_number":216,"context_line":"                    LOG.debug("},{"line_number":217,"context_line":"                        \u0027The uid({0}) was already in \u0027"},{"line_number":218,"context_line":"                        \u0027{1}.\u0027, uid, host.name)"},{"line_number":219,"context_line":"            host.update()"},{"line_number":220,"context_line":"            # Update host cached with new initiators."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_605e9d46","line":217,"range":{"start_line":217,"start_character":33,"end_line":217,"end_character":36},"updated":"2017-10-29 21:10:53.000000000","message":"You can\u0027t use new style formatting in logger calls.","commit_id":"b3a0086754cca3d03dd7545840f661a7ea040649"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"cbe0f75f117a8797eaf03ac583c668ddccfb7796","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                    # This make concurrent modification of"},{"line_number":215,"context_line":"                    # host initiators safe"},{"line_number":216,"context_line":"                    LOG.debug("},{"line_number":217,"context_line":"                        \u0027The uid({0}) was already in \u0027"},{"line_number":218,"context_line":"                        \u0027{1}.\u0027, uid, host.name)"},{"line_number":219,"context_line":"            host.update()"},{"line_number":220,"context_line":"            # Update host cached with new initiators."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_f058f7fa","line":217,"range":{"start_line":217,"start_character":33,"end_line":217,"end_character":36},"in_reply_to":"3f4b6375_605e9d46","updated":"2017-10-31 02:04:55.000000000","message":"This styling is suggested by Ivan, and looks like, the logger config supports this technically.\nCould you please kindly point me the violation here:)?\n\nThanks\nPeter","commit_id":"b3a0086754cca3d03dd7545840f661a7ea040649"}]}