)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_iscsi.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ba88643ed1c32cb24647fa2e638204863e25e2ea","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":126,"context_line":"        if self._get_volume_replicated_type(ctxt, None,"},{"line_number":127,"context_line":"                                            snapshot.volume_type_id):"},{"line_number":128,"context_line":"            LOG.warning(\u0027It is a replication volume snapshot for backup\u0027)"},{"line_number":129,"context_line":"            rep_volume \u003d objects.Volume.get_by_id(ctxt, snapshot.volume_id)"},{"line_number":130,"context_line":"            volume_name, backend_helper, node_state \u003d self._get_vol_sys_info("},{"line_number":131,"context_line":"                rep_volume)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_15499ab5","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":73},"updated":"2017-10-26 19:17:53.000000000","message":"A warning here implies that an admin should read this message and take some action -- what does it mean?  What should they do?  Why is it important to warn about this?","commit_id":"16c1f6d9a108a232e033f5bd8b764c210b1b1930"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"0452547a1ef0e8c4dabc4242376067815d5811ab","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":126,"context_line":"        if self._get_volume_replicated_type(ctxt, None,"},{"line_number":127,"context_line":"                                            snapshot.volume_type_id):"},{"line_number":128,"context_line":"            LOG.warning(\u0027It is a replication volume snapshot for backup\u0027)"},{"line_number":129,"context_line":"            rep_volume \u003d objects.Volume.get_by_id(ctxt, snapshot.volume_id)"},{"line_number":130,"context_line":"            volume_name, backend_helper, node_state \u003d self._get_vol_sys_info("},{"line_number":131,"context_line":"                rep_volume)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_18af872a","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":73},"in_reply_to":"3f4b6375_15499ab5","updated":"2017-10-27 08:04:56.000000000","message":"Hi Eric, thank you very much for your comment. A debug is enough here, I have modified it to \u0027LOG.debug\u0027 in the new patch.","commit_id":"16c1f6d9a108a232e033f5bd8b764c210b1b1930"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"206e92d5b212d11bb4eed028cb819e134ae7b08a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            raise exception.InvalidConnectorException("},{"line_number":118,"context_line":"                missing\u003d\u0027initiator\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def initialize_connection_snapshot(self, snapshot, connector):"},{"line_number":121,"context_line":"        \"\"\"Perform attach snapshot for backup snapshots.\"\"\""},{"line_number":122,"context_line":"        # If the snapshot\u0027s source volume is a replication volume and the"},{"line_number":123,"context_line":"        # replication volume has failed over to aux_backend,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_e0184d85","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":38},"updated":"2017-10-29 21:17:48.000000000","message":"This looks identical in both drivers. Shouldn\u0027t this be in the common code so they both just use the same implementation?","commit_id":"67e2d9bf600a712f4862221ea0409c2d01d04cac"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"0fd7cddf8318d6b204b39c6001c563a0f23bd81f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            raise exception.InvalidConnectorException("},{"line_number":118,"context_line":"                missing\u003d\u0027initiator\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def initialize_connection_snapshot(self, snapshot, connector):"},{"line_number":121,"context_line":"        \"\"\"Perform attach snapshot for backup snapshots.\"\"\""},{"line_number":122,"context_line":"        # If the snapshot\u0027s source volume is a replication volume and the"},{"line_number":123,"context_line":"        # replication volume has failed over to aux_backend,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_2c689e1f","line":120,"range":{"start_line":120,"start_character":8,"end_line":120,"end_character":38},"in_reply_to":"3f4b6375_e0184d85","updated":"2017-10-30 03:21:05.000000000","message":"Hi Sean, thank you very much for your comment, it is addressed in the new patch.","commit_id":"67e2d9bf600a712f4862221ea0409c2d01d04cac"}]}