)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bad1cf21a18b74e85f62346d104b922453799430","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Laura Sofia Enriquez \u003clsofia.enriquez@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-24 15:33:37 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding unit test coverage to flow"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We\u0027re almost missing unit tests for manage_existing functionality. The"},{"line_number":10,"context_line":"cinder.volume.flows.manager.manage_existing module has only ~37% of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_c0b9287c","line":7,"updated":"2018-10-25 12:30:55.000000000","message":"If you do an update, please change this to something like:\n\nAdd test coverage to manage existing flow","commit_id":"35fd950a98da94fcb97998a77e7c176bdfffcb7a"}],"cinder/tests/unit/volume/flows/test_manage_snapshot_flow.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bad1cf21a18b74e85f62346d104b922453799430","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            task.execute(self.ctxt, fake_snap, manage_existing_ref, real_size)"},{"line_number":73,"context_line":"        except exception.SnapshotNotFound as e:"},{"line_number":74,"context_line":"            self.assertEqual(expected_error, e.msg)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @mock.patch(\u0027cinder.quota.QuotaEngine.reserve\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_a042ec65","line":73,"updated":"2018-10-25 12:30:55.000000000","message":"Usually not a good pattern to have try/except blocks in unit tests, and I really rather not assert on specific error text.\n\nI think this would be better to change this whole block to:\n\nself.assertRaises(exception.SnapshotNotFound,\n                  task.execute,\n                  self.ctxt,\n                  fake_snap,\n                  manage_existing_ref,\n                  real_size)","commit_id":"35fd950a98da94fcb97998a77e7c176bdfffcb7a"}],"cinder/tests/unit/volume/flows/test_manage_volume_flow.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bad1cf21a18b74e85f62346d104b922453799430","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def _fake_custom_exception(self, *args, **kwargs):"},{"line_number":45,"context_line":"        raise exception.CinderException"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _fake_exception(self, *args, **kwargs):"},{"line_number":48,"context_line":"        raise Exception"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_cast_manage_existing(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_e01a247a","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":23},"updated":"2018-10-25 12:30:55.000000000","message":"Is there a reason we need this instead of just setting side_effect \u003d Exception?","commit_id":"35fd950a98da94fcb97998a77e7c176bdfffcb7a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bad1cf21a18b74e85f62346d104b922453799430","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        reason \u003d \u0027Volume driver MagicMock get exception.\u0027"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            task \u003d manager.PrepareForQuotaReservationTask(mock_db, mock_driver)"},{"line_number":156,"context_line":"            task.execute(self.ctxt, wrong_volume, mock_manage_existing_ref)"},{"line_number":157,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_20233cbd","line":154,"updated":"2018-10-25 12:30:55.000000000","message":"Same comment as other file about try/except in a unit test.","commit_id":"35fd950a98da94fcb97998a77e7c176bdfffcb7a"}]}