)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"81f6f066a0cc85ec35551a9f39aabfcaa89b636c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Sharma \u003cabmsharm@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-25 21:16:11 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding path exists check before trying to delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem here is sometimes when the path doesn\u0027t exist and we"},{"line_number":10,"context_line":"try to delete it then exception occurs \u0026 breaks the flow. In this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4b6375_6e200ef8","line":7,"updated":"2017-10-26 11:59:26.000000000","message":"Sorry, didn\u0027t notice before, but this commit message is no longer accurate too.","commit_id":"aece2bda343a34960fac8b7123ebae41274cea70"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"59f83cc9e1733964957acd2adfc77c5535968d04","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Sharma \u003cabmsharm@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-26 09:38:40 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Catching the exception when trying to delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem here is sometimes when the path doesn\u0027t exist and we"},{"line_number":10,"context_line":"try to delete it then exception occurs \u0026 breaks the flow. In this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f4b6375_20aa1e18","line":7,"updated":"2017-10-26 14:42:53.000000000","message":"How about something like:\n\nDon\u0027t fail when deleting missing backup","commit_id":"0cc1fb18a1e18277e043ea9ce4d2ae09eb8b077e"}],"cinder/backup/drivers/posix.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f9e44881fbd84d50b1f6ffd46294db329edf9779","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def delete_object(self, container, object_name):"},{"line_number":128,"context_line":"        # TODO(tbarron):  clean up the container path if it is empty"},{"line_number":129,"context_line":"        path \u003d os.path.join(self.backup_path, container, object_name)"},{"line_number":130,"context_line":"        if os.path.exists(path):"},{"line_number":131,"context_line":"            os.remove(path)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _generate_object_name_prefix(self, backup):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_450f8f36","line":130,"updated":"2017-10-25 14:10:43.000000000","message":"There\u0027s still a very small possibility that the file goes away between the check for existence and the remove call.\n\nIt would be more pythonic to just try the delete and catch and swallow the exception if it happens.","commit_id":"d4bd59bdcd31f46ddca751698cb019a2de5f34ad"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bfb926e301d556759fd98fc38a7daf74cf56f7bc","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            os.remove(path)"},{"line_number":132,"context_line":"        except OSError:"},{"line_number":133,"context_line":"            LOG.exception(\"Path %s doesn\u0027t exist\", path)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _generate_object_name_prefix(self, backup):"},{"line_number":136,"context_line":"        timestamp \u003d timeutils.utcnow().strftime(\"%Y%m%d%H%M%S\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_43053d10","line":133,"updated":"2017-10-25 20:53:37.000000000","message":"Since we are trying to get rid of a file and the file is gone, I don\u0027t think we should be logging at this level, if at all.\n\nIt should either be debug level, or just a pass. My preference would be pass.","commit_id":"fcf8aa76753422a22b4595e5471971355acacb61"},{"author":{"_account_id":24131,"name":"Abhishek Sharma M","email":"abmsharm@in.ibm.com","username":"abhi.sharma"},"change_message_id":"1ac6e1066c6b03fca016a47751c642e2436a5e92","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            os.remove(path)"},{"line_number":132,"context_line":"        except OSError:"},{"line_number":133,"context_line":"            LOG.exception(\"Path %s doesn\u0027t exist\", path)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _generate_object_name_prefix(self, backup):"},{"line_number":136,"context_line":"        timestamp \u003d timeutils.utcnow().strftime(\"%Y%m%d%H%M%S\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_b206751f","line":133,"in_reply_to":"3f4b6375_43053d10","updated":"2017-10-26 14:25:24.000000000","message":"I agree on having a \u0027pass\u0027. With this I don\u0027t think we require the \u0027test_delete_nonexistent_object\u0027 TC.","commit_id":"fcf8aa76753422a22b4595e5471971355acacb61"}]}