)]}'
{"cinder/volume/drivers/dell_emc/xtremio.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4064f3a288d0ff24964e064558c9ef21fed9feaa","unresolved":false,"context_lines":[{"line_number":76,"context_line":"               help\u003d\u0027Number of volumes created from each cached glance image\u0027),"},{"line_number":77,"context_line":"    cfg.BoolOpt(\u0027xtremio_clean_unused_ig\u0027,"},{"line_number":78,"context_line":"                default\u003dFalse,"},{"line_number":79,"context_line":"                help\u003d\u0027should the driver remove the IG after the last volume \u0027"},{"line_number":80,"context_line":"                     \u0027was unmmaped\u0027)]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"CONF.register_opts(XTREMIO_OPTS, group\u003dconfiguration.SHARED_CONF_GROUP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_9320d19d","line":79,"range":{"start_line":79,"start_character":22,"end_line":79,"end_character":23},"updated":"2017-10-29 21:26:56.000000000","message":"S","commit_id":"d9f94569abe7ee1d6eb39b64bdb301db1b29a31a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e64b73e5e81a0743b8725e9858dc9b5210d79513","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    cfg.BoolOpt(\u0027xtremio_clean_unused_ig\u0027,"},{"line_number":78,"context_line":"                default\u003dFalse,"},{"line_number":79,"context_line":"                help\u003d\u0027Should the driver remove the IG after the last volume \u0027"},{"line_number":80,"context_line":"                     \u0027was unmmaped\u0027)]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"CONF.register_opts(XTREMIO_OPTS, group\u003dconfiguration.SHARED_CONF_GROUP)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_e1637adc","line":80,"updated":"2017-10-31 16:26:26.000000000","message":"How does a deployer decide whether this should be True or False?  It doesn\u0027t sound like \"False\" is ever the desired behavior here.\n\nI think this needs more explanation in the commit message.","commit_id":"e0585e215fe4ddc0f468e80a85bf11e73994e49f"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"76135799ba3fc45a58ae0c11437265d575e3bd0f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    cfg.BoolOpt(\u0027xtremio_clean_unused_ig\u0027,"},{"line_number":78,"context_line":"                default\u003dFalse,"},{"line_number":79,"context_line":"                help\u003d\u0027Should the driver remove the IG after the last volume \u0027"},{"line_number":80,"context_line":"                     \u0027was unmmaped\u0027)]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"CONF.register_opts(XTREMIO_OPTS, group\u003dconfiguration.SHARED_CONF_GROUP)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_82e148ff","line":80,"in_reply_to":"3f4b6375_e1637adc","updated":"2017-11-01 15:45:21.000000000","message":"Done\ntried my best to be as verbal as posible","commit_id":"e0585e215fe4ddc0f468e80a85bf11e73994e49f"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"e2d49d9ea054a6d9b59858ce47adc2d41eb0902f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"               help\u003d\u0027Number of volumes created from each cached glance image\u0027),"},{"line_number":77,"context_line":"    cfg.BoolOpt(\u0027xtremio_clean_unused_ig\u0027,"},{"line_number":78,"context_line":"                default\u003dFalse,"},{"line_number":79,"context_line":"                help\u003d\u0027Should the driver remove IGs with no volumes after the \u0027"},{"line_number":80,"context_line":"                     \u0027last connection was terminated. \u0027"},{"line_number":81,"context_line":"                     \u0027Since the behavior till now was to leave \u0027"},{"line_number":82,"context_line":"                     \u0027the IG be, we default to False (not deleting IGs \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_b7af2993","line":79,"updated":"2017-11-20 20:51:38.000000000","message":"Would be good to mention at least somewhere in the description what ig stands for.","commit_id":"23d4da234e0188b7b82312a34cf15f2b60d4b3b2"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"b1ddbce1c0da43c41762fdfaf07b4f3085ad7176","unresolved":false,"context_lines":[{"line_number":76,"context_line":"               help\u003d\u0027Number of volumes created from each cached glance image\u0027),"},{"line_number":77,"context_line":"    cfg.BoolOpt(\u0027xtremio_clean_unused_ig\u0027,"},{"line_number":78,"context_line":"                default\u003dFalse,"},{"line_number":79,"context_line":"                help\u003d\u0027Should the driver remove IGs with no volumes after the \u0027"},{"line_number":80,"context_line":"                     \u0027last connection was terminated. \u0027"},{"line_number":81,"context_line":"                     \u0027Since the behavior till now was to leave \u0027"},{"line_number":82,"context_line":"                     \u0027the IG be, we default to False (not deleting IGs \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_4825f3aa","line":79,"in_reply_to":"ff82abbf_b7af2993","updated":"2017-11-30 10:42:07.000000000","message":"Done","commit_id":"23d4da234e0188b7b82312a34cf15f2b60d4b3b2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7439f69f54ff0d8fa9e6727ac18f1864d330bc1e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                     \u0027the IG be, we default to False (not deleting IGs \u0027"},{"line_number":83,"context_line":"                     \u0027without connected volumes); setting this parameter \u0027"},{"line_number":84,"context_line":"                     \u0027to True will remove any IG after terminating its \u0027"},{"line_number":85,"context_line":"                     \u0027 connection to the last volume.\u0027)]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"CONF.register_opts(XTREMIO_OPTS, group\u003dconfiguration.SHARED_CONF_GROUP)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_16f5cc83","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":23},"updated":"2017-11-30 12:55:39.000000000","message":"Extra leading space.","commit_id":"8a97545bbe2e23664ce48935f86749343a0be5b2"},{"author":{"_account_id":18529,"name":"Dongdong Pei","email":"peidongdong121@163.com","username":"dongdongpei"},"change_message_id":"1b6f0bffb17e324fd101cbc704a3b27a93742afd","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                LOG.warning(\"terminate_connection: lun map not found\")"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        if self.clean_ig:"},{"line_number":725,"context_line":"            for idx in ig_indexes:"},{"line_number":726,"context_line":"                try:"},{"line_number":727,"context_line":"                    ig \u003d self.client.req(\u0027initiator-groups\u0027, \u0027GET\u0027,"},{"line_number":728,"context_line":"                                         {\u0027prop\u0027: \u0027num-of-vols\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_175c1feb","line":725,"updated":"2017-12-11 06:38:31.000000000","message":"LGTM. It\u0027 better to change idx to ig_idx in line 725, or change ig_idx to idx in line 714 for better reading.","commit_id":"b2c35cbffd95699a1a9c9d1599803f1ec7994352"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"2fefdeabed54b767f219610308aa474dc2a3dbfa","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                LOG.warning(\"terminate_connection: lun map not found\")"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        if self.clean_ig:"},{"line_number":725,"context_line":"            for idx in ig_indexes:"},{"line_number":726,"context_line":"                try:"},{"line_number":727,"context_line":"                    ig \u003d self.client.req(\u0027initiator-groups\u0027, \u0027GET\u0027,"},{"line_number":728,"context_line":"                                         {\u0027prop\u0027: \u0027num-of-vols\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_1762ded8","line":725,"in_reply_to":"df87a7cf_175c1feb","updated":"2017-12-11 07:24:15.000000000","message":"as this is local to the loop 6 lines I don\u0027t see the need","commit_id":"b2c35cbffd95699a1a9c9d1599803f1ec7994352"}],"releasenotes/notes/xtremio-ig-cleanup-bbb4bee1f1e3611c.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a74625a28d357c31b13221d1d5ca311ca37752e9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    detached from them."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    this feature address https://bugs.launchpad.net/cinder/+bug/1723430"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df87a7cf_47cf077f","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":16},"updated":"2017-12-03 17:13:51.000000000","message":"What feature?\n\nSince this is really new functionality, I think you can remove the fixes section. Otherwise, add more notes to the fixes item (and fix capitalization) so it makes sense.","commit_id":"ee90f7797b830f4cffbec96262122fbc8d8cadd1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c14f70a015452afaae4190d8c1b387bf6a319367","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New option to delete XtremIO initiator groups after the last volume was"},{"line_number":5,"context_line":"    detached from them."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df87a7cf_0e6d8503","line":5,"updated":"2017-12-04 15:40:38.000000000","message":"Might be good to state that option name in the release note to make it easier for those interested in finding it.","commit_id":"f220209beee6bc3cb6f65416fd792e52cf7d797a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"c827e03e8e06120bfc11688820e0fc0fea210882","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New option to delete XtremIO initiator groups after the last volume was"},{"line_number":5,"context_line":"    detached from them."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df87a7cf_f10fe62b","line":5,"in_reply_to":"df87a7cf_0e6d8503","updated":"2017-12-04 15:45:54.000000000","message":"+1","commit_id":"f220209beee6bc3cb6f65416fd792e52cf7d797a"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"0b7a570064a86a940197b205fdcab458c1dcdaff","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New option to delete XtremIO initiator groups after the last volume was"},{"line_number":5,"context_line":"    detached from them."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df87a7cf_f7ed5f8b","line":5,"in_reply_to":"df87a7cf_f10fe62b","updated":"2017-12-06 11:12:44.000000000","message":"Done","commit_id":"f220209beee6bc3cb6f65416fd792e52cf7d797a"}]}