)]}'
{"cinder/volume/drivers/disco/disco_attach_detach.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"3b8d008ac34edc7d41c5c3af2b70ccd06e67f90c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def __init__(self, configuration):"},{"line_number":31,"context_line":"        \"\"\"Init volume attachment class.\"\"\""},{"line_number":32,"context_line":"        self.configuration \u003d configuration"},{"line_number":33,"context_line":"        self.connector \u003d connector.InitiatorConnector.factory("},{"line_number":34,"context_line":"            self._get_connector_identifier(), utils.get_root_helper(),"},{"line_number":35,"context_line":"            device_scan_attempts\u003d("},{"line_number":36,"context_line":"                self.configuration.num_volume_device_scan_tries)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_828199c6","line":33,"range":{"start_line":33,"start_character":25,"end_line":33,"end_character":34},"updated":"2017-10-30 06:36:15.000000000","message":"initiator","commit_id":"66cea946342d06afec5042151f1978e458478b4f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fd55c38f73380d490e7291c25e4a44682f6ffae2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return connection_properties"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_connector_identifier(self):"},{"line_number":57,"context_line":"        \"\"\"Return connector identifier, put here to mock it in unit tests.\"\"\""},{"line_number":58,"context_line":"        return initiator.DISCO"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _attach_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_6108aa90","line":57,"range":{"start_line":57,"start_character":40,"end_line":57,"end_character":73},"updated":"2017-10-31 16:41:27.000000000","message":"If this method was also unit tested, it would catch this issue...","commit_id":"e901221ee4a31e519b40824839b9346f24435831"},{"author":{"_account_id":19576,"name":"Guy Kim","email":"guy.kim088@gmail.com","username":"Guy"},"change_message_id":"d911dca31b1bc7a60e86c6ebb9dd055575ea2f0b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return connection_properties"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_connector_identifier(self):"},{"line_number":57,"context_line":"        \"\"\"Return connector identifier, put here to mock it in unit tests.\"\"\""},{"line_number":58,"context_line":"        return initiator.DISCO"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _attach_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_195f2242","line":57,"range":{"start_line":57,"start_character":40,"end_line":57,"end_character":73},"in_reply_to":"3f4b6375_6108aa90","updated":"2017-11-01 02:03:41.000000000","message":"In the unit test, the constant connector is harcoded with the value \u0027DISCO\u0027 directly (https://github.com/openstack/cinder/blob/master/cinder/tests/unit/volume/drivers/disco/__init__.py#L103). So it doesn\u0027t catch this issue.","commit_id":"e901221ee4a31e519b40824839b9346f24435831"}]}