)]}'
{"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":25648,"name":"wang yong","email":"yongwc@foxmail.com","username":"wangyong"},"change_message_id":"d5b66dab0de2975ac263982139f4229ab07ceeea","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        try:"},{"line_number":431,"context_line":"            model_update \u003d self.driver.create_volume_from_snapshot(volume,"},{"line_number":432,"context_line":"                                                                   snapshot)"},{"line_number":433,"context_line":"        except exception.CinderException:"},{"line_number":434,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":435,"context_line":"                self._cleanup_cg_in_volume(volume)"},{"line_number":436,"context_line":"        self._cleanup_cg_in_volume(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_b756b2cd","line":433,"updated":"2017-11-02 03:42:00.000000000","message":"Maybe it will be better if we use try ... finally ... here and the follows.","commit_id":"ccd102849756da3db95966500cd0da91f250ce22"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"69859c7f787ec02478698640c4d1d208c6a98a21","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        try:"},{"line_number":431,"context_line":"            model_update \u003d self.driver.create_volume_from_snapshot(volume,"},{"line_number":432,"context_line":"                                                                   snapshot)"},{"line_number":433,"context_line":"        except exception.CinderException:"},{"line_number":434,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":435,"context_line":"                self._cleanup_cg_in_volume(volume)"},{"line_number":436,"context_line":"        self._cleanup_cg_in_volume(volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_039c28be","line":433,"in_reply_to":"3f4b6375_b756b2cd","updated":"2017-11-02 07:33:02.000000000","message":"Hi wangyong, thank you very much for your comment , It is addressed in the new patch","commit_id":"ccd102849756da3db95966500cd0da91f250ce22"}]}