)]}'
{"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9debef62b89083754e94dd5d30828fe7ecf76a2d","unresolved":false,"context_lines":[{"line_number":2762,"context_line":"        \"\"\"Extend a replication-enabled volume."},{"line_number":2763,"context_line":""},{"line_number":2764,"context_line":"        Cannot extend volumes in a synchronization pair. Must first break the"},{"line_number":2765,"context_line":"        relationship, extend them separately, then recreate the pair"},{"line_number":2766,"context_line":"        :param array: the array serial number"},{"line_number":2767,"context_line":"        :param volume: the volume objcet"},{"line_number":2768,"context_line":"        :param device_id: the volume device id"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_f11868d3","line":2765,"updated":"2017-11-06 11:03:55.000000000","message":"Update to include note on ode.  Thanks","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1e26fdf293fee9b010b998a4a9d4a336411d84cf","unresolved":false,"context_lines":[{"line_number":2762,"context_line":"        \"\"\"Extend a replication-enabled volume."},{"line_number":2763,"context_line":""},{"line_number":2764,"context_line":"        Cannot extend volumes in a synchronization pair. Must first break the"},{"line_number":2765,"context_line":"        relationship, extend them separately, then recreate the pair"},{"line_number":2766,"context_line":"        :param array: the array serial number"},{"line_number":2767,"context_line":"        :param volume: the volume objcet"},{"line_number":2768,"context_line":"        :param device_id: the volume device id"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_a447224d","line":2765,"in_reply_to":"3f4b6375_f11868d3","updated":"2017-11-08 08:45:31.000000000","message":"Will do, thanks Helen","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"}],"cinder/volume/drivers/dell_emc/vmax/fc.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9debef62b89083754e94dd5d30828fe7ecf76a2d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"              - Support for Generic Volume Group"},{"line_number":86,"context_line":"        3.1.0 - Support for replication groups (Tiramisu)"},{"line_number":87,"context_line":"              - Deprecate backend xml configuration"},{"line_number":88,"context_line":"              - Support for async replication (vmax-replication-enhancements)"},{"line_number":89,"context_line":"    \"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    VERSION \u003d \"3.1.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_d1ce8c2b","line":88,"updated":"2017-11-06 11:03:55.000000000","message":"Add a brief description of this feature.  Thanks","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1e26fdf293fee9b010b998a4a9d4a336411d84cf","unresolved":false,"context_lines":[{"line_number":85,"context_line":"              - Support for Generic Volume Group"},{"line_number":86,"context_line":"        3.1.0 - Support for replication groups (Tiramisu)"},{"line_number":87,"context_line":"              - Deprecate backend xml configuration"},{"line_number":88,"context_line":"              - Support for async replication (vmax-replication-enhancements)"},{"line_number":89,"context_line":"    \"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    VERSION \u003d \"3.1.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_64980acc","line":88,"in_reply_to":"3f4b6375_d1ce8c2b","updated":"2017-11-08 08:45:31.000000000","message":"Thanks Helen, I will fix this","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"}],"cinder/volume/drivers/dell_emc/vmax/iscsi.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9debef62b89083754e94dd5d30828fe7ecf76a2d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"              - Support for Generic Volume Group"},{"line_number":90,"context_line":"        3.1.0 - Support for replication groups (Tiramisu)"},{"line_number":91,"context_line":"              - Deprecate backend xml configuration"},{"line_number":92,"context_line":"              - Support for async replication (vmax-replication-enhancements)"},{"line_number":93,"context_line":"    \"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    VERSION \u003d \"3.1.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_11f2e470","line":92,"updated":"2017-11-06 11:03:55.000000000","message":"Add a brief description of this feature.  Thanks","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1e26fdf293fee9b010b998a4a9d4a336411d84cf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"              - Support for Generic Volume Group"},{"line_number":90,"context_line":"        3.1.0 - Support for replication groups (Tiramisu)"},{"line_number":91,"context_line":"              - Deprecate backend xml configuration"},{"line_number":92,"context_line":"              - Support for async replication (vmax-replication-enhancements)"},{"line_number":93,"context_line":"    \"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    VERSION \u003d \"3.1.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_24a212fe","line":92,"in_reply_to":"3f4b6375_11f2e470","updated":"2017-11-08 08:45:31.000000000","message":"Thanks Helen, I will fix this","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9debef62b89083754e94dd5d30828fe7ecf76a2d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        :returns: properties"},{"line_number":299,"context_line":"        \"\"\""},{"line_number":300,"context_line":"        properties \u003d {}"},{"line_number":301,"context_line":"        if len(ip_and_iqn) \u003e\u003d 1 and is_multipath:"},{"line_number":302,"context_line":"            properties[\u0027target_portals\u0027] \u003d ([t[\u0027ip\u0027] + \":3260\" for t in"},{"line_number":303,"context_line":"                                             ip_and_iqn])"},{"line_number":304,"context_line":"            properties[\u0027target_iqns\u0027] \u003d ([t[\u0027iqn\u0027].split(\",\")[0] for t in"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_51fbbc45","line":301,"updated":"2017-11-06 11:03:55.000000000","message":"Is there a reason this was changed to \u0027\u003e\u003d\u0027 ?","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1e26fdf293fee9b010b998a4a9d4a336411d84cf","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        :returns: properties"},{"line_number":299,"context_line":"        \"\"\""},{"line_number":300,"context_line":"        properties \u003d {}"},{"line_number":301,"context_line":"        if len(ip_and_iqn) \u003e\u003d 1 and is_multipath:"},{"line_number":302,"context_line":"            properties[\u0027target_portals\u0027] \u003d ([t[\u0027ip\u0027] + \":3260\" for t in"},{"line_number":303,"context_line":"                                             ip_and_iqn])"},{"line_number":304,"context_line":"            properties[\u0027target_iqns\u0027] \u003d ([t[\u0027iqn\u0027].split(\",\")[0] for t in"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_64e6ca4d","line":301,"in_reply_to":"3f4b6375_51fbbc45","updated":"2017-11-08 08:45:31.000000000","message":"We can have a situation where there is only one ip and iqn but it is still a multipath scenario because there is a metro_ip_iqn. This can cause a key error later because \u0027target_luns\u0027 etc may not be populated when we attempt to update them with the metro details. I will update this to be more specific though, and only populate these fields when there is a single ip_and_iqn value when metro is enabled. Thanks for the feedback!","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"}],"cinder/volume/drivers/dell_emc/vmax/utils.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9debef62b89083754e94dd5d30828fe7ecf76a2d","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        \"\"\"Get the replication prefix."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        Replication prefix for storage group naming is based on whether it is"},{"line_number":766,"context_line":"        synchronous or asynchronous replication mode."},{"line_number":767,"context_line":"        :param rep_mode: flag to indicate if replication is async"},{"line_number":768,"context_line":"        :return: prefix"},{"line_number":769,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_f11e286e","line":766,"updated":"2017-11-06 11:03:55.000000000","message":"update note for Metro.  Thanks","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"},{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"1e26fdf293fee9b010b998a4a9d4a336411d84cf","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        \"\"\"Get the replication prefix."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        Replication prefix for storage group naming is based on whether it is"},{"line_number":766,"context_line":"        synchronous or asynchronous replication mode."},{"line_number":767,"context_line":"        :param rep_mode: flag to indicate if replication is async"},{"line_number":768,"context_line":"        :return: prefix"},{"line_number":769,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_047276ae","line":766,"in_reply_to":"3f4b6375_f11e286e","updated":"2017-11-08 08:45:31.000000000","message":"Will do, thanks Helen","commit_id":"9956b475e20db7bb5a4c7ba9c980dce808aff282"}]}