)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"67d66c8106afa416075e6012ea6d20f210dd85eb","unresolved":false,"context_lines":[{"line_number":2592,"context_line":"        if (volume.group_id and"},{"line_number":2593,"context_line":"                not utils.is_group_a_cg_snapshot_type(volume.group)):"},{"line_number":2594,"context_line":"            msg \u003d _(\u0027Create volume with a replication or hyperswap \u0027"},{"line_number":2595,"context_line":"                    \u0027group_id is not allowed. Please add volume to \u0027"},{"line_number":2596,"context_line":"                    \u0027group after volume creation.\u0027)"},{"line_number":2597,"context_line":"            LOG.error(msg)"},{"line_number":2598,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_c3a8fe8c","line":2595,"range":{"start_line":2595,"start_character":33,"end_line":2595,"end_character":44},"updated":"2017-11-06 14:54:35.000000000","message":"Should say \"not supported\" to be more clear about why this isn\u0027t allowed.","commit_id":"e98bb24ec0ff9875be4b5881a400209d14bbae89"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"3bef9bd0bd4858e0254abc18fbe0e530eaa49f56","unresolved":false,"context_lines":[{"line_number":2592,"context_line":"        if (volume.group_id and"},{"line_number":2593,"context_line":"                not utils.is_group_a_cg_snapshot_type(volume.group)):"},{"line_number":2594,"context_line":"            msg \u003d _(\u0027Create volume with a replication or hyperswap \u0027"},{"line_number":2595,"context_line":"                    \u0027group_id is not allowed. Please add volume to \u0027"},{"line_number":2596,"context_line":"                    \u0027group after volume creation.\u0027)"},{"line_number":2597,"context_line":"            LOG.error(msg)"},{"line_number":2598,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_152e3a8b","line":2595,"range":{"start_line":2595,"start_character":33,"end_line":2595,"end_character":44},"in_reply_to":"3f4b6375_c3a8fe8c","updated":"2017-11-07 06:17:10.000000000","message":"Hi Eric, thanks a lot for your comment , it is addressed in the new patch.","commit_id":"e98bb24ec0ff9875be4b5881a400209d14bbae89"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"67d66c8106afa416075e6012ea6d20f210dd85eb","unresolved":false,"context_lines":[{"line_number":2595,"context_line":"                    \u0027group_id is not allowed. Please add volume to \u0027"},{"line_number":2596,"context_line":"                    \u0027group after volume creation.\u0027)"},{"line_number":2597,"context_line":"            LOG.error(msg)"},{"line_number":2598,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2599,"context_line":""},{"line_number":2600,"context_line":"        opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":2601,"context_line":"                                      volume_metadata\u003d"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_63914a52","line":2598,"range":{"start_line":2598,"start_character":28,"end_line":2598,"end_character":40},"updated":"2017-11-06 14:54:35.000000000","message":"Why InvalidInput?  This should be VolumeDriverException like the other cases.","commit_id":"e98bb24ec0ff9875be4b5881a400209d14bbae89"},{"author":{"_account_id":11186,"name":"yixuan zhang","email":"yixuan_z@hotmail.com","username":"yixuanzhang"},"change_message_id":"3bef9bd0bd4858e0254abc18fbe0e530eaa49f56","unresolved":false,"context_lines":[{"line_number":2595,"context_line":"                    \u0027group_id is not allowed. Please add volume to \u0027"},{"line_number":2596,"context_line":"                    \u0027group after volume creation.\u0027)"},{"line_number":2597,"context_line":"            LOG.error(msg)"},{"line_number":2598,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2599,"context_line":""},{"line_number":2600,"context_line":"        opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027],"},{"line_number":2601,"context_line":"                                      volume_metadata\u003d"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_9557ca01","line":2598,"range":{"start_line":2598,"start_character":28,"end_line":2598,"end_character":40},"in_reply_to":"3f4b6375_63914a52","updated":"2017-11-07 06:17:10.000000000","message":"Hi Eric, thank you very much for your comment, it is addressed in the new patch","commit_id":"e98bb24ec0ff9875be4b5881a400209d14bbae89"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b54f9bf12bc39b24b455b0b0474048b3f63caf31","unresolved":false,"context_lines":[{"line_number":2719,"context_line":"    def create_volume_from_snapshot(self, volume, snapshot):"},{"line_number":2720,"context_line":"        # create volume from snapshot with a replication or hyperswap group_id"},{"line_number":2721,"context_line":"        # is not allowed."},{"line_number":2722,"context_line":"        if (volume.group_id and"},{"line_number":2723,"context_line":"                not utils.is_group_a_cg_snapshot_type(volume.group)):"},{"line_number":2724,"context_line":"            msg \u003d _(\u0027Create volume from snapshot with a replication or \u0027"},{"line_number":2725,"context_line":"                    \u0027hyperswap group_id is not supported. Please add volume to\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_1ae116fd","line":2722,"updated":"2017-12-15 21:19:55.000000000","message":"All of these are basically the same. It would be better to refactor this out to a common method that takes the volume and does the check.","commit_id":"d6a5154016777245d6e2468c6e04d0c4664905c4"}],"releasenotes/notes/storwize-disable-create-volume-with-non-cgsnap-group-6cba8073e3d6cadd.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"693f8519976724906fd941c0950b59d71f00eb1c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Disable creating volume with non cg_snapshot group_id in"},{"line_number":4,"context_line":"    Storwize/SVC driver."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df87a7cf_0bc2015a","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":11},"updated":"2017-12-18 11:30:54.000000000","message":"Disabled","commit_id":"b03a23618122ee8abf596a471da326bfcb9e1710"}]}