)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ac0da732eea284e3a02e2bf54e36881012c17006","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve cinder revert-to-snapshot notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now if reverting to snapshot finished, it will gave both"},{"line_number":10,"context_line":"\u0027revert.start\u0027 and \u0027revert.end\u0027 usage notifications, only"},{"line_number":11,"context_line":"\u0027revert.start\u0027 will be gave if an exception is raised."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_4578a88e","line":9,"range":{"start_line":9,"start_character":46,"end_line":9,"end_character":51},"updated":"2017-11-04 23:18:02.000000000","message":"give","commit_id":"488f9f8eb6c684b924638ed33a521857fa3a87f4"},{"author":{"_account_id":25169,"name":"Xiaojun Liao","email":"xiaojunliao85@gmail.com","username":"wwba"},"change_message_id":"cb7037a4472814be34c17d294be3a964f0c399ab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve cinder revert-to-snapshot notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now if reverting to snapshot finished, it will gave both"},{"line_number":10,"context_line":"\u0027revert.start\u0027 and \u0027revert.end\u0027 usage notifications, only"},{"line_number":11,"context_line":"\u0027revert.start\u0027 will be gave if an exception is raised."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_c685bbae","line":9,"range":{"start_line":9,"start_character":46,"end_line":9,"end_character":51},"in_reply_to":"3f4b6375_4578a88e","updated":"2017-11-06 02:14:43.000000000","message":"Done","commit_id":"488f9f8eb6c684b924638ed33a521857fa3a87f4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ac0da732eea284e3a02e2bf54e36881012c17006","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now if reverting to snapshot finished, it will gave both"},{"line_number":10,"context_line":"\u0027revert.start\u0027 and \u0027revert.end\u0027 usage notifications, only"},{"line_number":11,"context_line":"\u0027revert.start\u0027 will be gave if an exception is raised."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug:#1729793"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_257b6c8c","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":27},"updated":"2017-11-04 23:18:02.000000000","message":"given","commit_id":"488f9f8eb6c684b924638ed33a521857fa3a87f4"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"437110508164b77335dd328d1e79230f7a5b5d87","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve cinder revert-to-snapshot notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now if reverting to snapshot finished, it will give both"},{"line_number":10,"context_line":"\u0027revert.start\u0027 and \u0027revert.end\u0027 usage notifications."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug:#1729793"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_e68af7bc","line":10,"updated":"2017-11-06 02:15:47.000000000","message":"Here we should explain why this change is made, i.e. what is going wrong before this patch.","commit_id":"e4c71642149b7f5bc79c8e7d3776f4f4a1782460"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"49643c18eab03395fe95e319ca2228021f575a5c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve cinder revert-to-snapshot notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The reverting were sending \u0027revert.end\u0027 message without a"},{"line_number":10,"context_line":"corresponding \u0027revert.start\u0027 notification if creating backup"},{"line_number":11,"context_line":"snapshot failed, and only a \u0027revert.start\u0027 notification was"},{"line_number":12,"context_line":"given if reverting to snapshot finished."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Now if reverting to snapshot finished, it will give both the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f4b6375_b23315f6","line":11,"range":{"start_line":10,"start_character":42,"end_line":11,"end_character":16},"updated":"2017-11-06 05:59:00.000000000","message":"if creating backup snapshot failed by an exception.","commit_id":"e68b96baeebe230ebf9ee1e038697a4dd1131dd6"},{"author":{"_account_id":25169,"name":"Xiaojun Liao","email":"xiaojunliao85@gmail.com","username":"wwba"},"change_message_id":"c378966f23d88ae547aa54345553514aa2c9e9e9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve cinder revert-to-snapshot notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The reverting were sending \u0027revert.end\u0027 message without a"},{"line_number":10,"context_line":"corresponding \u0027revert.start\u0027 notification if creating backup"},{"line_number":11,"context_line":"snapshot failed, and only a \u0027revert.start\u0027 notification was"},{"line_number":12,"context_line":"given if reverting to snapshot finished."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Now if reverting to snapshot finished, it will give both the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f4b6375_b2aaf56d","line":11,"range":{"start_line":10,"start_character":42,"end_line":11,"end_character":16},"in_reply_to":"3f4b6375_b23315f6","updated":"2017-11-06 06:38:13.000000000","message":"Done","commit_id":"e68b96baeebe230ebf9ee1e038697a4dd1131dd6"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"49643c18eab03395fe95e319ca2228021f575a5c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The reverting were sending \u0027revert.end\u0027 message without a"},{"line_number":10,"context_line":"corresponding \u0027revert.start\u0027 notification if creating backup"},{"line_number":11,"context_line":"snapshot failed, and only a \u0027revert.start\u0027 notification was"},{"line_number":12,"context_line":"given if reverting to snapshot finished."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Now if reverting to snapshot finished, it will give both the"},{"line_number":15,"context_line":"\u0027revert.start\u0027 and \u0027revert.end\u0027 notifications."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f4b6375_729d9dba","line":12,"range":{"start_line":11,"start_character":21,"end_line":12,"end_character":40},"updated":"2017-11-06 05:59:00.000000000","message":"This second situation is not correct. If reverting to a snapshot finished, \u0027revert.end\u0027 will be sent by the original _revert_to_snapshot.","commit_id":"e68b96baeebe230ebf9ee1e038697a4dd1131dd6"},{"author":{"_account_id":25169,"name":"Xiaojun Liao","email":"xiaojunliao85@gmail.com","username":"wwba"},"change_message_id":"c378966f23d88ae547aa54345553514aa2c9e9e9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The reverting were sending \u0027revert.end\u0027 message without a"},{"line_number":10,"context_line":"corresponding \u0027revert.start\u0027 notification if creating backup"},{"line_number":11,"context_line":"snapshot failed, and only a \u0027revert.start\u0027 notification was"},{"line_number":12,"context_line":"given if reverting to snapshot finished."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Now if reverting to snapshot finished, it will give both the"},{"line_number":15,"context_line":"\u0027revert.start\u0027 and \u0027revert.end\u0027 notifications."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f4b6375_d2c8d155","line":12,"range":{"start_line":11,"start_character":21,"end_line":12,"end_character":40},"in_reply_to":"3f4b6375_729d9dba","updated":"2017-11-06 06:38:13.000000000","message":"Done","commit_id":"e68b96baeebe230ebf9ee1e038697a4dd1131dd6"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"7e68341618e9015c717e6c010e42bb4a494d084a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The reverting were sending \u0027revert.end\u0027 message without a"},{"line_number":10,"context_line":"corresponding \u0027revert.start\u0027 notification if creating backup"},{"line_number":11,"context_line":"snapshot failed by an exception. Now it will give both the"},{"line_number":12,"context_line":"\u0027revert.start\u0027 and \u0027revert.end\u0027 notifications if reverting"},{"line_number":13,"context_line":"fails with an exception from _create_backup_snapshot."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug:#1729793"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4b6375_8d2ebe89","line":13,"range":{"start_line":11,"start_character":33,"end_line":13,"end_character":53},"updated":"2017-11-06 07:12:16.000000000","message":"nitpick:\nThis last sentence can be shorten to something like \u0027This patch will fix.\u0027","commit_id":"35437df30cb05aebfefff9da8b4f96715a3b5eb0"},{"author":{"_account_id":25169,"name":"Xiaojun Liao","email":"xiaojunliao85@gmail.com","username":"wwba"},"change_message_id":"ad72d50f56b960e727c7538f9976dff8af98ba16","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The reverting were sending \u0027revert.end\u0027 message without a"},{"line_number":10,"context_line":"corresponding \u0027revert.start\u0027 notification if creating backup"},{"line_number":11,"context_line":"snapshot failed by an exception. Now it will give both the"},{"line_number":12,"context_line":"\u0027revert.start\u0027 and \u0027revert.end\u0027 notifications if reverting"},{"line_number":13,"context_line":"fails with an exception from _create_backup_snapshot."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug:#1729793"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f4b6375_2d334a64","line":13,"range":{"start_line":11,"start_character":33,"end_line":13,"end_character":53},"in_reply_to":"3f4b6375_8d2ebe89","updated":"2017-11-06 07:47:10.000000000","message":"Done","commit_id":"35437df30cb05aebfefff9da8b4f96715a3b5eb0"}],"cinder/volume/manager.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a0b83b27008b5b9300bbe71e3187a60608c1760c","unresolved":false,"context_lines":[{"line_number":954,"context_line":"                self._notify_about_volume_usage(context, volume,"},{"line_number":955,"context_line":"                                                \"revert.end\")"},{"line_number":956,"context_line":"                self._notify_about_snapshot_usage(context, snapshot,"},{"line_number":957,"context_line":"                                                  \"revert.end\")"},{"line_number":958,"context_line":"                msg \u003d (\u0027Volume %(v_id)s revert to \u0027"},{"line_number":959,"context_line":"                       \u0027snapshot %(s_id)s failed with %(error)s.\u0027)"},{"line_number":960,"context_line":"                msg_args \u003d {\u0027v_id\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_180a2e1f","side":"PARENT","line":957,"updated":"2017-11-03 09:33:26.000000000","message":"I think it\u0027s ok (but maybe not necessary) to send a revert.end notification when reverting is failed, so keeping the above lines is ok.","commit_id":"3b6b88ec04517338bae9af13a067139e8fd34d75"},{"author":{"_account_id":25169,"name":"Xiaojun Liao","email":"xiaojunliao85@gmail.com","username":"wwba"},"change_message_id":"c2f6cc1e89dc6910ffcb4cba0bb016b54a5cfde2","unresolved":false,"context_lines":[{"line_number":954,"context_line":"                self._notify_about_volume_usage(context, volume,"},{"line_number":955,"context_line":"                                                \"revert.end\")"},{"line_number":956,"context_line":"                self._notify_about_snapshot_usage(context, snapshot,"},{"line_number":957,"context_line":"                                                  \"revert.end\")"},{"line_number":958,"context_line":"                msg \u003d (\u0027Volume %(v_id)s revert to \u0027"},{"line_number":959,"context_line":"                       \u0027snapshot %(s_id)s failed with %(error)s.\u0027)"},{"line_number":960,"context_line":"                msg_args \u003d {\u0027v_id\u0027: volume.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_c6949b8d","side":"PARENT","line":957,"in_reply_to":"3f4b6375_180a2e1f","updated":"2017-11-06 01:30:37.000000000","message":"Thanks! I will keep notifications here.","commit_id":"3b6b88ec04517338bae9af13a067139e8fd34d75"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"a0b83b27008b5b9300bbe71e3187a60608c1760c","unresolved":false,"context_lines":[{"line_number":941,"context_line":"        backup_snapshot \u003d None"},{"line_number":942,"context_line":"        try:"},{"line_number":943,"context_line":"            LOG.info(\"Start to perform revert to snapshot process.\")"},{"line_number":944,"context_line":"            "},{"line_number":945,"context_line":"            self._notify_about_volume_usage(context, volume, \"revert.start\")"},{"line_number":946,"context_line":"            self._notify_about_snapshot_usage(context, snapshot, \"revert.start\")"},{"line_number":947,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_d5521f67","line":944,"updated":"2017-11-03 09:33:26.000000000","message":"W293 blank line contains whitespace [python/pep8]","commit_id":"488f9f8eb6c684b924638ed33a521857fa3a87f4"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"d4d92583b163bfeba0b956b29b2f9e3399c65c58","unresolved":false,"context_lines":[{"line_number":941,"context_line":"        backup_snapshot \u003d None"},{"line_number":942,"context_line":"        try:"},{"line_number":943,"context_line":"            LOG.info(\"Start to perform revert to snapshot process.\")"},{"line_number":944,"context_line":"            "},{"line_number":945,"context_line":"            self._notify_about_volume_usage(context, volume, \"revert.start\")"},{"line_number":946,"context_line":"            self._notify_about_snapshot_usage(context, snapshot, \"revert.start\")"},{"line_number":947,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_38428a69","line":944,"in_reply_to":"3f4b6375_d5521f67","updated":"2017-11-03 10:00:58.000000000","message":"+1","commit_id":"488f9f8eb6c684b924638ed33a521857fa3a87f4"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"437110508164b77335dd328d1e79230f7a5b5d87","unresolved":false,"context_lines":[{"line_number":943,"context_line":"            LOG.info(\"Start to perform revert to snapshot process.\")"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"            self._notify_about_volume_usage(context, volume, \"revert.start\")"},{"line_number":946,"context_line":"            self._notify_about_snapshot_usage(context, snapshot, \"revert.start\")"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"            # Create a snapshot which can be used to restore the volume"},{"line_number":949,"context_line":"            # data by hand if revert process failed."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_66f28772","line":946,"updated":"2017-11-06 02:15:47.000000000","message":"E501 line too long (80 \u003e 79 characters) [python/pep8]","commit_id":"e4c71642149b7f5bc79c8e7d3776f4f4a1782460"}]}