)]}'
{"cinder/backup/api.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8e94bda239d059a99122879192978b435cbb6396","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                   \u0027host\u0027: backup[\u0027host\u0027],"},{"line_number":375,"context_line":"                   \u0027id\u0027: backup[\u0027id\u0027]})"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        export_data \u003d self.scheduler_rpcapi.export_backup(context, backup)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        return export_data"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_157f3eab","line":377,"range":{"start_line":377,"start_character":22,"end_line":377,"end_character":74},"updated":"2018-05-15 07:23:49.000000000","message":"why we need to re-request this operation to scheduler? I guess not every operation need to be refactored into scheduler service.","commit_id":"37f0bdf4d6eeb3aabacc8eba40fe4c5be6297163"}],"cinder/backup/rpcapi.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8e94bda239d059a99122879192978b435cbb6396","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        cctxt \u003d self._get_cctxt(server\u003dservice.host, version\u003d\u00272.1\u0027)"},{"line_number":113,"context_line":"        return cctxt.call(context, \u0027get_log_levels\u0027, log_request\u003dlog_request)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @rpc.assert_min_rpc_version(\u00272.1\u0027)"},{"line_number":116,"context_line":"    def publish_service_capabilities(self, ctxt):"},{"line_number":117,"context_line":"        cctxt \u003d self._get_cctxt(fanout\u003dTrue)"},{"line_number":118,"context_line":"        cctxt.cast(ctxt, \u0027publish_service_capabilities\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_4a2751cb","line":118,"range":{"start_line":115,"start_character":2,"end_line":118,"end_character":56},"updated":"2018-05-15 07:23:49.000000000","message":"Why not bump rpc version?","commit_id":"37f0bdf4d6eeb3aabacc8eba40fe4c5be6297163"}],"cinder/scheduler/manager.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8e94bda239d059a99122879192978b435cbb6396","unresolved":false,"context_lines":[{"line_number":580,"context_line":"    def create_backup(self, context, backup):"},{"line_number":581,"context_line":"        volume \u003d self.db.volume_get(context, backup.volume_id)"},{"line_number":582,"context_line":"        try:"},{"line_number":583,"context_line":"            host \u003d self.driver.get_backup_host(volume)"},{"line_number":584,"context_line":"            backup.host \u003d host"},{"line_number":585,"context_line":"            backup.save()"},{"line_number":586,"context_line":"            self.backup_api.create_backup(context, backup)"},{"line_number":587,"context_line":"        except exception.ServiceNotFound:"},{"line_number":588,"context_line":"            msg \u003d \"Service not found for creating backup.\""}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_15e3bea5","line":585,"range":{"start_line":583,"start_character":11,"end_line":585,"end_character":25},"updated":"2018-05-15 07:23:49.000000000","message":"When creating new backup from volume, the host would be equal to volume\u0027s host, but we can\u0027t guarantee the backup service is deployed on the host, does this mean this rpc call would always fail?","commit_id":"37f0bdf4d6eeb3aabacc8eba40fe4c5be6297163"}],"cinder/scheduler/rpcapi.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"8e94bda239d059a99122879192978b435cbb6396","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                    \u0027backup_url\u0027: backup_url}"},{"line_number":295,"context_line":"        return cctxt.call(ctxt, \u0027import_backup\u0027, **msg_args)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @rpc.assert_min_rpc_version(\u00273.12\u0027)"},{"line_number":298,"context_line":"    def reset_backup_status(self, ctxt, backup, status):"},{"line_number":299,"context_line":"        cctxt \u003d self._get_cctxt()"},{"line_number":300,"context_line":"        msg_args \u003d {\u0027backup\u0027: backup, \u0027status\u0027: status}"},{"line_number":301,"context_line":"        return cctxt.call(ctxt, \u0027reset_backup_status\u0027, **msg_args)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_752232bb","line":299,"range":{"start_line":297,"start_character":1,"end_line":299,"end_character":33},"updated":"2018-05-15 07:23:49.000000000","message":"It\u0027s not been used anywhere now:)","commit_id":"37f0bdf4d6eeb3aabacc8eba40fe4c5be6297163"}]}