)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/vnx/test_client.py":[{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"5d5fb0a79512de4e614f091f9ce6394bfe174d4d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        lun.migrate.assert_called_with(5, storops.VNXMigrationRate.HIGH)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @unittest.skip(\"Skip until bug #1578986 is fixed\")"},{"line_number":149,"context_line":"    @utils.patch_sleep"},{"line_number":150,"context_line":"    @res_mock.patch_client"},{"line_number":151,"context_line":"    def test_verify_migration(self, client, mocked, sleep_mock):"},{"line_number":152,"context_line":"        r \u003d client.verify_migration(1, 2, \u0027test_wwn\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_d38a7862","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":22},"updated":"2017-12-19 10:59:53.000000000","message":"Mocking sleep does appear to commonly cause issues. Instead, could you make the interval a constant and assign it a value of 0 in the tests (like the DEFAULT_TIMEOUT, above)? This should avoid the need to skip these unittests.","commit_id":"19af67e5dc75dfae4b600a826b2fb683a9cd0047"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"d64c6caf2b05811499d6ec9385ea10d3ac9dc0e5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        lun.migrate.assert_called_with(5, storops.VNXMigrationRate.HIGH)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @unittest.skip(\"Skip until bug #1578986 is fixed\")"},{"line_number":149,"context_line":"    @utils.patch_sleep"},{"line_number":150,"context_line":"    @res_mock.patch_client"},{"line_number":151,"context_line":"    def test_verify_migration(self, client, mocked, sleep_mock):"},{"line_number":152,"context_line":"        r \u003d client.verify_migration(1, 2, \u0027test_wwn\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_04708107","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":22},"in_reply_to":"df87a7cf_d38a7862","updated":"2017-12-20 06:43:59.000000000","message":"Thanks for the suggestion, done in local.\nLet\u0027s see if it hangs in the CI.","commit_id":"19af67e5dc75dfae4b600a826b2fb683a9cd0047"}],"cinder/volume/drivers/dell_emc/vnx/client.py":[{"author":{"_account_id":23414,"name":"Ciara Stacke","email":"ciara.stacke@emc.com","username":"cstacke"},"change_message_id":"5d5fb0a79512de4e614f091f9ce6394bfe174d4d","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        src_lun \u003d self.vnx.get_lun(lun_id\u003dsrc_id)"},{"line_number":232,"context_line":"        # Sleep 30 seconds to make sure the session starts on the VNX."},{"line_number":233,"context_line":"        time.sleep(30)"},{"line_number":234,"context_line":"        utils.wait_until(condition\u003dself.session_finished,"},{"line_number":235,"context_line":"                         interval\u003dcommon.INTERVAL_30_SEC,"},{"line_number":236,"context_line":"                         src_lun\u003dsrc_lun)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_d3b83812","line":233,"range":{"start_line":233,"start_character":19,"end_line":233,"end_character":21},"updated":"2017-12-19 10:59:53.000000000","message":"Please make this a constant which can be assigned a value of 0 in the tests, or use the already defined constant common.INTERVAL_30_SEC.","commit_id":"19af67e5dc75dfae4b600a826b2fb683a9cd0047"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"d64c6caf2b05811499d6ec9385ea10d3ac9dc0e5","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        src_lun \u003d self.vnx.get_lun(lun_id\u003dsrc_id)"},{"line_number":232,"context_line":"        # Sleep 30 seconds to make sure the session starts on the VNX."},{"line_number":233,"context_line":"        time.sleep(30)"},{"line_number":234,"context_line":"        utils.wait_until(condition\u003dself.session_finished,"},{"line_number":235,"context_line":"                         interval\u003dcommon.INTERVAL_30_SEC,"},{"line_number":236,"context_line":"                         src_lun\u003dsrc_lun)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_64586d89","line":233,"range":{"start_line":233,"start_character":19,"end_line":233,"end_character":21},"in_reply_to":"df87a7cf_d3b83812","updated":"2017-12-20 06:43:59.000000000","message":"Use the constant now","commit_id":"19af67e5dc75dfae4b600a826b2fb683a9cd0047"}]}