)]}'
{"cinder/cmd/manage.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"eb45a80cab7071e57878cfa45f27498c782eb831","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        for v in vrefs:"},{"line_number":124,"context_line":"            db.volume_update("},{"line_number":125,"context_line":"                ctxt, v[\u0027id\u0027],"},{"line_number":126,"context_line":"                {\u0027shared_targets\u0027: 0})"},{"line_number":127,"context_line":"            completed +\u003d 1"},{"line_number":128,"context_line":"    return total_vols_to_update, completed"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_768d3829","line":126,"range":{"start_line":126,"start_character":35,"end_line":126,"end_character":36},"updated":"2017-11-30 12:52:06.000000000","message":"Why is this \u00270\u0027 here and not \u0027False\u0027?","commit_id":"2fa6fdd7846df05c3d81e78c137ec2976499a7f9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"63aa959f2edeaf2a2c7f731a3de367dcce46ff80","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        for v in vrefs:"},{"line_number":124,"context_line":"            db.volume_update("},{"line_number":125,"context_line":"                ctxt, v[\u0027id\u0027],"},{"line_number":126,"context_line":"                {\u0027shared_targets\u0027: 0})"},{"line_number":127,"context_line":"            completed +\u003d 1"},{"line_number":128,"context_line":"    return total_vols_to_update, completed"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_bcbce86c","line":126,"range":{"start_line":126,"start_character":35,"end_line":126,"end_character":36},"in_reply_to":"ff82abbf_0e87e8b8","updated":"2017-12-01 07:38:56.000000000","message":"My bad, thanks. :)","commit_id":"2fa6fdd7846df05c3d81e78c137ec2976499a7f9"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e47e94139998d9000f4dafeaeb636c6301251939","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        for v in vrefs:"},{"line_number":124,"context_line":"            db.volume_update("},{"line_number":125,"context_line":"                ctxt, v[\u0027id\u0027],"},{"line_number":126,"context_line":"                {\u0027shared_targets\u0027: 0})"},{"line_number":127,"context_line":"            completed +\u003d 1"},{"line_number":128,"context_line":"    return total_vols_to_update, completed"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_0e87e8b8","line":126,"range":{"start_line":126,"start_character":35,"end_line":126,"end_character":36},"in_reply_to":"ff82abbf_768d3829","updated":"2017-11-30 19:03:03.000000000","message":"Because 0 is False, and that\u0027s what I typed there?  The DB representation is 1|0, not sure I understand the question?","commit_id":"2fa6fdd7846df05c3d81e78c137ec2976499a7f9"}],"cinder/volume/manager.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3e68ba01abf6a7b017a66d5a52ab3e278302b4a6","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                self._update_allocated_capacity(volume)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        shared_targets \u003d ("},{"line_number":684,"context_line":"            1"},{"line_number":685,"context_line":"            if self.driver.capabilities.get(\u0027shared_targets\u0027, True)"},{"line_number":686,"context_line":"            else 0)"},{"line_number":687,"context_line":"        updates \u003d {\u0027service_uuid\u0027: self.service_uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_74c0e6e1","line":684,"updated":"2017-11-29 19:17:02.000000000","message":"Should we use True/False instead of 1/0 here?","commit_id":"2fa6fdd7846df05c3d81e78c137ec2976499a7f9"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e47e94139998d9000f4dafeaeb636c6301251939","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                self._update_allocated_capacity(volume)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        shared_targets \u003d ("},{"line_number":684,"context_line":"            1"},{"line_number":685,"context_line":"            if self.driver.capabilities.get(\u0027shared_targets\u0027, True)"},{"line_number":686,"context_line":"            else 0)"},{"line_number":687,"context_line":"        updates \u003d {\u0027service_uuid\u0027: self.service_uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_6e5f9472","line":684,"in_reply_to":"ff82abbf_74c0e6e1","updated":"2017-11-30 19:03:03.000000000","message":"It can be, but I don\u0027t know that it \"should\" be... the DB Engine is going to just turn around and stuff that in as a tiny-int anyway; and IIRC there are some complications with sqlite (only an issue for tests).\n\nRegardless, I can change it if there\u0027s a compelling reason that one is better than the other here.","commit_id":"2fa6fdd7846df05c3d81e78c137ec2976499a7f9"}]}