)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"99f5c1d4d1216f8cba774f724a59b208321c36f8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"* PUT  /v2/{project_id}/snapshots/{snapshot_id}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"V2/V3 APIs accepts \u0027name\u0027 and \u0027description\u0027 parameters instead"},{"line_number":16,"context_line":"\u0027display_name\u0027 and \u0027display_description\u0027 as these were used in"},{"line_number":17,"context_line":"V1. So removed these parameters from schema. If user passes these"},{"line_number":18,"context_line":"parameters in request body, it will raise 400 error."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_afc73312","line":16,"updated":"2017-12-20 02:02:49.000000000","message":"But the code in v2/v3 still accepts display_name/display_description until this change, so your patch actually changes cinder v2/v3 snapshot API behavior.  We probably shouldn\u0027t do that.","commit_id":"b1651d801858d4b6e33c45bacc0c648f9f333a73"}],"cinder/api/schemas/snapshots.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"276c078a7a61fc72aab1a35092c7c31d4920f057","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":51,"context_line":"            \u0027properties\u0027: {"},{"line_number":52,"context_line":"                \u0027name\u0027: parameter_types.name_allow_zero_min_length,"},{"line_number":53,"context_line":"                \u0027description\u0027: parameter_types.description,"},{"line_number":54,"context_line":"                \u0027display_name\u0027: parameter_types.name_allow_zero_min_length,"},{"line_number":55,"context_line":"            },"},{"line_number":56,"context_line":"            \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf8cb3f7_885c304c","line":53,"updated":"2017-12-22 07:46:42.000000000","message":"Current implementation can also take input from \u0027display_description\u0027.","commit_id":"c3053c8acb222ef3b7d9360ed74ad462e683e1f0"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"276c078a7a61fc72aab1a35092c7c31d4920f057","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027anyOf\u0027: ["},{"line_number":58,"context_line":"                {\u0027required\u0027: [\u0027name\u0027]},"},{"line_number":59,"context_line":"                {\u0027required\u0027: [\u0027description\u0027]},"},{"line_number":60,"context_line":"                {\u0027required\u0027: [\u0027display_name\u0027]},"},{"line_number":61,"context_line":"            ]"},{"line_number":62,"context_line":"        },"},{"line_number":63,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf8cb3f7_28596459","line":60,"updated":"2017-12-22 07:46:42.000000000","message":"{\u0027required\u0027: [\u0027display_description\u0027]}","commit_id":"c3053c8acb222ef3b7d9360ed74ad462e683e1f0"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"52469344ca8eea39dae1d68097dfede36e72272d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                \u0027description\u0027: parameter_types.description,"},{"line_number":32,"context_line":"                \u0027volume_id\u0027: parameter_types.uuid_allow_null,"},{"line_number":33,"context_line":"                \u0027force\u0027: parameter_types.boolean,"},{"line_number":34,"context_line":"                \u0027metadata\u0027: parameter_types.extra_specs,"},{"line_number":35,"context_line":"            },"},{"line_number":36,"context_line":"            \u0027required\u0027: [\u0027volume_id\u0027],"},{"line_number":37,"context_line":"            \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf8cb3f7_bd281fe2","line":34,"range":{"start_line":34,"start_character":44,"end_line":34,"end_character":55},"updated":"2017-12-27 15:58:35.000000000","message":"It\u0027d be extra_specs_allow_null instead.","commit_id":"da28bbdc03bcfbfe091becae929b9eaa54f85cc7"}],"cinder/api/validation/parameter_types.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"52469344ca8eea39dae1d68097dfede36e72272d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027"},{"line_number":142,"context_line":"}"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"extra_specs \u003d {"},{"line_number":145,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":146,"context_line":"    \u0027patternProperties\u0027: {"},{"line_number":147,"context_line":"        \u0027^[a-zA-Z0-9-_:. ]{1,255}$\u0027: {"},{"line_number":148,"context_line":"            \u0027type\u0027: \u0027string\u0027, \u0027maxLength\u0027: 255"},{"line_number":149,"context_line":"        }"},{"line_number":150,"context_line":"    },"},{"line_number":151,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"group_snapshot_status \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf8cb3f7_7d229702","line":152,"range":{"start_line":144,"start_character":0,"end_line":152,"end_character":1},"updated":"2017-12-27 15:58:35.000000000","message":"snapshot metadata can be null, but this parameter type forbids that.","commit_id":"da28bbdc03bcfbfe091becae929b9eaa54f85cc7"}]}