)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2151e6967d8b6f5faefd9ace44d1f74f223a371a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chhagarw \u003cchhagarw@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-04 05:24:27 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove skip_validation_flag to False by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove the skip_validation to False by default to force quota"},{"line_number":10,"context_line":"validation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_cea23d9b","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":47},"updated":"2017-12-04 15:34:02.000000000","message":"This part should probably be removed now.","commit_id":"fa040b835406dc44957f734c4d528a1b3327280b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e2ea08d38251ed8175af678d186dd5a68458213a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chhagarw \u003cchhagarw@in.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-04 05:24:27 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove skip_validation_flag to False by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove the skip_validation to False by default to force quota"},{"line_number":10,"context_line":"validation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_6418c0d2","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":47},"in_reply_to":"df87a7cf_cea23d9b","updated":"2017-12-06 07:26:19.000000000","message":"+1","commit_id":"fa040b835406dc44957f734c4d528a1b3327280b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ddebf17e244dd89cad4e735b96d51853dcb85bd8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Remove the skip_validation to force quota"},{"line_number":10,"context_line":"validation."},{"line_number":11,"context_line":"Closes-bug: #1735337"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib9596ac3ecc57a4f825b7d7118014e2ac14b2473"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df87a7cf_a3108b4f","line":12,"updated":"2017-12-11 14:34:50.000000000","message":"Should we add APIImpact flag?","commit_id":"7310676502f34a3e38329995731e12bcd5331210"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"4609b01b71afe7344a705b5f92f58cc813310ae9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Remove the skip_validation to force quota"},{"line_number":10,"context_line":"validation."},{"line_number":11,"context_line":"Closes-bug: #1735337"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib9596ac3ecc57a4f825b7d7118014e2ac14b2473"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df87a7cf_babeeafc","line":12,"in_reply_to":"df87a7cf_0acdc42f","updated":"2017-12-15 21:09:28.000000000","message":"Sean is correct, the APIImpact tag is not actively reviewed anymore. If you have specific questions about API implementations, please reach out during our meeting time[1] or use the \"[api]\" tag in an email to the developer mailing list.\n\n[1]: https://wiki.openstack.org/wiki/Meetings/API-SIG","commit_id":"7310676502f34a3e38329995731e12bcd5331210"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a99abf5e96f6b6533076432fcb7080c334b8c364","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Remove the skip_validation to force quota"},{"line_number":10,"context_line":"validation."},{"line_number":11,"context_line":"Closes-bug: #1735337"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib9596ac3ecc57a4f825b7d7118014e2ac14b2473"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df87a7cf_0acdc42f","line":12,"in_reply_to":"df87a7cf_a3108b4f","updated":"2017-12-11 17:20:41.000000000","message":"From what I understand, those are not actively being reviewed.\n\nIf we want a judgement call on this, we could reach out directly to those involved in the api-wg and ask for their input.","commit_id":"7310676502f34a3e38329995731e12bcd5331210"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7ced14be52c17be2fe2e8bd0f7688704f2a69f0a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Remove the skip_validation to force quota"},{"line_number":10,"context_line":"validation."},{"line_number":11,"context_line":"Closes-bug: #1735337"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib9596ac3ecc57a4f825b7d7118014e2ac14b2473"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df87a7cf_f5a1e596","line":12,"in_reply_to":"df87a7cf_babeeafc","updated":"2017-12-15 22:16:43.000000000","message":"Thank Michael!","commit_id":"7310676502f34a3e38329995731e12bcd5331210"}],"cinder/api/contrib/quotas.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"957ae973e945ba1787d15ea2b23624abc5742423","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # Get the optional argument \u0027skip_validation\u0027 from body,"},{"line_number":215,"context_line":"        # if skip_validation is False, then validate existing resource."},{"line_number":216,"context_line":"        skip_flag \u003d body.get(\u0027skip_validation\u0027, False)"},{"line_number":217,"context_line":"        if not strutils.is_valid_boolstr(skip_flag):"},{"line_number":218,"context_line":"            msg \u003d _(\"Invalid value \u0027%s\u0027 for skip_validation.\") % skip_flag"},{"line_number":219,"context_line":"            raise exception.InvalidParameterValue(err\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_9187a662","line":216,"updated":"2017-11-30 13:21:11.000000000","message":"I\u0027d like to see this just removed. In the message before we had stated that Cinder will force validation in Queens. To force that validation, we need to remove the option to not validate.\n\nThis should be removed here and in the api-ref.","commit_id":"5fa358e7e07fde864cb1c7c957e85c83de1500ed"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e2ea08d38251ed8175af678d186dd5a68458213a","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"            # Can\u0027t skip the validation of nested quotas since it could mess up"},{"line_number":269,"context_line":"            # hierarchy if parent limit is less than childrens\u0027 current usage"},{"line_number":270,"context_line":"            if use_nested_quotas:"},{"line_number":271,"context_line":"                self._validate_existing_resource(key, value, quota_values)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"            if use_nested_quotas:"},{"line_number":274,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_04369453","line":271,"range":{"start_line":270,"start_character":9,"end_line":271,"end_character":74},"updated":"2017-12-06 07:26:19.000000000","message":"It looks like you ignored the validation rather than ensure that.","commit_id":"fa040b835406dc44957f734c4d528a1b3327280b"}],"cinder/tests/unit/api/contrib/test_quotas.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e2ea08d38251ed8175af678d186dd5a68458213a","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                         db.quota_usage_get_all_by_project(ctxt,"},{"line_number":310,"context_line":"                                                           fake.PROJECT_ID))"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def test_update_lower_than_existing_resources_without_skip_argument(self):"},{"line_number":313,"context_line":"        self._commit_quota_reservation()"},{"line_number":314,"context_line":"        body \u003d {\u0027quota_set\u0027: {\u0027volumes\u0027: 0}}"},{"line_number":315,"context_line":"        result \u003d self.controller.update(self.req, fake.PROJECT_ID, body)"},{"line_number":316,"context_line":"        self.assertEqual(body[\u0027quota_set\u0027][\u0027volumes\u0027],"},{"line_number":317,"context_line":"                         result[\u0027quota_set\u0027][\u0027volumes\u0027])"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def test_delete(self):"},{"line_number":320,"context_line":"        result_show \u003d self.controller.show(self.req, fake.PROJECT_ID)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_a44488b8","line":317,"range":{"start_line":312,"start_character":4,"end_line":317,"end_character":56},"updated":"2017-12-06 07:26:19.000000000","message":"This testcase should fail if you ensured the validation.","commit_id":"fa040b835406dc44957f734c4d528a1b3327280b"}],"releasenotes/notes/releasenotes/notes/bug-1735337-remove-skip-quota-validation-flag-2ecb24143f1f1292.yaml":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"f1208338d030f1fa58504c2c34da1adec70fda4b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Quota validations are now forced for all APIs. skip_validation flag is"},{"line_number":4,"context_line":"    now removed from the request body for the quota-set update API."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df87a7cf_f1cd5831","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":50},"updated":"2017-12-07 01:03:42.000000000","message":"for all APIs?","commit_id":"7310676502f34a3e38329995731e12bcd5331210"}]}