)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6f420acf244936a208d5c10d9b820e814388b9b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Solving permission errors due to directory ownership on NFS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We do the same check for the GlusterfsBackupDriver"},{"line_number":10,"context_line":"Amended to fix dependency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic57c122311039af159c0cfc083e6e9349702d1e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf8cb3f7_430dbb3c","line":9,"updated":"2017-12-21 14:29:19.000000000","message":"Should explain what this patch does -- uses chgrp+chmod to set permissions on the directories, etc.","commit_id":"773e264a1dd3aca0023be582fbd94c720eef35af"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6f420acf244936a208d5c10d9b820e814388b9b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Solving permission errors due to directory ownership on NFS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We do the same check for the GlusterfsBackupDriver"},{"line_number":10,"context_line":"Amended to fix dependency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic57c122311039af159c0cfc083e6e9349702d1e4"},{"line_number":13,"context_line":"Closes-Bug: #1715456"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf8cb3f7_e31e4f6f","line":10,"updated":"2017-12-21 14:29:19.000000000","message":"This isn\u0027t needed in the commit message.","commit_id":"773e264a1dd3aca0023be582fbd94c720eef35af"}],"cinder/backup/drivers/nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7a4ef97d34c9d1d549c5763d0c2907e39e7863a7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if group_id !\u003d current_group_id:"},{"line_number":88,"context_line":"            cmd \u003d [\u0027chgrp\u0027, group_id, mount_path]"},{"line_number":89,"context_line":"            self._execute(*cmd, root_helper\u003dself._root_helper,"},{"line_number":90,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if not (current_mode \u0026 stat.S_IWGRP):"},{"line_number":93,"context_line":"            cmd \u003d [\u0027chmod\u0027, \u0027g+w\u0027, mount_path]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_8362f515","line":90,"updated":"2017-12-01 21:37:50.000000000","message":"Cinder really shouldn\u0027t be running \"sudo chgrp\" to set file permissions like this -- we don\u0027t know that this is the right thing to do for all deployments.\n\nPermissions can and should be set for Cinder to be able to write to the share outside of cinder-backup as part of the deployment.","commit_id":"d914c523a4ab56a6c2bc26934dea9110ddb69b8e"}],"cinder/tests/unit/backup/drivers/test_backup_nfs.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5f07d587821d4fccb21d0808ddccbc93c303304c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.override_config(\u0027backup_mount_point_base\u0027,"},{"line_number":157,"context_line":"                             FAKE_BACKUP_MOUNT_POINT_BASE)"},{"line_number":158,"context_line":"        self.override_config(\u0027backup_file_size\u0027, 52428800)"},{"line_number":159,"context_line":"        mock_remotefsclient \u003d mock.Mock()"},{"line_number":160,"context_line":"        mock_remotefsclient.get_mount_point \u003d mock.Mock("},{"line_number":161,"context_line":"            return_value\u003dself.temp_dir)"},{"line_number":162,"context_line":"        self.mock_object(remotefs_brick, \u0027RemoteFsClient\u0027,"},{"line_number":163,"context_line":"                         return_value\u003dmock_remotefsclient)"},{"line_number":164,"context_line":"        # Remove tempdir."},{"line_number":165,"context_line":"        self.addCleanup(shutil.rmtree, self.temp_dir)"},{"line_number":166,"context_line":"        for _i in range(0, 32):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_62482e2c","line":163,"range":{"start_line":159,"start_character":0,"end_line":163,"end_character":58},"updated":"2018-02-13 17:20:30.000000000","message":"Many UT failures can be resolved by swapping these lines for something that mocks \u0027_init_backup_repo_path\u0027. I\u0027m going to rebase this patch, then upload another change set for this. I also have some tweaks to improve test_init_backup_repo_path.","commit_id":"2b0036eb11bb47f747e90b36a23c12f24a196d91"}]}