)]}'
{"cinder/tests/tempest/api/volume/test_volume_unicode.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"0e3806ca502dcec308b2bffbc5dcb77aa3b8a845","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        volume \u003d self.create_volume(description\u003ddescription)"},{"line_number":65,"context_line":"        vol_info \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":66,"context_line":"        self.assertEqual(description, vol_info[\u0027description\u0027])"},{"line_number":67,"context_line":"        snapshot \u003d self.create_snapshot(volume[\u0027id\u0027], description\u003ddescription)"},{"line_number":68,"context_line":"        snapshot_info \u003d self.snapshots_client.show_snapshot("},{"line_number":69,"context_line":"            snapshot[\u0027id\u0027])[\u0027snapshot\u0027]"},{"line_number":70,"context_line":"        self.assertEqual(description, snapshot_info[\u0027description\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_00207747","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":77},"updated":"2017-12-08 14:37:28.000000000","message":"FWIW the fact that the original test omitted the description on the snapshot and assumed it was copied from the volume was in fact the main bug and it was an incorrect assumption.\n\nThis is a reasonable fix for that issue, although I would make one minor suggestion; Perhaps add a case for,\nNo description provided to the volume, only to the snapshot.\n\nAnd it might be good to modify this case (or add another one) that provides different descriptions to the volume and snapshot.\n\nThat also might help identify backends that may be \"copying\" the description over which is another bug.","commit_id":"97d778ac66ebb28293ce808be0a0d5afacbc30ec"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"d96fedcc1f9341a431158a7e8e17e7bdead45ad8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        volume \u003d self.create_volume(description\u003ddescription)"},{"line_number":65,"context_line":"        vol_info \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":66,"context_line":"        self.assertEqual(description, vol_info[\u0027description\u0027])"},{"line_number":67,"context_line":"        snapshot \u003d self.create_snapshot(volume[\u0027id\u0027], description\u003ddescription)"},{"line_number":68,"context_line":"        snapshot_info \u003d self.snapshots_client.show_snapshot("},{"line_number":69,"context_line":"            snapshot[\u0027id\u0027])[\u0027snapshot\u0027]"},{"line_number":70,"context_line":"        self.assertEqual(description, snapshot_info[\u0027description\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_980632ce","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":77},"in_reply_to":"df87a7cf_00207747","updated":"2017-12-09 03:01:35.000000000","message":"@John, thanks a lot for your suggestions, :)\n\nThis test case is provide by (https://review.openstack.org/#/c/524946/), which is mainly to verify that the snapshot can be created successfully when the description of source volume contains non-ascii characters. I\u0027m still a little curious why our focus will be turned to the assumption that description of snapshot can be inherited from source volume\u0027s. Yeah, this assumption needs to be tested, but I think it maybe not this patch\u0027s issue, it\u0027s better to put it into another new test case in unit/tempest to verify this \u0027basic\u0027 function.\nI agree with your second suggestion to provide different descriptions to the volume and snapshot. And I also agree with Matt\u0027s snapshot tag check in (https://review.openstack.org/#/c/526502/)","commit_id":"97d778ac66ebb28293ce808be0a0d5afacbc30ec"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"819ac8be8e72f167c4ac9133799123ff2c0de496","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        volume \u003d self.create_volume(description\u003ddescription)"},{"line_number":65,"context_line":"        vol_info \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":66,"context_line":"        self.assertEqual(description, vol_info[\u0027description\u0027])"},{"line_number":67,"context_line":"        snapshot \u003d self.create_snapshot(volume[\u0027id\u0027], description\u003ddescription)"},{"line_number":68,"context_line":"        snapshot_info \u003d self.snapshots_client.show_snapshot("},{"line_number":69,"context_line":"            snapshot[\u0027id\u0027])[\u0027snapshot\u0027]"},{"line_number":70,"context_line":"        self.assertEqual(description, snapshot_info[\u0027description\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_c0536f38","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":77},"in_reply_to":"df87a7cf_00207747","updated":"2017-12-08 14:57:13.000000000","message":"That was my theory too, that some backends were copying name -\u003e description and returning that as the model_update, but I haven\u0027t found any example of a backend doing that yet in the cinder/volume/drivers/* code.","commit_id":"97d778ac66ebb28293ce808be0a0d5afacbc30ec"}]}