)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a1bd0e88e454592e711f2c83d04c60eac7d28bef","unresolved":false,"context_lines":[{"line_number":26,"context_line":"which does not exist."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I496e45608798a6a5d9606f9594feeb8b60855d1a"},{"line_number":29,"context_line":"Cloess-Bug: #1738254"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_de82e200","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":6},"updated":"2017-12-14 18:35:42.000000000","message":"Closes","commit_id":"7598b3dda60a8762a80d4d54ee044afb4f01b001"}],"cinder/volume/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8736aadcba82a04586082545224564ab3b7ea2a3","unresolved":false,"context_lines":[{"line_number":4497,"context_line":"            LOG.debug(\u0027Deleting attachment %(attachment_id)s.\u0027,"},{"line_number":4498,"context_line":"                      {\u0027attachment_id\u0027: attachment.id},"},{"line_number":4499,"context_line":"                      resource\u003dvref)"},{"line_number":4500,"context_line":"            self.driver.detach_volume(context, vref, attachment)"},{"line_number":4501,"context_line":"            if has_shared_connection is not None and not has_shared_connection:"},{"line_number":4502,"context_line":"                self.driver.remove_export(context.elevated(), vref)"},{"line_number":4503,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_798df079","line":4500,"range":{"start_line":4500,"start_character":24,"end_line":4500,"end_character":37},"updated":"2017-12-14 19:04:05.000000000","message":"I have no idea if this is safe to call when there is no connector.","commit_id":"4a0784228dc3ffda06e57d6d0bedc9480dabb962"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2e506221ceca18ee9bb5eb5a9d7500c9d854867f","unresolved":false,"context_lines":[{"line_number":4423,"context_line":"        \"\"\""},{"line_number":4424,"context_line":"        utils.require_driver_initialized(self.driver)"},{"line_number":4425,"context_line":"        connector \u003d attachment.connector"},{"line_number":4426,"context_line":"        if not connector:"},{"line_number":4427,"context_line":"            # It\u0027s possible to attach a volume to a shelved offloaded server"},{"line_number":4428,"context_line":"            # in nova, and a shelved offloaded server is not on a compute host,"},{"line_number":4429,"context_line":"            # which means the attachment was made without a host connector,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_398f672f","line":4426,"updated":"2017-12-14 19:51:55.000000000","message":"\u003e Issue is with force detach where we do not have the connector info.\n\nOK, so then this logic should be:\n\nif not connector and not Force:\n   return None\n\nCorrect?","commit_id":"98ad08057dc40cfa8083d4e8a6a8b3b743f4028a"}]}