)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"296019c5df21e34da43e7d93ad545eb501eae315","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Fake volume/snapshot object usage throughout the smbfs driver unit"},{"line_number":23,"context_line":"tests had to be updated due to the object changes performed by it."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Partial-Implements: bleuprint windows-smb-backup"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: Ideaacbf9d160f400bef53825103b671127252789"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa0c359_8b3459fd","line":25,"updated":"2018-02-14 17:43:09.000000000","message":"blueprint","commit_id":"32a08e4d6a18be743e936448f05f97113e80619c"}],"cinder/volume/drivers/windows/smbfs.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"bfc261ce02d60c5a3a7f4497f8875f4a60757c7c","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        backing_file \u003d snapshot.metadata.get(\u0027backing_file\u0027)"},{"line_number":519,"context_line":"        if not backing_file:"},{"line_number":520,"context_line":"            LOG.info(\"Could not find the snapshot backing file in the DB. \""},{"line_number":521,"context_line":"                     \"This may happen after an upgrade. Attempting to \""},{"line_number":522,"context_line":"                     \"to query the image as a fallback. This may fail if \""},{"line_number":523,"context_line":"                     \"the image is in-use.\")"},{"line_number":524,"context_line":"            backing_file \u003d super("},{"line_number":525,"context_line":"                WindowsSmbfsDriver, self)._get_snapshot_backing_file(snapshot)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_1c5ff8e5","line":522,"range":{"start_line":521,"start_character":67,"end_line":522,"end_character":24},"updated":"2018-01-22 17:11:28.000000000","message":"repeated to.  Not a blocker though.","commit_id":"b8266e7f7dbaa9546e02b8ed2184dd2b69b89eff"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"1c04f61f2c8499cc3f286c4010547fc57b55100b","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        backing_file \u003d snapshot.metadata.get(\u0027backing_file\u0027)"},{"line_number":519,"context_line":"        if not backing_file:"},{"line_number":520,"context_line":"            LOG.info(\"Could not find the snapshot backing file in the DB. \""},{"line_number":521,"context_line":"                     \"This may happen after an upgrade. Attempting to \""},{"line_number":522,"context_line":"                     \"to query the image as a fallback. This may fail if \""},{"line_number":523,"context_line":"                     \"the image is in-use.\")"},{"line_number":524,"context_line":"            backing_file \u003d super("},{"line_number":525,"context_line":"                WindowsSmbfsDriver, self)._get_snapshot_backing_file(snapshot)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_dcb430f5","line":522,"range":{"start_line":521,"start_character":67,"end_line":522,"end_character":24},"in_reply_to":"7f96bb07_1c5ff8e5","updated":"2018-01-22 17:30:58.000000000","message":"Whops, thanks for pointing it out.","commit_id":"b8266e7f7dbaa9546e02b8ed2184dd2b69b89eff"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"309b60478829cfbee6b23f1b74569521a3408be9","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        return ImageInfo(os.path.basename(path),"},{"line_number":399,"context_line":"                         backing_file_name)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _do_create_snapshot(self, snapshot, backing_file, new_snap_path):"},{"line_number":402,"context_line":"        if self._is_volume_attached(snapshot.volume):"},{"line_number":403,"context_line":"            LOG.debug(\"Snapshot is in-use. Performing Nova \""},{"line_number":404,"context_line":"                      \"assisted creation.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_5533bef6","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":27},"updated":"2018-01-30 17:25:48.000000000","message":"I\u0027m not seeing where this is called, but can we change things to return a model update so we avoid having DB access in the driver?","commit_id":"29a1af2b039d9f1fc8e70a9177347806ed5dbd29"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"76707c4304d3849defbfaae7c48eaa2b1690b52b","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        return ImageInfo(os.path.basename(path),"},{"line_number":399,"context_line":"                         backing_file_name)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _do_create_snapshot(self, snapshot, backing_file, new_snap_path):"},{"line_number":402,"context_line":"        if self._is_volume_attached(snapshot.volume):"},{"line_number":403,"context_line":"            LOG.debug(\"Snapshot is in-use. Performing Nova \""},{"line_number":404,"context_line":"                      \"assisted creation.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_f55e8a74","line":401,"range":{"start_line":401,"start_character":8,"end_line":401,"end_character":27},"in_reply_to":"5f93b717_5533bef6","updated":"2018-01-30 18:03:09.000000000","message":"This is called by the parent class.\n\nI thought about doing so but there are a few issues with this approach:\n- snapshots are used internally in a few cases in which the manager would not expect snapshot object changes\n- when deleting snapshots, we\u0027re updating the metadata for more recent snapshots as the backing file changes. For example, let\u0027s say we have a volume with snapshot A and snapshot B. When we delete snapshot A, the snapshot B metadata has to be updated.","commit_id":"29a1af2b039d9f1fc8e70a9177347806ed5dbd29"}]}