)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"1e91dff7862d718c02ad4e7799c64ceefa450485","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since NVMET target driver will be implemented it would be good to use"},{"line_number":10,"context_line":"the same config options both for NVMEoF and iSCSI targets. That\u0027s why"},{"line_number":11,"context_line":"this path renames iscsi_ip_address, iscsi_port and target_helper to"},{"line_number":12,"context_line":"target_ip_address, target_port and target_helper according to current"},{"line_number":13,"context_line":"deprecation policy."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_1ef02067","line":11,"range":{"start_line":11,"start_character":51,"end_line":11,"end_character":64},"updated":"2017-12-18 06:38:40.000000000","message":"iscsi_helper","commit_id":"6107a06b6944abe11e006e36e75ab83511272bb0"}],"cinder/volume/driver.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"149de5a8500d08140bbd6270a045c3ccacfebdf4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               default\u003d0,"},{"line_number":49,"context_line":"               min\u003d0, max\u003d100,"},{"line_number":50,"context_line":"               help\u003d\u0027The percentage of backend capacity is reserved\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027iscsi_target_prefix\u0027,"},{"line_number":52,"context_line":"               default\u003d\u0027iqn.2010-10.org.openstack:\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Prefix for iSCSI volumes\u0027),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027target_ip_address\u0027,"},{"line_number":55,"context_line":"               deprecated_name\u003d\u0027iscsi_ip_address\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_de5b9884","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":52},"updated":"2017-12-17 02:05:17.000000000","message":"this also can be deprecated to target_prefix. with the value of \u00272010-10.org.openstack:\u0027 \niscsi prefix is \u0027iqn.2010-10.org.openstack:\u0027\nnvmeof prefix is \u0027nqn.2010-10.org.openstack:\u0027","commit_id":"6107a06b6944abe11e006e36e75ab83511272bb0"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"149de5a8500d08140bbd6270a045c3ccacfebdf4","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                    \u0027Only used for tgtadm to specify backing device flags \u0027"},{"line_number":143,"context_line":"                    \u0027using bsoflags option. The specified string is passed \u0027"},{"line_number":144,"context_line":"                    \u0027as is to the underlying tool.\u0027),"},{"line_number":145,"context_line":"    cfg.StrOpt(\u0027iscsi_protocol\u0027,"},{"line_number":146,"context_line":"               default\u003d\u0027iscsi\u0027,"},{"line_number":147,"context_line":"               choices\u003d[\u0027iscsi\u0027, \u0027iser\u0027],"},{"line_number":148,"context_line":"               help\u003d\u0027Determines the iSCSI protocol for new iSCSI volumes, \u0027"},{"line_number":149,"context_line":"                    \u0027created with tgtadm or lioadm target helpers. In \u0027"},{"line_number":150,"context_line":"                    \u0027order to enable RDMA, this parameter should be set \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_5e76a808","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":41},"updated":"2017-12-17 02:05:17.000000000","message":"we can change this to traget_protocol with values of \ntcp and rdma","commit_id":"6107a06b6944abe11e006e36e75ab83511272bb0"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"1e91dff7862d718c02ad4e7799c64ceefa450485","unresolved":false,"context_lines":[{"line_number":50,"context_line":"               help\u003d\u0027The percentage of backend capacity is reserved\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027target_prefix\u0027,"},{"line_number":52,"context_line":"               deprecated_name\u003d\u0027iscsi_target_prefix\u0027,"},{"line_number":53,"context_line":"               default\u003d\u0027iqn.2010-10.org.openstack:\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027Prefix for iSCSI volumes\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027target_ip_address\u0027,"},{"line_number":56,"context_line":"               deprecated_name\u003d\u0027iscsi_ip_address\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_d1be1464","line":53,"range":{"start_line":53,"start_character":24,"end_line":53,"end_character":51},"updated":"2017-12-18 06:38:40.000000000","message":"the nvmeof start with nqn... so I was thinking that we just put the \u00272010-10.org.openstack:\u0027 and for iscsi we would add\niqn. and for nvmeof we would add the nqn.\nwhat do you think?","commit_id":"15451e846bf312c3de6f49c929b0c37f47677c72"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"68bec38087c56ec676df289772b3d4118adcaf9c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"               help\u003d\u0027The percentage of backend capacity is reserved\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027target_prefix\u0027,"},{"line_number":52,"context_line":"               deprecated_name\u003d\u0027iscsi_target_prefix\u0027,"},{"line_number":53,"context_line":"               default\u003d\u0027iqn.2010-10.org.openstack:\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027Prefix for iSCSI volumes\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027target_ip_address\u0027,"},{"line_number":56,"context_line":"               deprecated_name\u003d\u0027iscsi_ip_address\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_da84e960","line":53,"range":{"start_line":53,"start_character":24,"end_line":53,"end_character":51},"in_reply_to":"df87a7cf_d1be1464","updated":"2017-12-18 08:54:37.000000000","message":"I don\u0027t have a strong opinion on it yet.  Maybe it\u0027s a good idea to do it in a future but we have to not break existing deployments","commit_id":"15451e846bf312c3de6f49c929b0c37f47677c72"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"1e91dff7862d718c02ad4e7799c64ceefa450485","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    \u0027as is to the underlying tool.\u0027),"},{"line_number":146,"context_line":"    cfg.StrOpt(\u0027target_protocol\u0027,"},{"line_number":147,"context_line":"               deprecated_name\u003d\u0027iscsi_protocol\u0027,"},{"line_number":148,"context_line":"               default\u003d\u0027iscsi\u0027,"},{"line_number":149,"context_line":"               choices\u003d[\u0027iscsi\u0027, \u0027iser\u0027],"},{"line_number":150,"context_line":"               help\u003d\u0027Determines the iSCSI protocol for new iSCSI volumes, \u0027"},{"line_number":151,"context_line":"                    \u0027created with tgtadm or lioadm target helpers. In \u0027"},{"line_number":152,"context_line":"                    \u0027order to enable RDMA, this parameter should be set \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_d114d4a2","line":149,"range":{"start_line":148,"start_character":15,"end_line":149,"end_character":41},"updated":"2017-12-18 06:38:40.000000000","message":"is it possible to change the values [ \u0027tcp\u0027, \u0027rdma\u0027] to make more sense?","commit_id":"15451e846bf312c3de6f49c929b0c37f47677c72"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"68bec38087c56ec676df289772b3d4118adcaf9c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    \u0027as is to the underlying tool.\u0027),"},{"line_number":146,"context_line":"    cfg.StrOpt(\u0027target_protocol\u0027,"},{"line_number":147,"context_line":"               deprecated_name\u003d\u0027iscsi_protocol\u0027,"},{"line_number":148,"context_line":"               default\u003d\u0027iscsi\u0027,"},{"line_number":149,"context_line":"               choices\u003d[\u0027iscsi\u0027, \u0027iser\u0027],"},{"line_number":150,"context_line":"               help\u003d\u0027Determines the iSCSI protocol for new iSCSI volumes, \u0027"},{"line_number":151,"context_line":"                    \u0027created with tgtadm or lioadm target helpers. In \u0027"},{"line_number":152,"context_line":"                    \u0027order to enable RDMA, this parameter should be set \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_5a98d9be","line":149,"range":{"start_line":148,"start_character":15,"end_line":149,"end_character":41},"in_reply_to":"df87a7cf_d114d4a2","updated":"2017-12-18 08:54:37.000000000","message":"It should be done in scope of NVMeT patch","commit_id":"15451e846bf312c3de6f49c929b0c37f47677c72"}],"releasenotes/notes/rename-iscsi-target-config-options-24913d7452c4a58e.yaml":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"21f10b2bf0d26b203cbf8551855eef1e70327495","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``iscsi_ip_address``, ``iscsi_port`` and ``target_helper`` config options"},{"line_number":5,"context_line":"    are deprecated in flavor of ``target_ip_address``, ``target_port`` and"},{"line_number":6,"context_line":"    ``target_helper`` accordingly. Old config options will be removed in S"},{"line_number":7,"context_line":"    release."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df87a7cf_2a3effd9","line":6,"range":{"start_line":6,"start_character":73,"end_line":6,"end_character":74},"updated":"2017-12-16 22:59:25.000000000","message":"Change to \u0027T\u0027 release if this will be merged in Rocky timeframe","commit_id":"6107a06b6944abe11e006e36e75ab83511272bb0"}]}