)]}'
{"cinder/tests/unit/volume/drivers/test_qnap.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"68e220957fc3c5f4f9c81bde4865458ec94f4f55","unresolved":false,"context_lines":[{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    import xml.etree.cElementTree as ET"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    import xml.etree.ElementTree as ET"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ddt import data"},{"line_number":23,"context_line":"from ddt import ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_cd452817","side":"PARENT","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":32},"updated":"2017-12-17 21:40:20.000000000","message":"Do we need \"from defusedxml import ElementTree as ET\" in the except block on the right hand side?","commit_id":"4e51d33861f40b623027b1d727908990b2fc5950"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"43b3b8449064029699ce990769283ad93a6eb11d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    import xml.etree.cElementTree as ET"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    import xml.etree.ElementTree as ET"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ddt import data"},{"line_number":23,"context_line":"from ddt import ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_a948b82c","side":"PARENT","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":32},"in_reply_to":"df87a7cf_6bd14dfb","updated":"2017-12-18 16:20:13.000000000","message":"Got it.  Thanks.","commit_id":"4e51d33861f40b623027b1d727908990b2fc5950"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"99d0592ce932f3c273811834a8574fe93d1901a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    import xml.etree.cElementTree as ET"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    import xml.etree.ElementTree as ET"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ddt import data"},{"line_number":23,"context_line":"from ddt import ddt"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_6bd14dfb","side":"PARENT","line":20,"range":{"start_line":20,"start_character":21,"end_line":20,"end_character":32},"in_reply_to":"df87a7cf_cd452817","updated":"2017-12-18 11:43:07.000000000","message":"No, this was needed because some versions of the xml module may not have included cElementTree. defusedxml is guaranteed to have that, so no need to use a try/except on the import.","commit_id":"4e51d33861f40b623027b1d727908990b2fc5950"}],"cinder/volume/drivers/qnap.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"68e220957fc3c5f4f9c81bde4865458ec94f4f55","unresolved":false,"context_lines":[{"line_number":26,"context_line":"try:"},{"line_number":27,"context_line":"    import xml.etree.cElementTree as ET"},{"line_number":28,"context_line":"except ImportError:"},{"line_number":29,"context_line":"    import xml.etree.ElementTree as ET"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from oslo_concurrency import lockutils"},{"line_number":32,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_8d4f2033","side":"PARENT","line":29,"range":{"start_line":29,"start_character":21,"end_line":29,"end_character":32},"updated":"2017-12-17 21:40:20.000000000","message":"Do we need \"from defusedxml import ElementTree as ET\" in the except block on the right hand side?","commit_id":"4e51d33861f40b623027b1d727908990b2fc5950"}]}