)]}'
{"cinder/api/schemas/workers.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"748a4a92c7837da72214035f2c54f7f29bbb6589","unresolved":false,"context_lines":[{"line_number":23,"context_line":"cleanup \u003d {"},{"line_number":24,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":25,"context_line":"    \u0027properties\u0027: {"},{"line_number":26,"context_line":"        \u0027cluster_name\u0027: parameter_types.name_allow_zero_min_length,"},{"line_number":27,"context_line":"        \u0027disabled\u0027: parameter_types.optional_boolean,"},{"line_number":28,"context_line":"        \u0027host\u0027: parameter_types.hostname,"},{"line_number":29,"context_line":"        \u0027is_up\u0027: parameter_types.optional_boolean,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_e8977f8f","line":26,"updated":"2018-03-23 11:10:43.000000000","message":"-1: This has to be the same type as host","commit_id":"3162cc336f48526f0a8ea4107a987524c90c9550"}],"cinder/api/v3/workers.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e7ab15b67412fb9e8d36fcc85178e9b5c9250715","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":37,"context_line":"        self.sch_api \u003d sch_rpc.SchedulerAPI()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _prepare_params(self, ctxt, params):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        for boolean in (\u0027disabled\u0027, \u0027is_up\u0027):"},{"line_number":42,"context_line":"            if params.get(boolean) is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_58693323","line":39,"range":{"start_line":39,"start_character":5,"end_line":39,"end_character":44},"updated":"2017-12-21 02:56:11.000000000","message":"The method is incorrect now:) and I think we don\u0027t need this method we can directly convert them outside.","commit_id":"2ee7a4bb179a25f65c02598d7d10926b63e27a6a"}],"cinder/api/validation/parameter_types.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"748a4a92c7837da72214035f2c54f7f29bbb6589","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # not allow for underscores in hostnames. However, this"},{"line_number":200,"context_line":"    # schema allows them, because it sometimes occurs in"},{"line_number":201,"context_line":"    # real systems."},{"line_number":202,"context_line":"    \u0027pattern\u0027: \u0027^[a-zA-Z0-9-._ ]*$\u0027"},{"line_number":203,"context_line":"}"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_8865a3b7","line":202,"updated":"2018-03-23 11:10:43.000000000","message":"-1: This is not correct, we are talking about the \"host\" concept as used by Cinder, which can include @ and # as well.  You can check what I mean in method `_filter_host` in cinder/db/sqlalchemy/api.py","commit_id":"3162cc336f48526f0a8ea4107a987524c90c9550"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"748a4a92c7837da72214035f2c54f7f29bbb6589","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"optional_uuid \u003d {\u0027oneOf\u0027: [{\u0027type\u0027: \u0027null\u0027},"},{"line_number":216,"context_line":"                           {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027}]}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"optional_boolean \u003d {\u0027oneOf\u0027: [{\u0027type\u0027: \u0027null\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_c8b15b46","line":216,"updated":"2018-03-23 11:10:43.000000000","message":"-1: We already have a type for this, `uuid_allow_null`, even if it is missing the format part on the string.","commit_id":"3162cc336f48526f0a8ea4107a987524c90c9550"},{"author":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"change_message_id":"29cb6866d7a508c1c7667b2cc20921cfc66e51ed","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"optional_uuid \u003d {\u0027oneOf\u0027: [{\u0027type\u0027: \u0027null\u0027},"},{"line_number":216,"context_line":"                           {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027}]}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"optional_boolean \u003d {\u0027oneOf\u0027: [{\u0027type\u0027: \u0027null\u0027},"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_91b6a78a","line":216,"in_reply_to":"df7087c5_c8b15b46","updated":"2018-04-06 09:12:21.000000000","message":"Here \u0027uuid_allow_null\u0027 is not used, because,On master, for resource_id parameter if user passes value as null then it is accepted, and if user passes some value in string then it should be of type uuid.\nTo address this comment if I create a format like \u0027optional_uuid\u0027, and if user passes invalid value like(\u0027resource_id\u0027: \u0027  \u0027) then user is getting message like (\"Invalid input for field/attribute resource_id. Value: . u\u0027  \u0027 is not a \u0027optional_uuid\u0027\").\non master user is getting message(\"message\": \"Invalid input for field/attribute resource_id. Value: . \u0027  \u0027 is not a \u0027uuid\u0027\")","commit_id":"3162cc336f48526f0a8ea4107a987524c90c9550"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"748a4a92c7837da72214035f2c54f7f29bbb6589","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                               \u0027enum\u0027: [True, \u0027True\u0027, \u0027TRUE\u0027, \u0027true\u0027, \u00271\u0027,"},{"line_number":222,"context_line":"                                        \u0027ON\u0027, \u0027On\u0027, \u0027on\u0027, \u0027YES\u0027, \u0027Yes\u0027, \u0027yes\u0027,"},{"line_number":223,"context_line":"                                        \u0027y\u0027, \u0027t\u0027, False, \u0027False\u0027, \u0027FALSE\u0027,"},{"line_number":224,"context_line":"                                        \u0027false\u0027, \u00270\u0027, \u0027OFF\u0027, \u0027Off\u0027, \u0027off\u0027,"},{"line_number":225,"context_line":"                                        \u0027NO\u0027, \u0027No\u0027, \u0027no\u0027, \u0027n\u0027, \u0027f\u0027]}]}"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_a85f470d","line":224,"updated":"2018-03-23 11:10:43.000000000","message":"-1: What about TrUe, tRuE, and other such cases?  Using an enum here is not good enough.","commit_id":"3162cc336f48526f0a8ea4107a987524c90c9550"}]}