)]}'
{"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"b8ffb6291e44e2bbc173e1cd65975f1261001d20","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        try:"},{"line_number":593,"context_line":"            self.target_driver.extend_target(volume)"},{"line_number":594,"context_line":"        except Exception:"},{"line_number":595,"context_line":"            raise exception.TargetUpdateFailed(volume_id\u003dvolume.id)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":598,"context_line":"        \"\"\"Manages an existing LV."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_8fe9ac81","line":595,"updated":"2017-12-21 11:38:54.000000000","message":"I think it would help logging the initial exception.","commit_id":"9900c7bbff06286e2ea709f63dc11b3eb69bcc73"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"123923138a0fa91f1ac41116fa3c5ec5006bc6eb","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        try:"},{"line_number":593,"context_line":"            self.target_driver.extend_target(volume)"},{"line_number":594,"context_line":"        except Exception:"},{"line_number":595,"context_line":"            raise exception.TargetUpdateFailed(volume_id\u003dvolume.id)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":598,"context_line":"        \"\"\"Manages an existing LV."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_3ecbec53","line":595,"in_reply_to":"bf8cb3f7_8fe9ac81","updated":"2017-12-21 14:48:49.000000000","message":"Good call. Looks like I lost some things on my last refactoring of this.","commit_id":"9900c7bbff06286e2ea709f63dc11b3eb69bcc73"}],"cinder/volume/targets/iscsi.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"b8ffb6291e44e2bbc173e1cd65975f1261001d20","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        Note: This will cause IO disruption in most cases."},{"line_number":334,"context_line":"        \"\"\""},{"line_number":335,"context_line":"        iscsi_name \u003d \"%s%s\" % (self.configuration.target_prefix,"},{"line_number":336,"context_line":"                               volume[\u0027name\u0027])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        self._do_tgt_update(iscsi_name, force\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_2fa8a01d","line":335,"range":{"start_line":335,"start_character":50,"end_line":335,"end_character":63},"updated":"2017-12-21 11:38:54.000000000","message":"I think the actual config option is \"iscsi_target_prefix\". This will raise an exception.","commit_id":"9900c7bbff06286e2ea709f63dc11b3eb69bcc73"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"7c0eb188b7d6d2f770c789e034b20106b52345d6","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        Note: This will cause IO disruption in most cases."},{"line_number":334,"context_line":"        \"\"\""},{"line_number":335,"context_line":"        iscsi_name \u003d \"%s%s\" % (self.configuration.target_prefix,"},{"line_number":336,"context_line":"                               volume[\u0027name\u0027])"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        self._do_tgt_update(iscsi_name, force\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_3edc4c73","line":335,"range":{"start_line":335,"start_character":50,"end_line":335,"end_character":63},"in_reply_to":"bf8cb3f7_2fa8a01d","updated":"2017-12-21 14:37:15.000000000","message":"My bad on this one, looks like the patch renaming it merged yesterday and I forgot to do a git pull before fetching this change.","commit_id":"9900c7bbff06286e2ea709f63dc11b3eb69bcc73"}],"cinder/volume/targets/tgt.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"ab74f1dffda8c78c083aa5d1539a74de7c3b4b6f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        if force:"},{"line_number":117,"context_line":"            # Note: force may fail if there is active IO, but retry decorator"},{"line_number":118,"context_line":"            # should allow it to succeed on second attempt"},{"line_number":119,"context_line":"            args.add(\u0027-f\u0027)"},{"line_number":120,"context_line":"        (out, err) \u003d utils.execute(*args, run_as_root\u003dTrue)"},{"line_number":121,"context_line":"        LOG.debug(\"StdOut from tgt-admin --update: %s\", out)"},{"line_number":122,"context_line":"        LOG.debug(\"StdErr from tgt-admin --update: %s\", err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_b2f733f6","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":26},"updated":"2017-12-21 11:46:32.000000000","message":"This will fail as this object is a tuple. Using a list instead and calling \u0027append\u0027 should be fine.","commit_id":"9900c7bbff06286e2ea709f63dc11b3eb69bcc73"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"123923138a0fa91f1ac41116fa3c5ec5006bc6eb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        if force:"},{"line_number":117,"context_line":"            # Note: force may fail if there is active IO, but retry decorator"},{"line_number":118,"context_line":"            # should allow it to succeed on second attempt"},{"line_number":119,"context_line":"            args.add(\u0027-f\u0027)"},{"line_number":120,"context_line":"        (out, err) \u003d utils.execute(*args, run_as_root\u003dTrue)"},{"line_number":121,"context_line":"        LOG.debug(\"StdOut from tgt-admin --update: %s\", out)"},{"line_number":122,"context_line":"        LOG.debug(\"StdErr from tgt-admin --update: %s\", err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_fec4a442","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":26},"in_reply_to":"bf8cb3f7_b2f733f6","updated":"2017-12-21 14:48:49.000000000","message":"Oops. :)","commit_id":"9900c7bbff06286e2ea709f63dc11b3eb69bcc73"}]}