)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"119eb4eeaaf70879e9ab4efc619cc464556c9818","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        if (volume.status \u003d\u003d \u0027in-use\u0027 and not volume.multiattach"},{"line_number":1208,"context_line":"           and not volume.migration_status):"},{"line_number":1209,"context_line":"            raise exception.InvalidVolume("},{"line_number":1210,"context_line":"                reason\u003d_(\"non-multiattach volume is already attached\"))"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"        self._notify_about_volume_usage(context, volume,"},{"line_number":1213,"context_line":"                                        \"attach.start\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_6b9cd5bf","line":1210,"updated":"2018-01-08 18:48:49.000000000","message":"This will sound pretty clunky to someone who isn\u0027t familiar with multiattach.  I\u0027d suggest something more like \"volume is already attached, and multiple attachments are not enabled\".","commit_id":"4c5e6de11e92956a9315368e091b8c6c19240565"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"fddedde6fa96c081908dc7ea0ccbfa5f5e724425","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"           and not volume.migration_status):"},{"line_number":1209,"context_line":"            raise exception.InvalidVolume("},{"line_number":1210,"context_line":"                reason\u003d_(\"volume is already attached and multiple attachments \""},{"line_number":1211,"context_line":"                         \"are not enabled\"))"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"        self._notify_about_volume_usage(context, volume,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_6b8596ce","line":1211,"range":{"start_line":1211,"start_character":26,"end_line":1211,"end_character":41},"updated":"2018-01-09 18:42:08.000000000","message":"nit:\nsomething like \"volume is not of a multiattach capable type\" or something like that?  Just something to make it a bit more clear perhaps? I dunno, maybe too wordy and unnecessary but just an idea.","commit_id":"ff96af9ca0c3a63797cdb4c5acce49a41f3c00ec"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cb022974f0b024779516ff1ab7ea9e021a3d63b1","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"            raise exception.InvalidVolume("},{"line_number":1210,"context_line":"                reason\u003d_(\"volume is already attached and multiple attachments \""},{"line_number":1211,"context_line":"                         \"are not enabled\"))"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"        self._notify_about_volume_usage(context, volume,"},{"line_number":1215,"context_line":"                                        \"attach.start\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_adc97159","line":1212,"updated":"2018-01-09 20:55:58.000000000","message":"Ah, pep8 doesn\u0027t like the two blank lines. Need to get rid of one of those.","commit_id":"ff96af9ca0c3a63797cdb4c5acce49a41f3c00ec"}]}