)]}'
{"cinder/api/openstack/api_version_request.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# minimum version of the API supported."},{"line_number":121,"context_line":"# Explicitly using /v2 endpoints will still work"},{"line_number":122,"context_line":"_MIN_API_VERSION \u003d \"3.0\""},{"line_number":123,"context_line":"_MAX_API_VERSION \u003d \"3.50\""},{"line_number":124,"context_line":"_LEGACY_API_VERSION2 \u003d \"2.0\""},{"line_number":125,"context_line":"UPDATED \u003d \"2017-09-19T20:18:14Z\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_c50eb0e4","line":123,"range":{"start_line":123,"start_character":22,"end_line":123,"end_character":24},"updated":"2018-01-11 17:47:06.000000000","message":"Why are we jumping from 48 to 50?","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# minimum version of the API supported."},{"line_number":121,"context_line":"# Explicitly using /v2 endpoints will still work"},{"line_number":122,"context_line":"_MIN_API_VERSION \u003d \"3.0\""},{"line_number":123,"context_line":"_MAX_API_VERSION \u003d \"3.50\""},{"line_number":124,"context_line":"_LEGACY_API_VERSION2 \u003d \"2.0\""},{"line_number":125,"context_line":"UPDATED \u003d \"2017-09-19T20:18:14Z\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_489e3764","line":123,"range":{"start_line":123,"start_character":22,"end_line":123,"end_character":24},"in_reply_to":"7f96bb07_c50eb0e4","updated":"2018-01-11 18:37:20.000000000","message":"Because I have a 49 in flight here:  https://review.openstack.org/#/c/532702/","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"}],"cinder/volume/api.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"78db9e1b1a0550f2bfb59c0e9ebe4715513b8b00","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # NOTE(jdg): The whole \"some things are objects, some things"},{"line_number":200,"context_line":"        # are dictionaries\" is a real pain, particularly when the"},{"line_number":201,"context_line":"        # actual code differes from the unit test code.  I\u0027m going"},{"line_number":202,"context_line":"        # to make my life simple here and just check/convert if/when"},{"line_number":203,"context_line":"        # necessary."},{"line_number":204,"context_line":"        if isinstance(volume_type, dict):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_987a6d86","line":201,"range":{"start_line":201,"start_character":22,"end_line":201,"end_character":30},"updated":"2018-01-10 19:34:22.000000000","message":"differs","commit_id":"2117104e74527d44692f2c9dbc51dcec91065670"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"f3361c19f767f5a27cec481f3bd2ab76fa6b8f0e","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # NOTE(jdg): The whole \"some things are objects, some things"},{"line_number":200,"context_line":"        # are dictionaries\" is a real pain, particularly when the"},{"line_number":201,"context_line":"        # actual code differes from the unit test code.  I\u0027m going"},{"line_number":202,"context_line":"        # to make my life simple here and just check/convert if/when"},{"line_number":203,"context_line":"        # necessary."},{"line_number":204,"context_line":"        if isinstance(volume_type, dict):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_3900f834","line":201,"range":{"start_line":201,"start_character":22,"end_line":201,"end_character":30},"in_reply_to":"7f96bb07_987a6d86","updated":"2018-01-11 00:50:14.000000000","message":"Done","commit_id":"2117104e74527d44692f2c9dbc51dcec91065670"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"78db9e1b1a0550f2bfb59c0e9ebe4715513b8b00","unresolved":false,"context_lines":[{"line_number":1668,"context_line":"        # early as possible, but won\u0027t commit until we change the type. We"},{"line_number":1669,"context_line":"        # pass the reservations onward in case we need to roll back."},{"line_number":1670,"context_line":"        reservations \u003d quota_utils.get_volume_type_reservation("},{"line_number":1671,"context_line":"            context, volume, new_type[\u0027id\u0027], reserve_vol_type_only\u003dTrue)"},{"line_number":1672,"context_line":""},{"line_number":1673,"context_line":"        # Get old reservations"},{"line_number":1674,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_386f99c6","line":1671,"range":{"start_line":1671,"start_character":29,"end_line":1671,"end_character":43},"updated":"2018-01-10 19:34:22.000000000","message":"new_type_id","commit_id":"2117104e74527d44692f2c9dbc51dcec91065670"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"7697cfc290b818d69d1164be83f647c90a8f2060","unresolved":false,"context_lines":[{"line_number":1668,"context_line":"        # early as possible, but won\u0027t commit until we change the type. We"},{"line_number":1669,"context_line":"        # pass the reservations onward in case we need to roll back."},{"line_number":1670,"context_line":"        reservations \u003d quota_utils.get_volume_type_reservation("},{"line_number":1671,"context_line":"            context, volume, new_type[\u0027id\u0027], reserve_vol_type_only\u003dTrue)"},{"line_number":1672,"context_line":""},{"line_number":1673,"context_line":"        # Get old reservations"},{"line_number":1674,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_e1016ab1","line":1671,"range":{"start_line":1671,"start_character":29,"end_line":1671,"end_character":43},"in_reply_to":"7f96bb07_19889cc4","updated":"2018-01-11 10:07:54.000000000","message":"You used the variable everywhere else so it\u0027s more consistent. Thanks :)","commit_id":"2117104e74527d44692f2c9dbc51dcec91065670"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"f3361c19f767f5a27cec481f3bd2ab76fa6b8f0e","unresolved":false,"context_lines":[{"line_number":1668,"context_line":"        # early as possible, but won\u0027t commit until we change the type. We"},{"line_number":1669,"context_line":"        # pass the reservations onward in case we need to roll back."},{"line_number":1670,"context_line":"        reservations \u003d quota_utils.get_volume_type_reservation("},{"line_number":1671,"context_line":"            context, volume, new_type[\u0027id\u0027], reserve_vol_type_only\u003dTrue)"},{"line_number":1672,"context_line":""},{"line_number":1673,"context_line":"        # Get old reservations"},{"line_number":1674,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_19889cc4","line":1671,"range":{"start_line":1671,"start_character":29,"end_line":1671,"end_character":43},"in_reply_to":"7f96bb07_386f99c6","updated":"2018-01-11 00:50:14.000000000","message":"tomato, tomoto... but sure; if you prefer I use the variable from above I\u0027m fine with that.","commit_id":"2117104e74527d44692f2c9dbc51dcec91065670"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"ef1df43567cb380f7befb71abfc290495d25ed80","unresolved":false,"context_lines":[{"line_number":2056,"context_line":""},{"line_number":2057,"context_line":"        # Multiattach of bootable volumes is a special case with it\u0027s own"},{"line_number":2058,"context_line":"        # policy, check that here right off the bat"},{"line_number":2059,"context_line":"        if (vref.get(\u0027multiattach\u0027, False) and"},{"line_number":2060,"context_line":"                vref.status \u003d\u003d \u0027in-use\u0027 and"},{"line_number":2061,"context_line":"                vref.bootable):"},{"line_number":2062,"context_line":"            context.authorize("}],"source_content_type":"text/x-python","patch_set":10,"id":"7f96bb07_ad96704b","line":2059,"range":{"start_line":2059,"start_character":22,"end_line":2059,"end_character":33},"updated":"2018-01-16 19:01:45.000000000","message":"This should be fixed in the previous patch.","commit_id":"430e62fe4458944c32c94cb5920fbc4cc9263a4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"13bb4f5ff8a16b6db1e4a01b674f26c30cd62ea6","unresolved":false,"context_lines":[{"line_number":2056,"context_line":""},{"line_number":2057,"context_line":"        # Multiattach of bootable volumes is a special case with it\u0027s own"},{"line_number":2058,"context_line":"        # policy, check that here right off the bat"},{"line_number":2059,"context_line":"        if (vref.get(\u0027multiattach\u0027, False) and"},{"line_number":2060,"context_line":"                vref.status \u003d\u003d \u0027in-use\u0027 and"},{"line_number":2061,"context_line":"                vref.bootable):"},{"line_number":2062,"context_line":"            context.authorize("}],"source_content_type":"text/x-python","patch_set":10,"id":"7f96bb07_5b48c385","line":2059,"range":{"start_line":2059,"start_character":22,"end_line":2059,"end_character":33},"in_reply_to":"7f96bb07_ad96704b","updated":"2018-01-17 04:39:45.000000000","message":"Not sure how, the previous patch doesn\u0027t set the multiattach attribute on the volume, this patch adds that; or do you just mean fixing what I screwed up trying to change the parent?  In which case I just proposed the fix for that.","commit_id":"430e62fe4458944c32c94cb5920fbc4cc9263a4f"}],"doc/source/admin/blockstorage-volume-multiattach.rst":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _volume_multiattach:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Enable attaching a volume to multiple hosts"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"When configured to allow it and for backends that support it, Cinder"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_05bc98da","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":43},"updated":"2018-01-11 17:47:06.000000000","message":"I would say \u0027servers\u0027 here.","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _volume_multiattach:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Enable attaching a volume to multiple hosts"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"When configured to allow it and for backends that support it, Cinder"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_68fa1343","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":43},"in_reply_to":"7f96bb07_05bc98da","updated":"2018-01-11 18:37:20.000000000","message":"Done","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":11,"context_line":"controlled by policy.  If the user is not an admin or the policy file"},{"line_number":12,"context_line":"isn\u0027t modified only a single attachment per volume is allowed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition, the ability to attach a volume to multiple hosts/server"},{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_85cf487e","line":14,"range":{"start_line":14,"start_character":62,"end_line":14,"end_character":68},"updated":"2018-01-11 17:47:06.000000000","message":"servers","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":11,"context_line":"controlled by policy.  If the user is not an admin or the policy file"},{"line_number":12,"context_line":"isn\u0027t modified only a single attachment per volume is allowed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition, the ability to attach a volume to multiple hosts/server"},{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True:"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_08958fe4","line":14,"range":{"start_line":14,"start_character":62,"end_line":14,"end_character":68},"in_reply_to":"7f96bb07_85cf487e","updated":"2018-01-11 18:37:20.000000000","message":"Done","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition, the ability to attach a volume to multiple hosts/server"},{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach-volume"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_a5ccc489","line":16,"range":{"start_line":16,"start_character":39,"end_line":16,"end_character":40},"updated":"2018-01-11 17:47:06.000000000","message":"::","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition, the ability to attach a volume to multiple hosts/server"},{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach-volume"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_289acb13","line":16,"range":{"start_line":16,"start_character":39,"end_line":16,"end_character":40},"in_reply_to":"7f96bb07_a5ccc489","updated":"2018-01-11 18:37:20.000000000","message":"Done","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":16,"context_line":"capability setting of multiattach: True:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach-volume"},{"line_number":20,"context_line":"    $ cinder type-key multiattach-volume set multiattach\u003d\u0027\u003cis\u003e True\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_45c94076","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":35},"updated":"2018-01-11 17:47:06.000000000","message":"multiattach","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":16,"context_line":"capability setting of multiattach: True:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach-volume"},{"line_number":20,"context_line":"    $ cinder type-key multiattach-volume set multiattach\u003d\u0027\u003cis\u003e True\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_c89ec706","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":35},"in_reply_to":"7f96bb07_45c94076","updated":"2018-01-11 18:37:20.000000000","message":"Done","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach-volume"},{"line_number":20,"context_line":"    $ cinder type-key multiattach-volume set multiattach\u003d\u0027\u003cis\u003e True\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"},{"line_number":23,"context_line":"attachments.  You\u0027ll need to ensure you have a backend device that reports"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_45c5c03b","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"updated":"2018-01-11 17:47:06.000000000","message":"This block needs to be indented.","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach-volume"},{"line_number":20,"context_line":"    $ cinder type-key multiattach-volume set multiattach\u003d\u0027\u003cis\u003e True\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"},{"line_number":23,"context_line":"attachments.  You\u0027ll need to ensure you have a backend device that reports"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_a8857baf","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"7f96bb07_45c5c03b","updated":"2018-01-11 18:37:20.000000000","message":"Which block?","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":39,"context_line":"multiattach volumes (ie disable caching) and there\u0027s no mechanism currently to"},{"line_number":40,"context_line":"go back to ``in-use`` volumes and update them.  While going from"},{"line_number":41,"context_line":"``multiattach:True`` --\u003e ``multiattach:False`` isn\u0027t as problematic, it is"},{"line_number":42,"context_line":"error prone when it come to special cases like shelve, migrate etc.  The bottom"},{"line_number":43,"context_line":"line is it\u0027s *safer* to just avoid changing this setting on ``in-use`` volumes."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Finally, note that Cinder (or it\u0027s backends) don\u0027t do anything in terms of file"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_e5888c20","line":42,"range":{"start_line":42,"start_character":20,"end_line":42,"end_character":24},"updated":"2018-01-11 17:47:06.000000000","message":"comes","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":39,"context_line":"multiattach volumes (ie disable caching) and there\u0027s no mechanism currently to"},{"line_number":40,"context_line":"go back to ``in-use`` volumes and update them.  While going from"},{"line_number":41,"context_line":"``multiattach:True`` --\u003e ``multiattach:False`` isn\u0027t as problematic, it is"},{"line_number":42,"context_line":"error prone when it come to special cases like shelve, migrate etc.  The bottom"},{"line_number":43,"context_line":"line is it\u0027s *safer* to just avoid changing this setting on ``in-use`` volumes."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Finally, note that Cinder (or it\u0027s backends) don\u0027t do anything in terms of file"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_88b19f92","line":42,"range":{"start_line":42,"start_character":20,"end_line":42,"end_character":24},"in_reply_to":"7f96bb07_e5888c20","updated":"2018-01-11 18:37:20.000000000","message":"Done","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":42,"context_line":"error prone when it come to special cases like shelve, migrate etc.  The bottom"},{"line_number":43,"context_line":"line is it\u0027s *safer* to just avoid changing this setting on ``in-use`` volumes."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Finally, note that Cinder (or it\u0027s backends) don\u0027t do anything in terms of file"},{"line_number":46,"context_line":"systems or control of the volumes.  In other words, it\u0027s up to the user to"},{"line_number":47,"context_line":"ensure that a multiattach or clustered file system is used on the volumes."},{"line_number":48,"context_line":"Otherwise there may be a high probability of data corruption."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_65747c36","line":45,"range":{"start_line":45,"start_character":45,"end_line":45,"end_character":50},"updated":"2018-01-11 17:47:06.000000000","message":"doesn\u0027t","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6de8256084986e69df7c6ed68c00040b5b377715","unresolved":false,"context_lines":[{"line_number":42,"context_line":"error prone when it come to special cases like shelve, migrate etc.  The bottom"},{"line_number":43,"context_line":"line is it\u0027s *safer* to just avoid changing this setting on ``in-use`` volumes."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Finally, note that Cinder (or it\u0027s backends) don\u0027t do anything in terms of file"},{"line_number":46,"context_line":"systems or control of the volumes.  In other words, it\u0027s up to the user to"},{"line_number":47,"context_line":"ensure that a multiattach or clustered file system is used on the volumes."},{"line_number":48,"context_line":"Otherwise there may be a high probability of data corruption."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_4577003c","line":45,"range":{"start_line":45,"start_character":30,"end_line":45,"end_character":34},"updated":"2018-01-11 17:47:06.000000000","message":"its","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":42,"context_line":"error prone when it come to special cases like shelve, migrate etc.  The bottom"},{"line_number":43,"context_line":"line is it\u0027s *safer* to just avoid changing this setting on ``in-use`` volumes."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Finally, note that Cinder (or it\u0027s backends) don\u0027t do anything in terms of file"},{"line_number":46,"context_line":"systems or control of the volumes.  In other words, it\u0027s up to the user to"},{"line_number":47,"context_line":"ensure that a multiattach or clustered file system is used on the volumes."},{"line_number":48,"context_line":"Otherwise there may be a high probability of data corruption."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_a8aedb2b","line":45,"range":{"start_line":45,"start_character":30,"end_line":45,"end_character":34},"in_reply_to":"7f96bb07_4577003c","updated":"2018-01-11 18:37:20.000000000","message":"Done","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b55960414e797a31adb3723c8689f1c409baf393","unresolved":false,"context_lines":[{"line_number":42,"context_line":"error prone when it come to special cases like shelve, migrate etc.  The bottom"},{"line_number":43,"context_line":"line is it\u0027s *safer* to just avoid changing this setting on ``in-use`` volumes."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Finally, note that Cinder (or it\u0027s backends) don\u0027t do anything in terms of file"},{"line_number":46,"context_line":"systems or control of the volumes.  In other words, it\u0027s up to the user to"},{"line_number":47,"context_line":"ensure that a multiattach or clustered file system is used on the volumes."},{"line_number":48,"context_line":"Otherwise there may be a high probability of data corruption."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f96bb07_48ab971c","line":45,"range":{"start_line":45,"start_character":45,"end_line":45,"end_character":50},"in_reply_to":"7f96bb07_65747c36","updated":"2018-01-11 18:37:20.000000000","message":"Done","commit_id":"f639ac2490e1c7409a87a4b73521bddf01002f4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"ef1df43567cb380f7befb71abfc290495d25ed80","unresolved":false,"context_lines":[{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach"},{"line_number":20,"context_line":"    $ cinder type-key multiattach set multiattach\u003dTrue"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_08f672fa","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"updated":"2018-01-16 19:01:45.000000000","message":"With 3 whitespaces the doc build succeeds.","commit_id":"430e62fe4458944c32c94cb5920fbc4cc9263a4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"ef1df43567cb380f7befb71abfc290495d25ed80","unresolved":false,"context_lines":[{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach"},{"line_number":20,"context_line":"    $ cinder type-key multiattach set multiattach\u003dTrue"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_8d29349c","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":35},"updated":"2018-01-16 19:01:45.000000000","message":"multiattach","commit_id":"430e62fe4458944c32c94cb5920fbc4cc9263a4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"13bb4f5ff8a16b6db1e4a01b674f26c30cd62ea6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach"},{"line_number":20,"context_line":"    $ cinder type-key multiattach set multiattach\u003dTrue"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_3b11375e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"in_reply_to":"7f96bb07_08f672fa","updated":"2018-01-17 04:39:45.000000000","message":"Done","commit_id":"430e62fe4458944c32c94cb5920fbc4cc9263a4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"13bb4f5ff8a16b6db1e4a01b674f26c30cd62ea6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach"},{"line_number":20,"context_line":"    $ cinder type-key multiattach set multiattach\u003dTrue"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_fb0e6f39","line":19,"range":{"start_line":19,"start_character":25,"end_line":19,"end_character":35},"in_reply_to":"7f96bb07_8d29349c","updated":"2018-01-17 04:39:45.000000000","message":"Done","commit_id":"430e62fe4458944c32c94cb5920fbc4cc9263a4f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"ef1df43567cb380f7befb71abfc290495d25ed80","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach"},{"line_number":20,"context_line":"    $ cinder type-key multiattach set multiattach\u003dTrue"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"},{"line_number":23,"context_line":"attachments.  You\u0027ll need to ensure you have a backend device that reports"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_c8dbaa79","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":4},"updated":"2018-01-16 19:01:45.000000000","message":"With 3 whitespaces the doc build succeeds.","commit_id":"430e62fe4458944c32c94cb5920fbc4cc9263a4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"13bb4f5ff8a16b6db1e4a01b674f26c30cd62ea6","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"    $ cinder type-create multiatach"},{"line_number":20,"context_line":"    $ cinder type-key multiattach set multiattach\u003dTrue"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Now any volume of this type is capable of having multiple simultaneous"},{"line_number":23,"context_line":"attachments.  You\u0027ll need to ensure you have a backend device that reports"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f96bb07_1b0c7b3f","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":4},"in_reply_to":"7f96bb07_c8dbaa79","updated":"2018-01-17 04:39:45.000000000","message":"Done","commit_id":"430e62fe4458944c32c94cb5920fbc4cc9263a4f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5957cfd8e41d55bd34ee4c1ac13f6754292997e2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"   $ cinder type-create multiattach"},{"line_number":20,"context_line":"   $ cinder type-key multiattach set multiattach\u003d\"\u003cis\u003e True\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f96bb07_d977f8d3","line":18,"updated":"2018-01-17 01:23:11.000000000","message":"Not sure if it will like this. Might need a blank line after the code-block directive.","commit_id":"0f0d631e4f36316fc2f31759f47dd758b7beb759"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"13bb4f5ff8a16b6db1e4a01b674f26c30cd62ea6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"   $ cinder type-create multiattach"},{"line_number":20,"context_line":"   $ cinder type-key multiattach set multiattach\u003d\"\u003cis\u003e True\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f96bb07_4da1de45","line":18,"in_reply_to":"7f96bb07_1c7b0e7b","updated":"2018-01-17 04:39:45.000000000","message":"Thanks Sean, I don\u0027t know why I refuse to run docs build locally :)","commit_id":"0f0d631e4f36316fc2f31759f47dd758b7beb759"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"6e3745a972971e6d4d2ba27b92a093f2c05045b0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"   $ cinder type-create multiattach"},{"line_number":20,"context_line":"   $ cinder type-key multiattach set multiattach\u003d\"\u003cis\u003e True\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f96bb07_466e982f","line":18,"in_reply_to":"7f96bb07_cdf72e59","updated":"2018-01-17 09:07:57.000000000","message":"Sorry, my bad, forgot the blank line. :/","commit_id":"0f0d631e4f36316fc2f31759f47dd758b7beb759"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"13bb4f5ff8a16b6db1e4a01b674f26c30cd62ea6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"   $ cinder type-create multiattach"},{"line_number":20,"context_line":"   $ cinder type-key multiattach set multiattach\u003d\"\u003cis\u003e True\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f96bb07_cdf72e59","line":18,"in_reply_to":"7f96bb07_d977f8d3","updated":"2018-01-17 04:39:45.000000000","message":"Done","commit_id":"0f0d631e4f36316fc2f31759f47dd758b7beb759"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1b4aab39eb9fb191428ac2fc62b58f8c498fe53","unresolved":false,"context_lines":[{"line_number":15,"context_line":"requires that the volume is of a special type that includes an extra-spec"},{"line_number":16,"context_line":"capability setting of multiattach: True::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":"   $ cinder type-create multiattach"},{"line_number":20,"context_line":"   $ cinder type-key multiattach set multiattach\u003d\"\u003cis\u003e True\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"7f96bb07_1c7b0e7b","line":18,"in_reply_to":"7f96bb07_d977f8d3","updated":"2018-01-17 01:34:02.000000000","message":"Yep, ran locally. This is going to blow up.","commit_id":"0f0d631e4f36316fc2f31759f47dd758b7beb759"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f474bf2ed121b325e68149945182dffd51691133","unresolved":false,"context_lines":[{"line_number":43,"context_line":"error prone when it comes to special cases like shelve, migrate etc.  The bottom"},{"line_number":44,"context_line":"line is it\u0027s *safer* to just avoid changing this setting on ``in-use`` volumes."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Finally, note that Cinder (nor its backends) does not do anything in terms of file"},{"line_number":47,"context_line":"systems or control of the volumes.  In other words, it\u0027s up to the user to"},{"line_number":48,"context_line":"ensure that a multiattach or clustered file system is used on the volumes."},{"line_number":49,"context_line":"Otherwise there may be a high probability of data corruption."}],"source_content_type":"text/x-rst","patch_set":15,"id":"7f96bb07_e1c9b558","line":46,"range":{"start_line":46,"start_character":9,"end_line":46,"end_character":56},"updated":"2018-01-17 23:13:58.000000000","message":"I think this should say \u0027note that Cinder (nor its backends) do anything","commit_id":"9223575fccc40015184c2ce14afd47cf2d8374db"}]}