)]}'
{"cinder/tests/unit/volume/test_snapshot.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"1c49125f49d346d0e39bc27720399c0a476aaf28","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                          volume_api.create_snapshot_in_db,"},{"line_number":232,"context_line":"                          self.context, test_volume, \"fake_snapshot_name\","},{"line_number":233,"context_line":"                          \"fake_description\", False, \"fake_metadata\", None,"},{"line_number":234,"context_line":"                          commit_quota\u003dFalse)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def test_create_snapshot_failed_maintenance(self):"},{"line_number":237,"context_line":"        \"\"\"Test exception handling when create snapshot in maintenance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_b929a537","line":234,"updated":"2018-01-10 11:16:22.000000000","message":"Looks like this test does not cover what has been changed. \"QUOTAS.reserve\" could be mocked and make sure it\u0027s not called when the metadata provided is invalid.","commit_id":"4a4bc2825fe751a63b4b346da081c7531ff9d034"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"e5b0b87d5c883291bad2934337f95b40cbcd0073","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        mock_get.return_value \u003d test_volume"},{"line_number":228,"context_line":"        volume_api \u003d cinder.volume.api.API()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        with mock.patch.object(QUOTAS, \u0027add_volume_type_opts\u0027),\\"},{"line_number":231,"context_line":"            mock.patch.object(QUOTAS, \u0027reserve\u0027) as mock_reserve,\\"},{"line_number":232,"context_line":"                mock.patch.object(QUOTAS, \u0027commit\u0027) as mock_commit:"},{"line_number":233,"context_line":"            self.assertRaises(exception.InvalidInput,"},{"line_number":234,"context_line":"                              volume_api.create_snapshot_in_db,"},{"line_number":235,"context_line":"                              self.context, test_volume, \"fake_snapshot_name\","}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_527356e8","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":67},"updated":"2018-01-11 07:29:53.000000000","message":"Should use mock.patch decorator instead.","commit_id":"3c6d082d711521b44342f0999dd93c4eaf3d2947"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4f79db4eaa2c0a266f8dc29a5dff132ec6403295","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        mock_get.return_value \u003d test_volume"},{"line_number":228,"context_line":"        volume_api \u003d cinder.volume.api.API()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        with mock.patch.object(QUOTAS, \u0027add_volume_type_opts\u0027),\\"},{"line_number":231,"context_line":"            mock.patch.object(QUOTAS, \u0027reserve\u0027) as mock_reserve,\\"},{"line_number":232,"context_line":"                mock.patch.object(QUOTAS, \u0027commit\u0027) as mock_commit:"},{"line_number":233,"context_line":"            self.assertRaises(exception.InvalidInput,"},{"line_number":234,"context_line":"                              volume_api.create_snapshot_in_db,"},{"line_number":235,"context_line":"                              self.context, test_volume, \"fake_snapshot_name\","}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_ec2cfe9a","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":67},"in_reply_to":"7f96bb07_527356e8","updated":"2018-01-11 13:19:28.000000000","message":"We use both ways. This should be fine to use a with-block inside the test.","commit_id":"3c6d082d711521b44342f0999dd93c4eaf3d2947"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"7e4684406401203724ddc8c41f5988858c499b85","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        mock_get.return_value \u003d test_volume"},{"line_number":228,"context_line":"        volume_api \u003d cinder.volume.api.API()"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        with mock.patch.object(QUOTAS, \u0027add_volume_type_opts\u0027),\\"},{"line_number":231,"context_line":"            mock.patch.object(QUOTAS, \u0027reserve\u0027) as mock_reserve,\\"},{"line_number":232,"context_line":"                mock.patch.object(QUOTAS, \u0027commit\u0027) as mock_commit:"},{"line_number":233,"context_line":"            self.assertRaises(exception.InvalidInput,"},{"line_number":234,"context_line":"                              volume_api.create_snapshot_in_db,"},{"line_number":235,"context_line":"                              self.context, test_volume, \"fake_snapshot_name\","}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_ac5ef6e3","line":232,"range":{"start_line":230,"start_character":0,"end_line":232,"end_character":67},"in_reply_to":"7f96bb07_ec2cfe9a","updated":"2018-01-11 13:29:29.000000000","message":"Ok, I see.","commit_id":"3c6d082d711521b44342f0999dd93c4eaf3d2947"}]}