)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2e9951db2db265761c78dac8d0215a894858882d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"INFINIDAT: add missing connection_info params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Always add target_portals, target_iqns and target_luns to"},{"line_number":10,"context_line":"connection_info to support iSCSI multipath. Multi-attach will not work"},{"line_number":11,"context_line":"without these keys."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3187a9f5b4aaf6b6b3e11f8c1f109c2e21ee88fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_df72c649","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":56},"updated":"2018-01-15 03:12:45.000000000","message":"This is not clear to state whether this commit is meant to fix, multipath or multi-attach?","commit_id":"64e37afb43846064eeb14eb12aa8e007421ac211"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"0785bf98e27810c77692f88f9dfb6312d536122e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"INFINIDAT: add missing connection_info params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Always add target_portals, target_iqns and target_luns to"},{"line_number":10,"context_line":"connection_info to support iSCSI multipath. Multi-attach will not work"},{"line_number":11,"context_line":"without these keys."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3187a9f5b4aaf6b6b3e11f8c1f109c2e21ee88fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_dc385fef","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":56},"in_reply_to":"7f96bb07_15f79ff7","updated":"2018-01-16 12:05:41.000000000","message":"Done","commit_id":"64e37afb43846064eeb14eb12aa8e007421ac211"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"dff941557b247543dd97d6ca119bc952e069ed27","unresolved":false,"context_lines":[{"line_number":7,"context_line":"INFINIDAT: add missing connection_info params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Always add target_portals, target_iqns and target_luns to"},{"line_number":10,"context_line":"connection_info to support iSCSI multipath. Multi-attach will not work"},{"line_number":11,"context_line":"without these keys."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3187a9f5b4aaf6b6b3e11f8c1f109c2e21ee88fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_5928f2e0","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":56},"in_reply_to":"7f96bb07_15f79ff7","updated":"2018-01-16 02:00:17.000000000","message":"Yes, it\u0027s not clear why lacking target_portals/target_iqns/target_luns in connection_info will affect multiattach.","commit_id":"64e37afb43846064eeb14eb12aa8e007421ac211"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"0785bf98e27810c77692f88f9dfb6312d536122e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"INFINIDAT: add missing connection_info params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Always add target_portals, target_iqns and target_luns to"},{"line_number":10,"context_line":"connection_info to support iSCSI multipath. Multi-attach will not work"},{"line_number":11,"context_line":"without these keys."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3187a9f5b4aaf6b6b3e11f8c1f109c2e21ee88fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_5c7e8faf","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":56},"in_reply_to":"7f96bb07_5928f2e0","updated":"2018-01-16 12:05:41.000000000","message":"Better checking of our CI showed that this change affects volume attachment and cleanup, perhaps due to the way discovery is done in _get_ips_iqns_luns:\nhttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L166\n\nI will change the commit message accordingly.","commit_id":"64e37afb43846064eeb14eb12aa8e007421ac211"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"0785bf98e27810c77692f88f9dfb6312d536122e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"INFINIDAT: add missing connection_info params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Always add target_portals, target_iqns and target_luns to"},{"line_number":10,"context_line":"connection_info to support iSCSI multipath. Multi-attach will not work"},{"line_number":11,"context_line":"without these keys."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3187a9f5b4aaf6b6b3e11f8c1f109c2e21ee88fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_aea7834f","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":56},"in_reply_to":"7f96bb07_df72c649","updated":"2018-01-16 12:05:41.000000000","message":"The fix is for both. Multi-attach cannot work without fixing iSCSI multipath, which at the moment, doesn\u0027t work correctly with the current parameters we pass.","commit_id":"64e37afb43846064eeb14eb12aa8e007421ac211"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"09c2f77f718e76dfc4a8c9987af0f32f93c09133","unresolved":false,"context_lines":[{"line_number":7,"context_line":"INFINIDAT: add missing connection_info params"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Always add target_portals, target_iqns and target_luns to"},{"line_number":10,"context_line":"connection_info to support iSCSI multipath. Multi-attach will not work"},{"line_number":11,"context_line":"without these keys."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3187a9f5b4aaf6b6b3e11f8c1f109c2e21ee88fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_15f79ff7","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":56},"in_reply_to":"7f96bb07_df72c649","updated":"2018-01-15 14:17:24.000000000","message":"Yeah, should actually state multipath here to avoid confusion with the current work being done for multiattach.","commit_id":"64e37afb43846064eeb14eb12aa8e007421ac211"}],"cinder/volume/drivers/infinidat.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"2e9951db2db265761c78dac8d0215a894858882d","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                           target_portal\u003dtarget_portals[0],"},{"line_number":371,"context_line":"                           target_iqn\u003dtarget_iqns[0],"},{"line_number":372,"context_line":"                           target_lun\u003dtarget_luns[0])"},{"line_number":373,"context_line":"        if len(target_portals) \u003e 1:"},{"line_number":374,"context_line":"            # multiple network spaces defined"},{"line_number":375,"context_line":"            result_data.update(dict(target_portals\u003dtarget_portals,"},{"line_number":376,"context_line":"                                    target_iqns\u003dtarget_iqns,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_7ae94018","side":"PARENT","line":373,"updated":"2018-01-15 03:12:45.000000000","message":"This should be changed like this, especially we now support \"multipath\" paremter in connection info.","commit_id":"e7582b14bf0ffd9ce73c995aebe1a8fd7ab322fe"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"0785bf98e27810c77692f88f9dfb6312d536122e","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                           target_portal\u003dtarget_portals[0],"},{"line_number":371,"context_line":"                           target_iqn\u003dtarget_iqns[0],"},{"line_number":372,"context_line":"                           target_lun\u003dtarget_luns[0])"},{"line_number":373,"context_line":"        if len(target_portals) \u003e 1:"},{"line_number":374,"context_line":"            # multiple network spaces defined"},{"line_number":375,"context_line":"            result_data.update(dict(target_portals\u003dtarget_portals,"},{"line_number":376,"context_line":"                                    target_iqns\u003dtarget_iqns,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_fc48bb87","side":"PARENT","line":373,"in_reply_to":"7f96bb07_15823f50","updated":"2018-01-16 12:05:41.000000000","message":"Done","commit_id":"e7582b14bf0ffd9ce73c995aebe1a8fd7ab322fe"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"dff941557b247543dd97d6ca119bc952e069ed27","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                           target_portal\u003dtarget_portals[0],"},{"line_number":371,"context_line":"                           target_iqn\u003dtarget_iqns[0],"},{"line_number":372,"context_line":"                           target_lun\u003dtarget_luns[0])"},{"line_number":373,"context_line":"        if len(target_portals) \u003e 1:"},{"line_number":374,"context_line":"            # multiple network spaces defined"},{"line_number":375,"context_line":"            result_data.update(dict(target_portals\u003dtarget_portals,"},{"line_number":376,"context_line":"                                    target_iqns\u003dtarget_iqns,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_997e7a69","side":"PARENT","line":373,"in_reply_to":"7f96bb07_15823f50","updated":"2018-01-16 02:00:17.000000000","message":"Thanks for pointing this out, I also checked os-brick code and agree this should be fine here.","commit_id":"e7582b14bf0ffd9ce73c995aebe1a8fd7ab322fe"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"0785bf98e27810c77692f88f9dfb6312d536122e","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                           target_portal\u003dtarget_portals[0],"},{"line_number":371,"context_line":"                           target_iqn\u003dtarget_iqns[0],"},{"line_number":372,"context_line":"                           target_lun\u003dtarget_luns[0])"},{"line_number":373,"context_line":"        if len(target_portals) \u003e 1:"},{"line_number":374,"context_line":"            # multiple network spaces defined"},{"line_number":375,"context_line":"            result_data.update(dict(target_portals\u003dtarget_portals,"},{"line_number":376,"context_line":"                                    target_iqns\u003dtarget_iqns,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_dc437f6b","side":"PARENT","line":373,"in_reply_to":"7f96bb07_7ae94018","updated":"2018-01-16 12:05:41.000000000","message":"Done","commit_id":"e7582b14bf0ffd9ce73c995aebe1a8fd7ab322fe"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"09c2f77f718e76dfc4a8c9987af0f32f93c09133","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                           target_portal\u003dtarget_portals[0],"},{"line_number":371,"context_line":"                           target_iqn\u003dtarget_iqns[0],"},{"line_number":372,"context_line":"                           target_lun\u003dtarget_luns[0])"},{"line_number":373,"context_line":"        if len(target_portals) \u003e 1:"},{"line_number":374,"context_line":"            # multiple network spaces defined"},{"line_number":375,"context_line":"            result_data.update(dict(target_portals\u003dtarget_portals,"},{"line_number":376,"context_line":"                                    target_iqns\u003dtarget_iqns,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_15823f50","side":"PARENT","line":373,"in_reply_to":"7f96bb07_7ae94018","updated":"2018-01-15 14:17:24.000000000","message":"This is actually OK:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/dell_emc/sc/storagecenter_api.py#L1899\n\nIf single path, it will just look for the value of target_iqn. If multipath is being used, it will look at target_iqns. It does not hurt to include both in the response.","commit_id":"e7582b14bf0ffd9ce73c995aebe1a8fd7ab322fe"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"0785bf98e27810c77692f88f9dfb6312d536122e","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                           target_portal\u003dtarget_portals[0],"},{"line_number":371,"context_line":"                           target_iqn\u003dtarget_iqns[0],"},{"line_number":372,"context_line":"                           target_lun\u003dtarget_luns[0])"},{"line_number":373,"context_line":"        if len(target_portals) \u003e 1:"},{"line_number":374,"context_line":"            # multiple network spaces defined"},{"line_number":375,"context_line":"            result_data.update(dict(target_portals\u003dtarget_portals,"},{"line_number":376,"context_line":"                                    target_iqns\u003dtarget_iqns,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_bc5eb341","side":"PARENT","line":373,"in_reply_to":"7f96bb07_997e7a69","updated":"2018-01-16 12:05:41.000000000","message":"Done","commit_id":"e7582b14bf0ffd9ce73c995aebe1a8fd7ab322fe"}]}