)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a4356b6a2fa72baab213a05b846b3c4c95a43903","unresolved":false,"context_lines":[{"line_number":11,"context_line":"driver a chance to rename the backend volume (if they are sensitive"},{"line_number":12,"context_line":"to looking up the volume by name property, for example). This is fine"},{"line_number":13,"context_line":"for retype operations where the target volume resides in such a driver."},{"line_number":14,"context_line":"But if the source volume driver has the same sensitivity, then what"},{"line_number":15,"context_line":"happens for a retype is that the volume properties and metadata get"},{"line_number":16,"context_line":"swapped and the original volume gets deleted, but the delete operation"},{"line_number":17,"context_line":"ends up not doing anything because the volume cannot be found."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_cf175851","line":14,"updated":"2018-01-15 21:40:30.000000000","message":"This actually sounds like a bug in the driver. The source driver should still be able to locate the original volume and delete it.","commit_id":"9e58a19a1b2b3e7522605c718fa01077b655e3b6"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"8c87e2a0462fd66c604babe4f6cdd2964ec5ca2a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"driver a chance to rename the backend volume (if they are sensitive"},{"line_number":12,"context_line":"to looking up the volume by name property, for example). This is fine"},{"line_number":13,"context_line":"for retype operations where the target volume resides in such a driver."},{"line_number":14,"context_line":"But if the source volume driver has the same sensitivity, then what"},{"line_number":15,"context_line":"happens for a retype is that the volume properties and metadata get"},{"line_number":16,"context_line":"swapped and the original volume gets deleted, but the delete operation"},{"line_number":17,"context_line":"ends up not doing anything because the volume cannot be found."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_f2147ba2","line":14,"in_reply_to":"7f96bb07_cf175851","updated":"2018-01-15 22:06:54.000000000","message":"I ran into the problem with both storwize and ibm_storage drivers. I suppose if they re-architected to not use volume.name for backend lookup, then they avoid the problem. Otherwise not sure of driver-based solution. Proposed this solution in case it was an oversight in the manager.","commit_id":"9e58a19a1b2b3e7522605c718fa01077b655e3b6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e61993a6c22908fded45bf3567ed1a3d0805e205","unresolved":false,"context_lines":[{"line_number":11,"context_line":"driver a chance to rename the backend volume (if they are sensitive"},{"line_number":12,"context_line":"to looking up the volume by name property, for example). This is fine"},{"line_number":13,"context_line":"for retype operations where the target volume resides in such a driver."},{"line_number":14,"context_line":"But if the source volume driver has the same sensitivity, then what"},{"line_number":15,"context_line":"happens for a retype is that the volume properties and metadata get"},{"line_number":16,"context_line":"swapped and the original volume gets deleted, but the delete operation"},{"line_number":17,"context_line":"ends up not doing anything because the volume cannot be found."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_f2631b19","line":14,"in_reply_to":"7f96bb07_f2147ba2","updated":"2018-01-15 22:18:23.000000000","message":"Sounds like both are not correct. Drivers should really use the provider_location field or similar method to track the actual volume on the device. Name is not the right way to do this.","commit_id":"9e58a19a1b2b3e7522605c718fa01077b655e3b6"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"73c48c0940ec1ab2eb60c45f9d5eee32b87c8d9d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"driver a chance to rename the backend volume (if they are sensitive"},{"line_number":12,"context_line":"to looking up the volume by name property, for example). This is fine"},{"line_number":13,"context_line":"for retype operations where the target volume resides in such a driver."},{"line_number":14,"context_line":"But if the source volume driver has the same sensitivity, then what"},{"line_number":15,"context_line":"happens for a retype is that the volume properties and metadata get"},{"line_number":16,"context_line":"swapped and the original volume gets deleted, but the delete operation"},{"line_number":17,"context_line":"ends up not doing anything because the volume cannot be found."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_c8866edc","line":14,"in_reply_to":"7f96bb07_f2631b19","updated":"2018-01-15 23:36:46.000000000","message":"Agreed.","commit_id":"9e58a19a1b2b3e7522605c718fa01077b655e3b6"}]}