)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"8c7384040a4b34775d5ecfbca3ce4e5d626109e2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since it has defined constants.SCHEDULER_BINARY and"},{"line_number":10,"context_line":"constants.BACKUP_BINARY, this patch change some cinder"},{"line_number":11,"context_line":"scheduler and backup strings to use constans.SCHEDULER_BINARY"},{"line_number":12,"context_line":"and constants.BACKUP_BINARY."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I98bfb8366adf6ae8c04fa8a5f1c36e17a9ffa52e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_495252e0","line":12,"updated":"2018-01-16 09:50:47.000000000","message":"BACKUP_TOPIC and SCHEDULE_TOPIC are also used in this patch, then they are better to be mentioned in commit message too.","commit_id":"0bf8e1d305905fc19f41a12c404b65321bb5bc08"}],"cinder/tests/unit/api/contrib/test_services.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"8c7384040a4b34775d5ecfbca3ce4e5d626109e2","unresolved":false,"context_lines":[{"line_number":609,"context_line":"        req \u003d ("},{"line_number":610,"context_line":"            fakes.HTTPRequest.blank(\u0027v1/fake/os-services/disable-log-reason\u0027))"},{"line_number":611,"context_line":"        body \u003d {\u0027host\u0027: \u0027host1\u0027,"},{"line_number":612,"context_line":"                \u0027binary\u0027: constants.SCHEDULER_BINARY,"},{"line_number":613,"context_line":"                \u0027disabled_reason\u0027: \u0027test-reason\u0027,"},{"line_number":614,"context_line":"                }"},{"line_number":615,"context_line":"        res_dict \u003d self.controller.update(req, \"disable-log-reason\", body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_4946d2c2","line":612,"updated":"2018-01-16 09:50:47.000000000","message":"Looks like constants is not uses consistent in unittests, maybe  it\u0027s not neccessary to change all literal string to an constant?","commit_id":"0bf8e1d305905fc19f41a12c404b65321bb5bc08"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"8c7384040a4b34775d5ecfbca3ce4e5d626109e2","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        req \u003d ("},{"line_number":638,"context_line":"            fakes.HTTPRequest.blank(\u0027v1/fake/os-services/disable-log-reason\u0027))"},{"line_number":639,"context_line":"        body \u003d {\u0027host\u0027: \u0027host1\u0027,"},{"line_number":640,"context_line":"                \u0027binary\u0027: constants,"},{"line_number":641,"context_line":"                \u0027disabled_reason\u0027: None,"},{"line_number":642,"context_line":"                }"},{"line_number":643,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_a9267614","line":640,"updated":"2018-01-16 09:50:47.000000000","message":"typo?","commit_id":"0bf8e1d305905fc19f41a12c404b65321bb5bc08"}],"cinder/tests/unit/test_cmd.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"872fcd070cddc1992a8459e3ec95a9047d7fd616","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        log_setup.assert_called_once_with(CONF, \"cinder\")"},{"line_number":137,"context_line":"        monkey_patch.assert_called_once_with()"},{"line_number":138,"context_line":"        service_create.assert_called_once_with("},{"line_number":139,"context_line":"             binary\u003dconstants.SCHEDULER_BINARY)"},{"line_number":140,"context_line":"        service_serve.assert_called_once_with(server)"},{"line_number":141,"context_line":"        service_wait.assert_called_once_with()"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_19026ab5","line":139,"updated":"2018-01-24 07:04:07.000000000","message":"please check indent","commit_id":"c22315da01b537cbd4fd7b785961a67b99f69fe8"}],"cinder/tests/unit/test_rpc.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"8c7384040a4b34775d5ecfbca3ce4e5d626109e2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class FakeAPI(rpc.RPCAPI):"},{"line_number":25,"context_line":"    RPC_API_VERSION \u003d \u00271.5\u0027"},{"line_number":26,"context_line":"    TOPIC \u003d \u0027cinder-scheduler-topic\u0027"},{"line_number":27,"context_line":"    BINARY \u003d constants.SCHEDULER_BINARY"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_c959828e","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":36},"updated":"2018-01-16 09:50:47.000000000","message":"Should this line also be updated?","commit_id":"0bf8e1d305905fc19f41a12c404b65321bb5bc08"},{"author":{"_account_id":25388,"name":"liuyamin","email":"liuyamin@fiberhome.com","username":"liuyamin"},"change_message_id":"e91bdc253cc966baf0d81f25aa90cc184c5b671a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class FakeAPI(rpc.RPCAPI):"},{"line_number":25,"context_line":"    RPC_API_VERSION \u003d \u00271.5\u0027"},{"line_number":26,"context_line":"    TOPIC \u003d \u0027cinder-scheduler-topic\u0027"},{"line_number":27,"context_line":"    BINARY \u003d constants.SCHEDULER_BINARY"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_4d3d5edb","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":36},"in_reply_to":"7f96bb07_c959828e","updated":"2018-02-02 02:02:13.000000000","message":"Done","commit_id":"0bf8e1d305905fc19f41a12c404b65321bb5bc08"}]}